GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — fix: Update milvus connect function to work with remote instance by Fiona-Waters · Pull Request #5382 · feast-dev/feast

fix: Update milvus connect function to work with remote instance #5382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

franciscojavierarceo merged 1 commit into feast-dev:master from Fiona-Waters:milvus

May 22, 2025

Uh oh!

There was an error while loading. Please reload this page.

Merged

fix: Update milvus connect function to work with remote instance #5382

Changes from all commits

Commits

Show all changes

1 commit

Select commit

9aa7e13

Updating connect function to work with remote instance

Fiona-Waters May 22, 2025

File filter

Filter by extension .py (1) All 1 file type selected

Viewed files

Clear filters

Conversations

Failed to load comments.

Uh oh!

There was an error while loading. Please reload this page.

Jump to

Jump to file

Failed to load files.

Uh oh!

There was an error while loading. Please reload this page.

Diff view

Unified

Split

Hide whitespace

Diff view

Unified

Split

Hide whitespace

There are no files selected for viewing

9 changes: 6 additions & 3 deletions 9 sdk/python/feast/infra/online_stores/milvus_online_store/milvus.py

Show comments

View file

Open in desktop

Original file line number	Diff line number	Diff line change
Expand Up		@@ -88,7 +88,7 @@ class MilvusOnlineStoreConfig(FeastConfigBaseModel, VectorStoreConfig):
		"""

		type: Literal["milvus"] = "milvus"
		path: Optional[StrictStr] = "online_store.db"
		path: Optional[StrictStr] = ""
		host: Optional[StrictStr] = "localhost"
		port: Optional[int] = 19530
		index_type: Optional[str] = "FLAT"
Expand Down Expand Up		@@ -126,13 +126,16 @@ def _get_db_path(self, config: RepoConfig) -> str:

		def _connect(self, config: RepoConfig) -> MilvusClient:
		if not self.client:
		if config.provider == "local":
		if config.provider == "local" and config.online_store.path:
		db_path = self._get_db_path(config)
		print(f"Connecting to Milvus in local mode using {db_path}")
		self.client = MilvusClient(db_path)
		else:
		print(
		f"Connecting to Milvus remotely at {config.online_store.host}:{config.online_store.port}"
		)
		self.client = MilvusClient(
		url=f"{config.online_store.host}:{config.online_store.port}",
		uri=f"{config.online_store.host}:{config.online_store.port}",
		token=f"{config.online_store.username}:{config.online_store.password}"
		if config.online_store.username and config.online_store.password
		else "",
Expand Down

Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.