GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — feat: Hybrid offline store by haoxu0 · Pull Request #5510 · feast-dev/feast

Conversation

What this PR does / why we need it:

Which issue(s) this PR fixes:

Misc

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

haoxu0 added 2 commits

July 13, 2025 10:36


          add hybrid offline store

c738a8e

Signed-off-by: HaoXuAI <[email protected]>


          add hybrid offline store

b765b5e

Signed-off-by: HaoXuAI <[email protected]>

haoxu0 requested a review from a team as a code owner

July 13, 2025 17:38

franciscojavierarceo reviewed

Jul 13, 2025

View reviewed changes

Comment thread

sdk/python/feast/infra/offline_stores/hybrid_offline_store.py Outdated


		_source_to_store_key = {
		FileSource: "file",
		SnowflakeSource: "snowflake",

franciscojavierarceo Jul 13, 2025

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

haoxu0 Jul 14, 2025

Copy link

Copy Markdown

Collaborator Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

placeholder for testing. updated

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

franciscojavierarceo reacted with thumbs up emoji

All reactions

👍 1 reaction


          fix source type

fd695e8

Signed-off-by: HaoXuAI <[email protected]>

haoxu0 requested a review from sudohainguyen as a code owner

July 14, 2025 06:52

franciscojavierarceo reviewed

Jul 14, 2025

View reviewed changes

Comment thread

sdk/python/feast/infra/offline_stores/contrib/couchbase_offline_store/couchbase_source.py

		"""A CouchbaseColumnarSource object defines a data source that a CouchbaseColumnarOfflineStore class can use."""

		def source_type(self) -> DataSourceProto.SourceType.ValueType:
		# TODO: Add Couchbase to DataSourceProto.SourceType

franciscojavierarceo Jul 14, 2025

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not just add all of this now ? is the scope large?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

haoxu0 Jul 14, 2025 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Collaborator Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah it will have to update the protobuf and someother places, which will do it in next PR

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

franciscojavierarceo reacted with thumbs up emoji

All reactions

👍 1 reaction

haoxu0 added the ok-to-test label

Jul 14, 2025

haoxu0 added 4 commits

July 14, 2025 10:55


          update doc

02b2cdb

Signed-off-by: HaoXuAI <[email protected]>


          update doc

bc379f5

Signed-off-by: HaoXuAI <[email protected]>


          update doc

d338885

Signed-off-by: HaoXuAI <[email protected]>


          update doc

5af1cf2

Signed-off-by: HaoXuAI <[email protected]>

franciscojavierarceo approved these changes

Jul 15, 2025

View reviewed changes

franciscojavierarceo left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀🚀🚀🚀🚀🚀

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

franciscojavierarceo merged commit 8f1af55 into master

Jul 15, 2025

franciscojavierarceo commented Jul 15, 2025

Copy link

Copy Markdown

Member

FYI @ntkathole

ntkathole reacted with thumbs up emoji

All reactions

👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

franciscojavierarceo pushed a commit that referenced this pull request

Jul 21, 2025


          chore(release): release 0.51.0

8f6555f

# [0.51.0](v0.50.0...v0.51.0) (2025-07-21)

### Bug Fixes

* FeatureView serialization with cycle detection ([#5502](#5502)) ([f287ca5](f287ca5))
* Fix current version in publish workflow ([#5499](#5499)) ([0af6e94](0af6e94))
* Fix NPM authentication ([#5506](#5506)) ([9f85892](9f85892))
* Fix verify wheels workflow for macos14 ([#5486](#5486)) ([07174cc](07174cc))
* Fixed error thrown for invalid project name on features api ([#5525](#5525)) ([4a9a5d0](4a9a5d0))
* Fixed ODFV on-write transformations ([271ef74](271ef74))
* Move Install OS X dependencies before python setup ([#5488](#5488)) ([35f211c](35f211c))
* Normalize current version by removing 'v' prefix if present ([#5500](#5500)) ([43f3d52](43f3d52))
* Skip macOS 14 with Python 3.10 due to gettext library ([#5490](#5490)) ([41d4977](41d4977))
* Standalone Web UI Publish Workflow ([#5498](#5498)) ([c47b134](c47b134))

### Features

* Added endpoints to allow user to get data for all projects ([4e06965](4e06965))
* Added grpc and rest endpoint for features ([#5519](#5519)) ([0a75696](0a75696))
* Added relationship support to all API endpoints ([#5496](#5496)) ([bea83e7](bea83e7))
* Continue updating doc ([#5523](#5523)) ([ea53b2b](ea53b2b))
* Hybrid offline store ([#5510](#5510)) ([8f1af55](8f1af55))
* Populate created and updated timestamp on data sources ([af3056b](af3056b))
* Provide ready-to-use Python definitions in api ([37628d9](37628d9))
* Snowflake source. fetch MAX in a single query ([#5387](#5387)) ([b49cea1](b49cea1))
* Support compute engine to use multi feature views as source ([#5482](#5482)) ([b9ac90b](b9ac90b))
* Support pagination and sorting on registry apis ([#5495](#5495)) ([c4b6fbe](c4b6fbe))
* Update doc ([#5521](#5521)) ([2808ce1](2808ce1))

haoxu0 pushed a commit that referenced this pull request

Aug 11, 2025


          chore(release): release 0.51.0

52cd921

# [0.51.0](v0.50.0...v0.51.0) (2025-07-21)

### Bug Fixes

* FeatureView serialization with cycle detection ([#5502](#5502)) ([f287ca5](f287ca5))
* Fix current version in publish workflow ([#5499](#5499)) ([0af6e94](0af6e94))
* Fix NPM authentication ([#5506](#5506)) ([9f85892](9f85892))
* Fix verify wheels workflow for macos14 ([#5486](#5486)) ([07174cc](07174cc))
* Fixed error thrown for invalid project name on features api ([#5525](#5525)) ([4a9a5d0](4a9a5d0))
* Fixed ODFV on-write transformations ([271ef74](271ef74))
* Move Install OS X dependencies before python setup ([#5488](#5488)) ([35f211c](35f211c))
* Normalize current version by removing 'v' prefix if present ([#5500](#5500)) ([43f3d52](43f3d52))
* Skip macOS 14 with Python 3.10 due to gettext library ([#5490](#5490)) ([41d4977](41d4977))
* Standalone Web UI Publish Workflow ([#5498](#5498)) ([c47b134](c47b134))

### Features

* Added endpoints to allow user to get data for all projects ([4e06965](4e06965))
* Added grpc and rest endpoint for features ([#5519](#5519)) ([0a75696](0a75696))
* Added relationship support to all API endpoints ([#5496](#5496)) ([bea83e7](bea83e7))
* Continue updating doc ([#5523](#5523)) ([ea53b2b](ea53b2b))
* Hybrid offline store ([#5510](#5510)) ([8f1af55](8f1af55))
* Populate created and updated timestamp on data sources ([af3056b](af3056b))
* Provide ready-to-use Python definitions in api ([37628d9](37628d9))
* Snowflake source. fetch MAX in a single query ([#5387](#5387)) ([b49cea1](b49cea1))
* Support compute engine to use multi feature views as source ([#5482](#5482)) ([b9ac90b](b9ac90b))
* Support pagination and sorting on registry apis ([#5495](#5495)) ([c4b6fbe](c4b6fbe))
* Update doc ([#5521](#5521)) ([2808ce1](2808ce1))

Reviewers

franciscojavierarceo

franciscojavierarceo approved these changes

sudohainguyen

Awaiting requested review from sudohainguyen

sudohainguyen is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

ok-to-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

haoxu0 commented Jul 13, 2025

What this PR does / why we need it:

Which issue(s) this PR fixes:

Misc

Uh oh!

franciscojavierarceo Jul 13, 2025

Choose a reason for hiding this comment

Uh oh!

haoxu0 Jul 14, 2025

Choose a reason for hiding this comment

Uh oh!

franciscojavierarceo Jul 14, 2025

Choose a reason for hiding this comment

Uh oh!

haoxu0 Jul 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

franciscojavierarceo left a comment

Choose a reason for hiding this comment

Uh oh!

franciscojavierarceo commented Jul 15, 2025

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

haoxu0 Jul 14, 2025 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.