GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — fix: Push Source inherits the timestamp fields from Data Source by jyejare · Pull Request #5550 · feast-dev/feast

Conversation

@jyejare

@jyejare jyejare commented Aug 1, 2025

Copy link
Copy Markdown
Collaborator

What this PR does / why we need it:

Inherits the timestamp fields from batch source / data source to push source.

Which issue(s) this PR fixes:

Fixes: #5549

Misc

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@jyejare
jyejare requested a review from a team as a code owner August 1, 2025 13:22
@jyejare jyejare changed the title Push Source inherits the timestamp fields from Data Source fix: Push Source inherits the timestamp fields from Data Source Aug 1, 2025
@jyejare
Push Source inherits the timestamp fields from Data Source
15f7434
Signed-off-by: jyejare <[email protected]>
@jyejare
jyejare force-pushed the PS_uses_BS branch from 6cde669 to 15f7434 Compare August 1, 2025 13:55
@ntkathole ntkathole added the ok-to-test label Aug 4, 2025
franciscojavierarceo
franciscojavierarceo approved these changes Aug 4, 2025
View reviewed changes
@franciscojavierarceo
franciscojavierarceo merged commit b7ea5cc into feast-dev:master Aug 4, 2025
haoxu0 pushed a commit that referenced this pull request Aug 11, 2025
@jyejare @haoxu0
fix: Push Source inherits the timestamp fields from Data Source (#5550)
b4e0e54
franciscojavierarceo pushed a commit that referenced this pull request Aug 14, 2025
@feast-ci-bot
chore(release): release 0.52.0
acb97fb
# [0.52.0](v0.51.0...v0.52.0) (2025-08-14)

### Bug Fixes

* Correct entity value type mapping for aliased feature views ([#5492](#5492)) ([bdf20bb](bdf20bb))
* Correct namespace reference in remote Feast project setup for operator upgrade and previous version tests ([df391ec](df391ec))
* dell pydantic v1 ([1189512](1189512))
* Fixed the entity to on-demand feature view relationship ([1c59bba](1c59bba))
* Make transformers optional ([#5544](#5544)) ([a4eef38](a4eef38))
* Push Source inherits the timestamp fields from Data Source ([#5550](#5550)) ([b7ea5cc](b7ea5cc))
* Remove the devcontainer folder. ([a9815c2](a9815c2))

### Features

* Added API for discovering Feature Views by popular tags ([#5558](#5558)) ([2e5f564](2e5f564))
* Added filtering support for featureView and featureServices api ([#5552](#5552)) ([897b3f3](897b3f3))
* Added global search api and necessary unit tests ([#5532](#5532)) ([dd3061f](dd3061f))
* Added Ray Compute Engine and Ray Offline Store Support ([#5526](#5526)) ([72de088](72de088))
* Added recent visit logging api for registry server ([#5545](#5545)) ([2adcf2c](2adcf2c))
* **auth:** support client-credentials & static token for OIDC client auth ([fc44222](fc44222))
* **auth:** support client-credentials & static token for OIDC client auth ([795fc06](795fc06))
* Implement and enhance remote document retrieval functionality ([#5487](#5487)) ([d095b96](d095b96))
* Implemented consistent error handling ([7f10151](7f10151))
* Offline Store historical features retrieval without entity df, but based on datatime range ([#5527](#5527)) ([df942b9](df942b9))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@franciscojavierarceo franciscojavierarceo franciscojavierarceo approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

ok-to-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Cannot push the data to Offline store server, due to incorrect timestamp fields

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@jyejare @franciscojavierarceo @ntkathole
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.