GeezerVison is showing github.com — feat: Add flexible commandArgs support for complete Feast CLI control by blaketastic2 · Pull Request #5678 · feast-dev/feast
Conversation
What this PR does / why we need it:
- Introduces a new
commandArgs parameter that allows complete control over Feast CLI command-line arguments
- Maintains full backward compatibility with existing configurations through fallback logic
- Enables access to all Feast CLI options including previously unavailable ones like
--root_path, --registry_ttl_sec, custom ports, and future options
- Provides comprehensive documentation and examples for all Feast deployment modes
Creates a future-proof solution that doesn't require template updates for new Feast CLI features
The current Feast Helm chart limits configurability by hardcoding CLI arguments. This creates several problems:
- Missing Functionality: Users cannot access many Feast CLI options (e.g.,
--root_path for UI proxy support, --registry_ttl_sec for registry refresh control)
- Maintenance Burden: Every new Feast CLI option requires template modifications and chart updates
Inflexibility: Complex deployment scenarios requiring custom argument ordering or conditional options are impossible
- User Workarounds: Forces users to fork charts or use suboptimal configurations
This PR allows for flexible, comprehensive solution that will grow with Feast's capabilities while preserving existing functionality.
Which issue(s) this PR fixes:
None
Misc
None
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.