GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — chore: Refactor some unit tests into integration tests by franciscojavierarceo · Pull Request #5820 · feast-dev/feast

Conversation

@franciscojavierarceo

@franciscojavierarceo franciscojavierarceo commented Jan 6, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

What this PR does / why we need it:

Unit tests should be clean and not require k8s/kind cluster.

Which issue(s) this PR fixes:

Misc

Some cleanup from #5548

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
franciscojavierarceo added 2 commits January 6, 2026 10:51
@franciscojavierarceo
chore: Refactor some unit tests into integration tests
d292310
Signed-off-by: Francisco Javier Arceo <[email protected]>
@franciscojavierarceo
chore: Refactor some unit tests into integration tests
d3a66fe
Signed-off-by: Francisco Javier Arceo <[email protected]>
@franciscojavierarceo
franciscojavierarceo requested a review from a team as a code owner January 6, 2026 15:53
@franciscojavierarceo franciscojavierarceo added the ok-to-test label Jan 6, 2026
franciscojavierarceo added 5 commits January 6, 2026 11:16
@franciscojavierarceo
rename TestConfig
60484bc
Signed-off-by: Francisco Javier Arceo <[email protected]>
@franciscojavierarceo
rename TestConfig
021811e
Signed-off-by: Francisco Javier Arceo <[email protected]>
@franciscojavierarceo
add integration flag
533110c
Signed-off-by: Francisco Javier Arceo <[email protected]>
@franciscojavierarceo
update paths
29f8280
Signed-off-by: Francisco Javier Arceo <[email protected]>
@franciscojavierarceo
update paths
95f5098
Signed-off-by: Francisco Javier Arceo <[email protected]>
shuchu
shuchu approved these changes Jan 6, 2026
View reviewed changes
@franciscojavierarceo
franciscojavierarceo merged commit bbba34c into master Jan 6, 2026
20 checks passed

Uh oh!

There was an error while loading. Please reload this page.

franciscojavierarceo added a commit that referenced this pull request Jan 7, 2026
@franciscojavierarceo
chore: Refactor some unit tests into integration tests (#5820)
6c35d45
* chore: Refactor some unit tests into integration tests

Signed-off-by: Francisco Javier Arceo <[email protected]>

* chore: Refactor some unit tests into integration tests

Signed-off-by: Francisco Javier Arceo <[email protected]>

* rename TestConfig

Signed-off-by: Francisco Javier Arceo <[email protected]>

* rename TestConfig

Signed-off-by: Francisco Javier Arceo <[email protected]>

* add integration flag

Signed-off-by: Francisco Javier Arceo <[email protected]>

* update paths

Signed-off-by: Francisco Javier Arceo <[email protected]>

* update paths

Signed-off-by: Francisco Javier Arceo <[email protected]>

---------

Signed-off-by: Francisco Javier Arceo <[email protected]>
YassinNouh21 pushed a commit to YassinNouh21/feast that referenced this pull request Jan 10, 2026
@franciscojavierarceo @YassinNouh21
chore: Refactor some unit tests into integration tests (feast-dev#5820)
3fea93e
* chore: Refactor some unit tests into integration tests

Signed-off-by: Francisco Javier Arceo <[email protected]>

* chore: Refactor some unit tests into integration tests

Signed-off-by: Francisco Javier Arceo <[email protected]>

* rename TestConfig

Signed-off-by: Francisco Javier Arceo <[email protected]>

* rename TestConfig

Signed-off-by: Francisco Javier Arceo <[email protected]>

* add integration flag

Signed-off-by: Francisco Javier Arceo <[email protected]>

* update paths

Signed-off-by: Francisco Javier Arceo <[email protected]>

* update paths

Signed-off-by: Francisco Javier Arceo <[email protected]>

---------

Signed-off-by: Francisco Javier Arceo <[email protected]>
Signed-off-by: yassinnouh21 <[email protected]>
YassinNouh21 pushed a commit to YassinNouh21/feast that referenced this pull request Feb 7, 2026
@franciscojavierarceo @YassinNouh21
chore: Refactor some unit tests into integration tests (feast-dev#5820)
e8af4f2
* chore: Refactor some unit tests into integration tests

Signed-off-by: Francisco Javier Arceo <[email protected]>

* chore: Refactor some unit tests into integration tests

Signed-off-by: Francisco Javier Arceo <[email protected]>

* rename TestConfig

Signed-off-by: Francisco Javier Arceo <[email protected]>

* rename TestConfig

Signed-off-by: Francisco Javier Arceo <[email protected]>

* add integration flag

Signed-off-by: Francisco Javier Arceo <[email protected]>

* update paths

Signed-off-by: Francisco Javier Arceo <[email protected]>

* update paths

Signed-off-by: Francisco Javier Arceo <[email protected]>

---------

Signed-off-by: Francisco Javier Arceo <[email protected]>
Signed-off-by: yassinnouh21 <[email protected]>
jyejare pushed a commit to opendatahub-io/feast that referenced this pull request Mar 9, 2026
@franciscojavierarceo @jyejare
chore: Refactor some unit tests into integration tests (feast-dev#5820)
a94437f
* chore: Refactor some unit tests into integration tests

Signed-off-by: Francisco Javier Arceo <[email protected]>

* chore: Refactor some unit tests into integration tests

Signed-off-by: Francisco Javier Arceo <[email protected]>

* rename TestConfig

Signed-off-by: Francisco Javier Arceo <[email protected]>

* rename TestConfig

Signed-off-by: Francisco Javier Arceo <[email protected]>

* add integration flag

Signed-off-by: Francisco Javier Arceo <[email protected]>

* update paths

Signed-off-by: Francisco Javier Arceo <[email protected]>

* update paths

Signed-off-by: Francisco Javier Arceo <[email protected]>

---------

Signed-off-by: Francisco Javier Arceo <[email protected]>
@alexxfan alexxfan mentioned this pull request Sep 14, 2026
Automated Sync from master to stable rhoai-rhtap/feast#52
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shuchu shuchu shuchu approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

ok-to-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@franciscojavierarceo @shuchu
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.