GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — chore: Run duckdb offline store tests seperately by tokoko · Pull Request #6041 · feast-dev/feast

Conversation

tokoko commented Mar 1, 2026 •

edited by devin-ai-integration Bot

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Collaborator

What this PR does / why we need it:

Runs duckdb offline store tests in a separate workflow, full integration suite is really hard to run. we can pull other tests into backend-specific workflows as well to simplify local runs/debugging.
relies on on pixi env defined inside pyproject.toml rather than our custom patched-together lockfiles.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

tokoko requested a review from a team as a code owner

March 1, 2026 13:16

tokoko mentioned this pull request

Mar 1, 2026

fix: Integration test failures #6040

Merged

devin-ai-integration Bot reviewed

Mar 1, 2026

View reviewed changes

devin-ai-integration Bot left a comment

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 6 additional findings.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

tokoko added the ok-to-test label

Mar 1, 2026

franciscojavierarceo reviewed

Mar 1, 2026

View reviewed changes

Comment thread

sdk/python/tests/integration/feature_repos/repo_configuration.py

		create_pushable_feature_view,
		)
		from tests.integration.feature_repos.universal.online_store.bigtable import (
		BigtableOnlineStoreCreator,

franciscojavierarceo Mar 1, 2026

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why remove these?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

tokoko Mar 1, 2026

Copy link

Copy Markdown

Collaborator Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

moved them down to lazily import only when actually used. this way I would have to pull in extra dependencies just for pytest collection stage.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

franciscojavierarceo reacted with thumbs up emoji

All reactions

👍 1 reaction

tokoko added 6 commits

March 2, 2026 13:20


          chore: run duckdb tests seperately

1475aa9

Signed-off-by: tokoko <[email protected]>


          fix: pre-commit

6be8950

Signed-off-by: tokoko <[email protected]>


          fix: pixi env setup

9776f02

Signed-off-by: tokoko <[email protected]>


          fix: lock pixi

59778c8

Signed-off-by: tokoko <[email protected]>


          fix: bump pixi version in workflow

d482727

Signed-off-by: tokoko <[email protected]>


          chore: add workflow for ray offline tests

b251fe2

Signed-off-by: tokoko <[email protected]>

ntkathole force-pushed the split-duckdb-tests branch from b321bc2 to b251fe2 Compare

March 2, 2026 07:50

ntkathole reviewed

Mar 2, 2026

View reviewed changes

Comment thread

pyproject.toml Resolved

Uh oh!

There was an error while loading. Please reload this page.

ntkathole approved these changes

Mar 2, 2026

View reviewed changes

tokoko merged commit 1dffd18 into feast-dev:master

Mar 2, 2026

19 of 26 checks passed

Uh oh!

There was an error while loading. Please reload this page.

tokoko deleted the split-duckdb-tests branch

March 2, 2026 10:35

ntkathole pushed a commit to red-hat-data-services/feast that referenced this pull request

Mar 16, 2026


          chore: Run duckdb offline store tests seperately (feast-dev#6041)

1b79988

* chore: run duckdb tests seperately

Signed-off-by: tokoko <[email protected]>

* fix: pre-commit

Signed-off-by: tokoko <[email protected]>

* fix: pixi env setup

Signed-off-by: tokoko <[email protected]>

* fix: lock pixi

Signed-off-by: tokoko <[email protected]>

* fix: bump pixi version in workflow

Signed-off-by: tokoko <[email protected]>

* chore: add workflow for ray offline tests

Signed-off-by: tokoko <[email protected]>

---------

Signed-off-by: tokoko <[email protected]>

ntkathole pushed a commit to red-hat-data-services/feast that referenced this pull request

Mar 16, 2026


          chore: Run duckdb offline store tests seperately (feast-dev#6041)

222f4cb

* chore: run duckdb tests seperately

Signed-off-by: tokoko <[email protected]>

* fix: pre-commit

Signed-off-by: tokoko <[email protected]>

* fix: pixi env setup

Signed-off-by: tokoko <[email protected]>

* fix: lock pixi

Signed-off-by: tokoko <[email protected]>

* fix: bump pixi version in workflow

Signed-off-by: tokoko <[email protected]>

* chore: add workflow for ray offline tests

Signed-off-by: tokoko <[email protected]>

---------

Signed-off-by: tokoko <[email protected]>

Shizoqua pushed a commit to Shizoqua/feast that referenced this pull request

Mar 18, 2026


          chore: Run duckdb offline store tests seperately (feast-dev#6041)

ff01d4f

* chore: run duckdb tests seperately

Signed-off-by: tokoko <[email protected]>

* fix: pre-commit

Signed-off-by: tokoko <[email protected]>

* fix: pixi env setup

Signed-off-by: tokoko <[email protected]>

* fix: lock pixi

Signed-off-by: tokoko <[email protected]>

* fix: bump pixi version in workflow

Signed-off-by: tokoko <[email protected]>

* chore: add workflow for ray offline tests

Signed-off-by: tokoko <[email protected]>

---------

Signed-off-by: tokoko <[email protected]>
Signed-off-by: Shizoqua <[email protected]>

Reviewers

franciscojavierarceo

franciscojavierarceo left review comments

devin-ai-integration[bot]

devin-ai-integration[bot] left review comments

ntkathole

ntkathole approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

ok-to-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

tokoko commented Mar 1, 2026 • edited by devin-ai-integration Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What this PR does / why we need it:

Uh oh!

devin-ai-integration Bot left a comment

Choose a reason for hiding this comment

✅ Devin Review: No Issues Found

Uh oh!

franciscojavierarceo Mar 1, 2026

Choose a reason for hiding this comment

Uh oh!

tokoko Mar 1, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

tokoko commented Mar 1, 2026 •

edited by devin-ai-integration Bot

Loading

Uh oh!

There was an error while loading. Please reload this page.