GeezerVison is showing github.com — fix: Ray offline store tests are duplicated across 3 workflows by ntkathole · Pull Request #6045 · feast-dev/feast
Conversation
ntkathole
commented
Mar 3, 2026
•
edited by devin-ai-integration
Bot
Loading
Uh oh!
There was an error while loading. Please reload this page.
What this PR does / why we need it:
Ray offline store tests were running 3 times across different workflows, and Ray compute engine tests were running in the main CI instead of the dedicated Ray workflow.
- Removed the try/except block that conditionally appended RayDataSourceCreator to AVAILABLE_OFFLINE_STORES. This was the root cause - Ray was being auto-included in every workflow where it was installable.
- Changed online store from RedisOnlineStoreCreator to {"type": "sqlite"}. The compute engine tests focus on Ray compute, not online store behavior, so sqlite is sufficient and avoids needing redis in the pixi environment.
- Split the single test task into test-offline and test-compute, then combined them with depends-on. The Ray workflow now runs both sdk/python/tests/integration/offline_store (with Ray config) and sdk/python/tests/integration/compute_engines/ray_compute.
- Added
--ignore=sdk/python/tests/integration/compute_engines/ray_compute to test-python-integration (main CI target).
- Replaced test-python-universal-ray-offline and test-python-ray-compute-engine with a single
test-python-ray-integration target.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ Devin Review: No Issues Found
Devin Review analyzed this PR and found no potential bugs to report.
View in Devin Review to see 4 additional findings.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
tokoko
commented
Mar 3, 2026
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
|
#6043 partly fixes this as well
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
#6043 partly fixes this as well
let's merge yours first and then will rebase
|
tokoko reacted with thumbs up emoji
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
This comment was marked as resolved.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. you can ignore registry test fail, not sure how that slipped through. let's take care of other issues separately.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Reviewers
tokoko
tokoko approved these changes
Uh oh!
There was an error while loading. Please reload this page.
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.