GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — chore: Run registry tests separately by tokoko · Pull Request #6043 · feast-dev/feast

Conversation

tokoko commented Mar 2, 2026 •

edited by devin-ai-integration Bot

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Collaborator

What this PR does / why we need it:

Runs registry tests in a separate workflow
both integration and integration-local now ignore registration folder
other misc changes to concentrate all tests with universal_offline_stores marker under offline_store and with universal_online_stores marker under online_store.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          chore: Run registry tests separately

9d7bdf0

Signed-off-by: tokoko <[email protected]>

tokoko requested a review from a team as a code owner

March 2, 2026 18:03

devin-ai-integration Bot reviewed

Mar 2, 2026

View reviewed changes

devin-ai-integration Bot left a comment

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 5 additional findings.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          Merge branch 'master' into cleanup-registry-tests

a0ba762

tokoko added the ok-to-test label

Mar 2, 2026


          fix: various fixes

76cbfab

Signed-off-by: tokoko <[email protected]>

tokoko mentioned this pull request

Mar 3, 2026

fix: Ray offline store tests are duplicated across 3 workflows #6045

Merged

ntkathole approved these changes

Mar 3, 2026

View reviewed changes

ntkathole left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

ntkathole reviewed

Mar 3, 2026

View reviewed changes

Comment thread

.github/workflows/registry-rest-api-tests.yml Outdated

		run: \|
		echo "Running Registry REST API tests..."
		uv run pytest sdk/python/tests/integration/registration/rest_api/test_registry_rest_api.py --integration -s
		cd sdk/python && uv run pytest tests/integration/rest_api/test_registry_rest_api.py --integration -s

ntkathole Mar 3, 2026

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is causing failure in CI.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

tokoko Mar 3, 2026

Copy link

Copy Markdown

Collaborator Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed that, but both remote and rest api tests are still failing for some other (pre-existing) reasons. I'll still merge and let's take care of other failures separately.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          fix: registry api tests

5529cdb

Signed-off-by: tokoko <[email protected]>

tokoko merged commit 867fca7 into feast-dev:master

Mar 3, 2026

24 of 27 checks passed

Uh oh!

There was an error while loading. Please reload this page.

ntkathole pushed a commit to red-hat-data-services/feast that referenced this pull request

Mar 16, 2026


          chore: Run registry tests separately (feast-dev#6043)

27cee39

* chore: Run registry tests separately

Signed-off-by: tokoko <[email protected]>

* fix: various fixes

Signed-off-by: tokoko <[email protected]>

* fix: registry api tests

Signed-off-by: tokoko <[email protected]>

---------

Signed-off-by: tokoko <[email protected]>

ntkathole pushed a commit to red-hat-data-services/feast that referenced this pull request

Mar 16, 2026


          chore: Run registry tests separately (feast-dev#6043)

b6c167f

* chore: Run registry tests separately

Signed-off-by: tokoko <[email protected]>

* fix: various fixes

Signed-off-by: tokoko <[email protected]>

* fix: registry api tests

Signed-off-by: tokoko <[email protected]>

---------

Signed-off-by: tokoko <[email protected]>

Shizoqua pushed a commit to Shizoqua/feast that referenced this pull request

Mar 18, 2026


          chore: Run registry tests separately (feast-dev#6043)

641a11d

* chore: Run registry tests separately

Signed-off-by: tokoko <[email protected]>

* fix: various fixes

Signed-off-by: tokoko <[email protected]>

* fix: registry api tests

Signed-off-by: tokoko <[email protected]>

---------

Signed-off-by: tokoko <[email protected]>
Signed-off-by: Shizoqua <[email protected]>

larrysingleton007 mentioned this pull request

Aug 16, 2026

Key encoding unit test flakes on wall-clock performance bound #6745

Closed

Reviewers

ntkathole

ntkathole approved these changes

devin-ai-integration[bot]

devin-ai-integration[bot] left review comments

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

ok-to-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

tokoko commented Mar 2, 2026 • edited by devin-ai-integration Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What this PR does / why we need it:

Uh oh!

devin-ai-integration Bot left a comment

Choose a reason for hiding this comment

✅ Devin Review: No Issues Found

Uh oh!

ntkathole left a comment

Choose a reason for hiding this comment

Uh oh!

ntkathole Mar 3, 2026

Choose a reason for hiding this comment

Uh oh!

tokoko Mar 3, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

tokoko commented Mar 2, 2026 •

edited by devin-ai-integration Bot

Loading

Uh oh!

There was an error while loading. Please reload this page.