GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — feat: Add ServiceMonitor auto-generation for Prometheus discovery by ntkathole · Pull Request #6126 · feast-dev/feast

feat: Add ServiceMonitor auto-generation for Prometheus discovery #6126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

ntkathole merged 2 commits into feast-dev:master from ntkathole:service_monitor

Mar 25, 2026

Uh oh!

There was an error while loading. Please reload this page.

Merged

feat: Add ServiceMonitor auto-generation for Prometheus discovery #6126

Show file tree

Hide file tree

Changes from all commits

Commits

Show all changes

2 commits

Select commit Hold shift + click to select a range

039f954

feat: Add ServiceMonitor auto-generation for Prometheus discovery

ntkathole Mar 18, 2026

0e758ec

fix: Server-side apply

ntkathole Mar 20, 2026

File filter

Filter by extension .baseline (1) .go (6) .mod (1) .sum (1) .yaml (2) All 5 file types selected

Only manifest files

Viewed files

Clear filters

Conversations

Failed to load comments.

Uh oh!

There was an error while loading. Please reload this page.

Jump to

Jump to file

Failed to load files.

Uh oh!

There was an error while loading. Please reload this page.

Diff view

Unified

Split

Hide whitespace

Diff view

Unified

Split

Hide whitespace

There are no files selected for viewing

4 changes: 2 additions & 2 deletions 4 .secrets.baseline

Show comments

View file

Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Oops, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

11 changes: 11 additions & 0 deletions 11 infra/feast-operator/config/rbac/role.yaml

Show comments

View file

Open in desktop

Original file line number	Diff line number	Diff line change
Expand Up		@@ -101,6 +101,17 @@ rules:
		- get
		- patch
		- update
		- apiGroups:
		- monitoring.coreos.com
		resources:
		- servicemonitors
		verbs:
		- create
		- delete
		- get
		- list
		- patch
		- watch
		- apiGroups:
		- policy
		resources:
Expand Down

11 changes: 11 additions & 0 deletions 11 infra/feast-operator/dist/install.yaml

Show comments

View file

Open in desktop

Original file line number	Diff line number	Diff line change
Expand Up		@@ -20396,6 +20396,17 @@ rules:
		- get
		- patch
		- update
		- apiGroups:
		- monitoring.coreos.com
		resources:
		- servicemonitors
		verbs:
		- create
		- delete
		- get
		- list
		- patch
		- watch
		- apiGroups:
		- policy
		resources:
Expand Down

53 changes: 28 additions & 25 deletions 53 infra/feast-operator/go.mod

Show comments

View file

Open in desktop

Original file line number	Diff line number	Diff line change
Expand Up		@@ -3,44 +3,48 @@ module github.com/feast-dev/feast/infra/feast-operator
		go 1.22.9

		require (
		github.com/onsi/ginkgo/v2 v2.17.1
		github.com/onsi/gomega v1.32.0
		github.com/onsi/ginkgo/v2 v2.17.2
		github.com/onsi/gomega v1.33.1
		github.com/openshift/api v0.0.0-20240912201240-0a8800162826 // release-4.17
		gopkg.in/yaml.v3 v3.0.1
		k8s.io/api v0.30.1
		k8s.io/apimachinery v0.30.1
		k8s.io/client-go v0.30.1
		k8s.io/api v0.30.2
		k8s.io/apimachinery v0.30.2
		k8s.io/client-go v0.30.2
		sigs.k8s.io/controller-runtime v0.18.4
		)

		require (
		github.com/prometheus-operator/prometheus-operator/pkg/client v0.75.0
		k8s.io/utils v0.0.0-20240502163921-fe8a2dddb1d0
		)

		require (
		github.com/antlr/antlr4/runtime/Go/antlr/v4 v4.0.0-20230305170008-8188dc5388df // indirect
		github.com/beorn7/perks v1.0.1 // indirect
		github.com/blang/semver/v4 v4.0.0 // indirect
		github.com/cenkalti/backoff/v4 v4.2.1 // indirect
		github.com/cespare/xxhash/v2 v2.2.0 // indirect
		github.com/davecgh/go-spew v1.1.1 // indirect
		github.com/emicklei/go-restful/v3 v3.11.0 // indirect
		github.com/evanphx/json-patch v4.12.0+incompatible // indirect
		github.com/davecgh/go-spew v1.1.2-0.20180830191138-d8f796af33cc // indirect
		github.com/emicklei/go-restful/v3 v3.12.1 // indirect
		github.com/evanphx/json-patch/v5 v5.9.0 // indirect
		github.com/felixge/httpsnoop v1.0.3 // indirect
		github.com/fsnotify/fsnotify v1.7.0 // indirect
		github.com/go-logr/logr v1.4.1 // indirect
		github.com/go-logr/logr v1.4.2 // indirect
		github.com/go-logr/stdr v1.2.2 // indirect
		github.com/go-logr/zapr v1.3.0 // indirect
		github.com/go-openapi/jsonpointer v0.19.6 // indirect
		github.com/go-openapi/jsonreference v0.20.2 // indirect
		github.com/go-openapi/swag v0.22.3 // indirect
		github.com/go-task/slim-sprig v0.0.0-20230315185526-52ccab3ef572 // indirect
		github.com/go-openapi/jsonpointer v0.21.0 // indirect
		github.com/go-openapi/jsonreference v0.21.0 // indirect
		github.com/go-openapi/swag v0.23.0 // indirect
		github.com/go-task/slim-sprig/v3 v3.0.0 // indirect
		github.com/gogo/protobuf v1.3.2 // indirect
		github.com/golang/groupcache v0.0.0-20210331224755-41bb18bfe9da // indirect
		github.com/golang/protobuf v1.5.4 // indirect
		github.com/google/cel-go v0.17.8 // indirect
		github.com/google/gnostic-models v0.6.8 // indirect
		github.com/google/go-cmp v0.6.0 // indirect
		github.com/google/gofuzz v1.2.0 // indirect
		github.com/google/pprof v0.0.0-20210720184732-4bb14d4b1be1 // indirect
		github.com/google/uuid v1.3.0 // indirect
		github.com/google/pprof v0.0.0-20240424215950-a892ee059fd6 // indirect
		github.com/google/uuid v1.6.0 // indirect
		github.com/grpc-ecosystem/grpc-gateway/v2 v2.16.0 // indirect
		github.com/imdario/mergo v0.3.6 // indirect
		github.com/josharian/intern v1.0.0 // indirect
Expand All		@@ -51,6 +55,7 @@ require (
		github.com/modern-go/reflect2 v1.0.2 // indirect
		github.com/munnerz/goautoneg v0.0.0-20191010083416-a7dc8b61c822 // indirect
		github.com/pkg/errors v0.9.1 // indirect
		github.com/prometheus-operator/prometheus-operator/pkg/apis/monitoring v0.75.0 // indirect
		github.com/prometheus/client_golang v1.18.0 // indirect
		github.com/prometheus/client_model v0.5.0 // indirect
		github.com/prometheus/common v0.45.0 // indirect
Expand All		@@ -69,27 +74,25 @@ require (
		go.uber.org/zap v1.26.0 // indirect
		golang.org/x/exp v0.0.0-20220722155223-a9213eeb770e // indirect
		golang.org/x/net v0.33.0 // indirect
		golang.org/x/oauth2 v0.12.0 // indirect
		golang.org/x/oauth2 v0.21.0 // indirect
		golang.org/x/sync v0.10.0 // indirect
		golang.org/x/sys v0.28.0 // indirect
		golang.org/x/term v0.27.0 // indirect
		golang.org/x/text v0.21.0 // indirect
		golang.org/x/time v0.3.0 // indirect
		golang.org/x/time v0.5.0 // indirect
		golang.org/x/tools v0.21.1-0.20240508182429-e35e4ccd0d2d // indirect
		gomodules.xyz/jsonpatch/v2 v2.4.0 // indirect
		google.golang.org/appengine v1.6.7 // indirect
		google.golang.org/genproto/googleapis/api v0.0.0-20230726155614-23370e0ffb3e // indirect
		google.golang.org/genproto/googleapis/rpc v0.0.0-20230822172742-b8732ec3820d // indirect
		google.golang.org/grpc v1.58.3 // indirect
		google.golang.org/protobuf v1.33.0 // indirect
		google.golang.org/protobuf v1.34.2 // indirect
		gopkg.in/inf.v0 v0.9.1 // indirect
		gopkg.in/yaml.v2 v2.4.0 // indirect
		k8s.io/apiextensions-apiserver v0.30.1 // indirect
		k8s.io/apiserver v0.30.1 // indirect
		k8s.io/component-base v0.30.1 // indirect
		k8s.io/klog/v2 v2.120.1 // indirect
		k8s.io/kube-openapi v0.0.0-20240228011516-70dd3763d340 // indirect
		k8s.io/utils v0.0.0-20230726121419-3b25d923346b // indirect
		k8s.io/apiextensions-apiserver v0.30.2 // indirect
		k8s.io/apiserver v0.30.2 // indirect
		k8s.io/component-base v0.30.2 // indirect
		k8s.io/klog/v2 v2.130.1 // indirect
		k8s.io/kube-openapi v0.0.0-20240620174524-b456828f718b // indirect
		sigs.k8s.io/apiserver-network-proxy/konnectivity-client v0.29.0 // indirect
		sigs.k8s.io/json v0.0.0-20221116044647-bc3834ca7abd // indirect
		sigs.k8s.io/structured-merge-diff/v4 v4.4.1 // indirect
Expand Down

Oops, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Oops, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.