GeezerVison is showing github.com — fix: scope data source operations by project in shared registry by mango766 · Pull Request #6207 · feast-dev/feast
Conversation
mango766
commented
Apr 1, 2026
•
edited by devin-ai-integration
Bot
Loading
Uh oh!
There was an error while loading. Please reload this page.
Summary
Fixes #6206
apply_data_source and delete_data_source in Registry match data sources by name only, without filtering by project. When multiple projects share the same registry and have data sources with the same name (e.g. the default vals_to_add), this causes cross-project overwrites.
Fix
Add the project filter to both methods, consistent with how apply_entity (line 349-352), apply_feature_service (line 447-451), and apply_feature_view (line 779-781) already scope their lookups.
apply_data_source: existing_data_source_proto.name == data_source.name and existing_data_source_proto.project == project
delete_data_source: data_source_proto.name == name and data_source_proto.project == project
Test plan
-
feast apply for project A with data source vals_to_add does not overwrite project B's vals_to_add
-
feast apply for the same project still correctly updates existing data sources
- Deleting a data source only removes the one in the specified project
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
apply_data_source and delete_data_source match by name only, without
filtering by project. When multiple projects share the same registry
and have data sources with the same name, this causes cross-project
overwrites.
Add the project filter to both methods, consistent with how
apply_entity, apply_feature_service, and apply_feature_view already
scope their lookups by both name and project.
Fixes feast-dev#6206
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ Devin Review: No Issues Found
Devin Review analyzed this PR and found no potential bugs to report.
View in Devin Review to see 2 additional findings.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
