GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — test: Expand MilvusOnlineStore integration test coverage by korbonits · Pull Request #6299 · feast-dev/feast

test: Expand MilvusOnlineStore integration test coverage #6299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ntkathole merged 1 commit into feast-dev:master from korbonits:test/milvus-integration-coverage
Apr 22, 2026

Uh oh!

There was an error while loading. Please reload this page.
Merged

test: Expand MilvusOnlineStore integration test coverage #6299

Changes from all commits
Commits
Show all changes
1 commit
Select commit
5eb7471
test: expand MilvusOnlineStore integration test coverage
korbonits Apr 20, 2026
File filter
Filter by extension
Clear filters
Conversations
Failed to load comments.
Loading

Uh oh!

There was an error while loading. Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading

Uh oh!

There was an error while loading. Please reload this page.
Diff view
Diff view

There are no files selected for viewing

68 changes: 63 additions & 5 deletions 68 sdk/python/tests/integration/online_store/test_universal_online.py
Show comments
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -921,13 +921,27 @@ def test_retrieve_online_milvus_documents(environment, fake_document_data):
df, data_source = fake_document_data
item_embeddings_feature_view = create_item_embeddings_feature_view(data_source)
fs.apply([item_embeddings_feature_view, item()])

features = [
"item_embeddings:embedding_float",
"item_embeddings:item_id",
"item_embeddings:string_feature",
]

# Empty-store query: collection exists but has no rows yet.
empty = fs.retrieve_online_documents_v2(
features=features,
query=[1.0, 2.0],
top_k=2,
distance_metric="L2",
).to_dict()
assert len(empty["embedding_float"]) == 0
assert len(empty["item_id"]) == 0

fs.write_to_online_store("item_embeddings", df)

documents = fs.retrieve_online_documents_v2(
features=[
"item_embeddings:embedding_float",
"item_embeddings:item_id",
"item_embeddings:string_feature",
],
features=features,
query=[1.0, 2.0],
top_k=2,
distance_metric="L2",
Expand All @@ -948,6 +962,50 @@ def test_retrieve_online_milvus_documents(environment, fake_document_data):
f"Integration test: embedding {i} has {len(embedding)} dimensions, expected {query_dim}"
)

# Oversized top_k: dataset has 3 rows, request 5 -> expect 3 back.
all_docs = fs.retrieve_online_documents_v2(
features=features,
query=[1.0, 2.0],
top_k=5,
distance_metric="L2",
).to_dict()
assert len(all_docs["embedding_float"]) == 3
assert sorted(all_docs["item_id"]) == [1, 2, 3]

# Cosine-metric variant: separate FV so the Milvus collection is created
# with COSINE as its index metric.
cosine_fv = FeatureView(
name="item_embeddings_cosine",
entities=[item()],
schema=[
Field(
name="embedding_float",
dtype=Array(Float32),
vector_index=True,
vector_search_metric="COSINE",
),
Field(name="string_feature", dtype=String),
Field(name="float_feature", dtype=Float32),
],
source=data_source,
ttl=timedelta(hours=2),
)
fs.apply([cosine_fv])
fs.write_to_online_store("item_embeddings_cosine", df)

cosine_docs = fs.retrieve_online_documents_v2(
features=[
"item_embeddings_cosine:embedding_float",
"item_embeddings_cosine:item_id",
"item_embeddings_cosine:string_feature",
],
query=[1.0, 2.0],
top_k=2,
distance_metric="COSINE",
).to_dict()
assert len(cosine_docs["embedding_float"]) == 2
assert len(cosine_docs["item_id"]) == 2


@pytest.mark.integration
@pytest.mark.universal_online_stores(only=["milvus"])
Expand Down
Loading
Oops, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.