GeezerVison is showing github.com — fix: Add project filter to apply_data_source and delete_data_source by mailtoboggavarapu-coder · Pull Request #6319 · feast-dev/feast
Conversation
Summary
Fixes #6206
apply_data_source and delete_data_source in registry.py were not filtering by project, meaning an operation on one project could silently overwrite or delete data sources with the same name in a different project.
What's changed
- Added project-based filtering to
apply_data_source: duplicate detection is now scoped to the current project
- Added project-based filtering to
delete_data_source: the delete only targets data sources in the specified project
Tests
Added two regression tests in test_universal_registry.py:
test_apply_data_source_cross_project_isolation: verifies applying to project A does not overwrite same-name source in project Btest_delete_data_source_project_scoped: verifies deleting from project A does not affect same-name source in project B
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
…ixes feast-dev#6206)
apply_data_source and delete_data_source were not filtering by project,
so operations on one project could affect data sources in other projects.
Added project-based filtering to both methods to ensure project isolation.
Signed-off-by: Venkateswarlu Boggavarapu <[email protected]>apply_data_source and delete_data_source were not filtering by project,
so operations on one project could affect data sources in other projects.
Added project-based filtering to both methods to ensure project isolation.
Signed-off-by: Venkateswarlu Boggavarapu <[email protected]>
Regression tests for feast-dev#6206: verifies that apply_data_source and
delete_data_source are properly project-scoped and do not affect
data sources in other projects.
Signed-off-by: Venkateswarlu Boggavarapu <[email protected]>
![devin-ai-integration[bot]](/api/image?u=https%3A%2F%2Favatars.githubusercontent.com%2Fin%2F811515%3Fs%3D60%26v%3D4)
This comment was marked as resolved.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
Thanks for the detailed review, @devin-ai-integration! Fixed both encoding corruptions in commit f3437b08:
- Line 706 —
→ (U+2192) was double-encoded as â (bytes c3 a2 c2 86 c2 92); restored to proper → (UTF-8: e2 86 92)
- Line 747 — same double-encoding issue; also restored to
→
Both arrow characters are now correct UTF-8. The em-dash on line 700 was already fixed in the previous commit (3bcaf45).
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
Superseded by PR #6322 which has all commits properly signed with Signed-off-by: (DCO ✅). The DCO failure here was caused by the encoding-fix commits and the "Update branch" merge commit lacking sign-offs. Closing in favor of #6322.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.