GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — fix(operator): Only deploy an online store when it is declared by nikolauspschuetz · Pull Request #6591 · feast-dev/feast

fix(operator): Only deploy an online store when it is declared #6591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

ntkathole merged 1 commit into feast-dev:master from nikolauspschuetz:fix/operator-optional-online-store-6586

Jul 30, 2026

Uh oh!

There was an error while loading. Please reload this page.

Merged

fix(operator): Only deploy an online store when it is declared #6591

Show file tree

Hide file tree

Changes from all commits

Commits

Show all changes

1 commit

Select commit

a5466a5

fix(operator): add spec.services.onlineStore.disabled to opt out of t…

nikolauspschuetz Jul 20, 2026

File filter

Filter by extension .baseline (1) .go (4) .md (1) .yaml (2) All 4 file types selected

Viewed files

Clear filters

Conversations

Failed to load comments.

Uh oh!

There was an error while loading. Please reload this page.

Jump to

Jump to file

Failed to load files.

Uh oh!

There was an error while loading. Please reload this page.

Diff view

Unified

Split

Hide whitespace

Diff view

Unified

Split

Hide whitespace

There are no files selected for viewing

2 changes: 1 addition & 1 deletion 2 .secrets.baseline

Show comments

View file

Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Oops, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

5 changes: 5 additions & 0 deletions 5 infra/feast-operator/api/v1/featurestore_types.go

Show comments

View file

Open in desktop

Original file line number	Diff line number	Diff line change
Expand Up		@@ -544,6 +544,11 @@ type OnlineStore struct {
		// Controls metrics granularity, offline push batching, and MCP.
		// +optional
		Serving *ServingConfig `json:"serving,omitempty"`
		// Disabled skips deploying the online store service entirely, including its
		// serving pod and persistence. Omitting the online store block, or setting
		// this to false, deploys the online store with defaults as before.
		// +optional
		Disabled bool `json:"disabled,omitempty"`
		}

		// ServingConfig configures the feature_server section of the generated feature_store.yaml.
Expand Down

10 changes: 10 additions & 0 deletions 10 infra/feast-operator/config/crd/bases/feast.dev_featurestores.yaml

Show comments

View file

Open in desktop

Original file line number	Diff line number	Diff line change
Expand Up		@@ -2258,6 +2258,11 @@ spec:
		onlineStore:
		description: OnlineStore configures the online store service
		properties:
		disabled:
		description: \|-
		Disabled skips deploying the online store service entirely, including its
		serving pod and persistence.
		type: boolean
		persistence:
		description: OnlineStorePersistence configures the persistence
		settings for the online store service
Expand Down Expand Up		@@ -8562,6 +8567,11 @@ spec:
		onlineStore:
		description: OnlineStore configures the online store service
		properties:
		disabled:
		description: \|-
		Disabled skips deploying the online store service entirely, including its
		serving pod and persistence.
		type: boolean
		persistence:
		description: OnlineStorePersistence configures the persistence
		settings for the online store service
Expand Down

10 changes: 10 additions & 0 deletions 10 infra/feast-operator/dist/install.yaml

Show comments

View file

Open in desktop

Original file line number	Diff line number	Diff line change
Expand Up		@@ -2266,6 +2266,11 @@ spec:
		onlineStore:
		description: OnlineStore configures the online store service
		properties:
		disabled:
		description: \|-
		Disabled skips deploying the online store service entirely, including its
		serving pod and persistence.
		type: boolean
		persistence:
		description: OnlineStorePersistence configures the persistence
		settings for the online store service
Expand Down Expand Up		@@ -8570,6 +8575,11 @@ spec:
		onlineStore:
		description: OnlineStore configures the online store service
		properties:
		disabled:
		description: \|-
		Disabled skips deploying the online store service entirely, including its
		serving pod and persistence.
		type: boolean
		persistence:
		description: OnlineStorePersistence configures the persistence
		settings for the online store service
Expand Down

3 changes: 3 additions & 0 deletions 3 infra/feast-operator/docs/api/markdown/ref.md

Show comments

View file

Open in desktop

Original file line number	Diff line number	Diff line change
Expand Up		@@ -654,6 +654,9 @@ _Appears in:_
		\| `persistence` _[OnlineStorePersistence](#onlinestorepersistence)_ \| \|
		\| `serving` _[ServingConfig](#servingconfig)_ \| Serving configures the Feast feature_server section written into feature_store.yaml for the online serve pod.
		Controls metrics granularity, offline push batching, and MCP. \|
		\| `disabled` _boolean_ \| Disabled skips deploying the online store service entirely, including its
		serving pod and persistence. Omitting the online store block, or setting
		this to false, deploys the online store with defaults as before. \|


		#### OnlineStoreDBStorePersistence
Expand Down

2 changes: 1 addition & 1 deletion 2 infra/feast-operator/internal/controller/services/services.go

Show comments

View file

Open in desktop

Original file line number	Diff line number	Diff line change
Expand Up		@@ -1291,7 +1291,7 @@ func (feast *FeastServices) isOnlineServer() bool {

		func (feast *FeastServices) isOnlineStore() bool {
		appliedServices := feast.Handler.FeatureStore.Status.Applied.Services
		return appliedServices != nil && appliedServices.OnlineStore != nil
		return appliedServices != nil && appliedServices.OnlineStore != nil && !appliedServices.OnlineStore.Disabled
		}

		func (feast *FeastServices) noLocalCoreServerConfigured() bool {
Expand Down

34 changes: 18 additions & 16 deletions 34 infra/feast-operator/internal/controller/services/util.go

Show comments

View file

Open in desktop

Original file line number	Diff line number	Diff line change
Expand Up		@@ -163,30 +163,32 @@ func ApplyDefaultsToStatus(cr *feastdevv1.FeatureStore) {
		}
		}

		// default to onlineStore service deployment
		// default to onlineStore service deployment unless it is explicitly disabled
		if services.OnlineStore == nil {
		services.OnlineStore = &feastdevv1.OnlineStore{}
		}
		if services.OnlineStore.Persistence == nil {
		services.OnlineStore.Persistence = &feastdevv1.OnlineStorePersistence{}
		}

		if services.OnlineStore.Persistence.DBPersistence == nil {
		if services.OnlineStore.Persistence.FilePersistence == nil {
		services.OnlineStore.Persistence.FilePersistence = &feastdevv1.OnlineStoreFilePersistence{}
		if !services.OnlineStore.Disabled {
		if services.OnlineStore.Persistence == nil {
		services.OnlineStore.Persistence = &feastdevv1.OnlineStorePersistence{}
		}

		if len(services.OnlineStore.Persistence.FilePersistence.Path) == 0 {
		services.OnlineStore.Persistence.FilePersistence.Path = defaultOnlineStorePath(cr)
		}
		if services.OnlineStore.Persistence.DBPersistence == nil {
		if services.OnlineStore.Persistence.FilePersistence == nil {
		services.OnlineStore.Persistence.FilePersistence = &feastdevv1.OnlineStoreFilePersistence{}
		}

		ensurePVCDefaults(services.OnlineStore.Persistence.FilePersistence.PvcConfig, OnlineFeastType)
		}
		if len(services.OnlineStore.Persistence.FilePersistence.Path) == 0 {
		services.OnlineStore.Persistence.FilePersistence.Path = defaultOnlineStorePath(cr)
		}

		ensurePVCDefaults(services.OnlineStore.Persistence.FilePersistence.PvcConfig, OnlineFeastType)
		}

		if services.OnlineStore.Server == nil {
		services.OnlineStore.Server = &feastdevv1.ServerConfigs{}
		if services.OnlineStore.Server == nil {
		services.OnlineStore.Server = &feastdevv1.ServerConfigs{}
		}
		setDefaultCtrConfigs(&services.OnlineStore.Server.ContainerConfigs.DefaultCtrConfigs)
		}
		setDefaultCtrConfigs(&services.OnlineStore.Server.ContainerConfigs.DefaultCtrConfigs)

		if services.UI != nil {
		setDefaultCtrConfigs(&services.UI.ContainerConfigs.DefaultCtrConfigs)
Expand Down

83 changes: 83 additions & 0 deletions 83 infra/feast-operator/internal/controller/services/util_test.go

Show comments

View file

Open in desktop

Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,83 @@
		/*
		Copyright 2024 Feast Community.

		Licensed under the Apache License, Version 2.0 (the "License");
		you may not use this file except in compliance with the License.
		You may obtain a copy of the License at

		http://www.apache.org/licenses/LICENSE-2.0

		Unless required by applicable law or agreed to in writing, software
		distributed under the License is distributed on an "AS IS" BASIS,
		WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
		See the License for the specific language governing permissions and
		limitations under the License.
		*/

		package services

		import (
		. "github.com/onsi/ginkgo/v2"
		. "github.com/onsi/gomega"

		feastdevv1 "github.com/feast-dev/feast/infra/feast-operator/api/v1"
		)

		var _ = Describe("ApplyDefaultsToStatus", func() {
		It("deploys the online store with defaults when it is not declared", func() {
		cr := &feastdevv1.FeatureStore{
		Spec: feastdevv1.FeatureStoreSpec{
		FeastProject: "test_project",
		Services: &feastdevv1.FeatureStoreServices{},
		},
		}

		ApplyDefaultsToStatus(cr)

		online := cr.Status.Applied.Services.OnlineStore
		Expect(online).ToNot(BeNil())
		Expect(online.Disabled).To(BeFalse())
		Expect(online.Persistence).ToNot(BeNil())
		Expect(online.Server).ToNot(BeNil())
		})

		It("applies online store defaults when it is declared", func() {
		cr := &feastdevv1.FeatureStore{
		Spec: feastdevv1.FeatureStoreSpec{
		FeastProject: "test_project",
		Services: &feastdevv1.FeatureStoreServices{
		OnlineStore: &feastdevv1.OnlineStore{},
		},
		},
		}

		ApplyDefaultsToStatus(cr)

		online := cr.Status.Applied.Services.OnlineStore
		Expect(online).ToNot(BeNil())
		Expect(online.Persistence).ToNot(BeNil())
		Expect(online.Server).ToNot(BeNil())
		})

		// #6586: disabling the online store opts out of its persistence and serving
		// pod, letting a registry-only or offline-only FeatureStore skip it while
		// leaving the default-on behavior unchanged for everyone else.
		It("does not apply persistence or server defaults when the online store is disabled", func() {
		cr := &feastdevv1.FeatureStore{
		Spec: feastdevv1.FeatureStoreSpec{
		FeastProject: "test_project",
		Services: &feastdevv1.FeatureStoreServices{
		OnlineStore: &feastdevv1.OnlineStore{Disabled: true},
		},
		},
		}

		ApplyDefaultsToStatus(cr)

		online := cr.Status.Applied.Services.OnlineStore
		Expect(online).ToNot(BeNil())
		Expect(online.Disabled).To(BeTrue())
		Expect(online.Persistence).To(BeNil())
		Expect(online.Server).To(BeNil())
		})
		})

Oops, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.