GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — feat: Add plan() support to DynamoDBOnlineStore by casaar97 · Pull Request #6661 · feast-dev/feast

Conversation

@casaar97

@casaar97 casaar97 commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

What this PR does / why we need it

Fixes #6660.

DynamoDBOnlineStore doesn't override OnlineStore.plan(), so it inherits the no-op default and feast plan never reports any DynamoDB table changes. SqliteOnlineStore and MilvusOnlineStore already implement plan(); this brings DynamoDB in line.

Adds:

  • DynamoDBTable(InfraObject), using the InfraObject proto's CustomInfra field (protos/feast/core/InfraObject.proto), which exists specifically so online stores can add InfraObject support without a core proto change -- no other in-tree store uses it yet.
  • DynamoDBOnlineStore.plan(), returning one DynamoDBTable per feature view (batch and stream).

Uses the corrected per-list pattern from #6659 (FeatureView.from_proto() for feature_views, StreamFeatureView.from_proto() for stream_feature_views) rather than applying one function to both, which is what caused the bug in #6658.

Scope note: this only changes what feast plan reports. feast apply's diff-based path (FeatureStore._should_use_plan(), which would call InfraObject.update()/teardown()) is gated to the local/sqlite provider only today, so DynamoDBOnlineStore.update()/teardown() -- which already perform the real table creation/deletion -- are completely unaffected. feast apply behavior for DynamoDB does not change.

Which issue(s) this PR fixes

Fixes #6660

Does this PR introduce a user-facing change?

`feast plan` now reports DynamoDB table changes instead of always showing none.

Test plan

  • Added sdk/python/tests/unit/infra/online_store/test_dynamodb_plan.py: one table per feature view, stream feature views included (regression guard for the sqlite.py's OnlineStore.plan() raises typeguard.TypeCheckError for stream feature views #6658 bug pattern), batch + stream together, empty registry, and a full Infra proto round-trip through the CustomInfra/dotted-class-type path.
  • Confirmed the new tests fail with the expected ImportError before this change, pass after.
  • Ran the full sdk/python/tests/unit/infra/online_store/ directory (210 tests) -- no regressions.
  • ruff check and ruff format --check pass on the changed files.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@casaar97 Carlos Sánchez
feat: add plan() support to DynamoDBOnlineStore
377eb99
DynamoDBOnlineStore has no plan() override, so it inherits
OnlineStore.plan()'s no-op default: `feast plan` never reports any
DynamoDB infrastructure changes, unlike SqliteOnlineStore and
MilvusOnlineStore which both implement it.

Adds DynamoDBTable (InfraObject) and DynamoDBOnlineStore.plan(), using
the InfraObject proto's CustomInfra field (protos/feast/core/InfraObject.proto),
which exists specifically so online stores can add InfraObject support
without changes to the core proto -- no other in-tree store uses it yet.

Note this only affects `feast plan`'s reporting: `feast apply`'s
diff-based path (FeatureStore._should_use_plan(), which would call
InfraObject.update()/teardown()) is gated to the local/sqlite provider
only, so DynamoDBOnlineStore.update()/teardown() -- which already
perform the real table creation/deletion -- are unaffected.

Uses the corrected feature-view-list pattern (see feast-dev#6658 / feast-dev#6659):
FeatureView.from_proto() and StreamFeatureView.from_proto() applied to
their respective proto lists, not one applied to both.

Signed-off-by: Carlos Sánchez <[email protected]>
@casaar97
casaar97 requested a review from a team as a code owner July 29, 2026 12:51
@codecov-commenter

codecov-commenter commented Jul 29, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 45.97%. Comparing base (104ad10) to head (377eb99).
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6661      +/-   ##
==========================================
+ Coverage   45.93%   45.97%   +0.04%     
==========================================
  Files         414      414              
  Lines       50006    50035      +29     
  Branches     7147     7147              
==========================================
+ Hits        22972    23006      +34     
+ Misses      25423    25418       -5     
  Partials     1611     1611              
Flag Coverage Δ
go-feature-server 30.58% <ø> (ø)
python-unit 47.24% <100.00%> (+0.04%) ⬆️
Files with missing lines Coverage Δ
sdk/python/feast/infra/online_stores/dynamodb.py 64.50% <100.00%> (+2.07%) ⬆️

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 104ad10...377eb99. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@casaar97 casaar97 mentioned this pull request Jul 29, 2026
DynamoDBOnlineStore has no plan() support, so feast plan never shows DynamoDB changes #6660
Closed
@ntkathole ntkathole added the ok-to-test label Jul 30, 2026
ntkathole
ntkathole approved these changes Jul 30, 2026
View reviewed changes
@ntkathole
ntkathole merged commit 51ce982 into feast-dev:master Jul 30, 2026
36 checks passed

Uh oh!

There was an error while loading. Please reload this page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ntkathole ntkathole ntkathole approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

ok-to-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

DynamoDBOnlineStore has no plan() support, so feast plan never shows DynamoDB changes

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@casaar97 @codecov-commenter @ntkathole
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.