GeezerVison is showing github.com — feat: Add plan() support to DynamoDBOnlineStore by casaar97 · Pull Request #6661 · feast-dev/feast
Conversation
What this PR does / why we need it
Fixes #6660.
DynamoDBOnlineStore doesn't override OnlineStore.plan(), so it inherits the no-op default and feast plan never reports any DynamoDB table changes. SqliteOnlineStore and MilvusOnlineStore already implement plan(); this brings DynamoDB in line.
Adds:
DynamoDBTable(InfraObject), using the InfraObject proto's CustomInfra field (protos/feast/core/InfraObject.proto), which exists specifically so online stores can add InfraObject support without a core proto change -- no other in-tree store uses it yet.
DynamoDBOnlineStore.plan(), returning one DynamoDBTable per feature view (batch and stream).
Uses the corrected per-list pattern from #6659 (FeatureView.from_proto() for feature_views, StreamFeatureView.from_proto() for stream_feature_views) rather than applying one function to both, which is what caused the bug in #6658.
Scope note: this only changes what feast plan reports. feast apply's diff-based path (FeatureStore._should_use_plan(), which would call InfraObject.update()/teardown()) is gated to the local/sqlite provider only today, so DynamoDBOnlineStore.update()/teardown() -- which already perform the real table creation/deletion -- are completely unaffected. feast apply behavior for DynamoDB does not change.
Which issue(s) this PR fixes
Fixes #6660
Does this PR introduce a user-facing change?
`feast plan` now reports DynamoDB table changes instead of always showing none.
Test plan
- Added
sdk/python/tests/unit/infra/online_store/test_dynamodb_plan.py: one table per feature view, stream feature views included (regression guard for the sqlite.py's OnlineStore.plan() raises typeguard.TypeCheckError for stream feature views #6658 bug pattern), batch + stream together, empty registry, and a full Infra proto round-trip through the CustomInfra/dotted-class-type path.
- Confirmed the new tests fail with the expected
ImportError before this change, pass after.
- Ran the full
sdk/python/tests/unit/infra/online_store/ directory (210 tests) -- no regressions.
ruff check and ruff format --check pass on the changed files.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
DynamoDBOnlineStore has no plan() override, so it inherits
OnlineStore.plan()'s no-op default: `feast plan` never reports any
DynamoDB infrastructure changes, unlike SqliteOnlineStore and
MilvusOnlineStore which both implement it.
Adds DynamoDBTable (InfraObject) and DynamoDBOnlineStore.plan(), using
the InfraObject proto's CustomInfra field (protos/feast/core/InfraObject.proto),
which exists specifically so online stores can add InfraObject support
without changes to the core proto -- no other in-tree store uses it yet.
Note this only affects `feast plan`'s reporting: `feast apply`'s
diff-based path (FeatureStore._should_use_plan(), which would call
InfraObject.update()/teardown()) is gated to the local/sqlite provider
only, so DynamoDBOnlineStore.update()/teardown() -- which already
perform the real table creation/deletion -- are unaffected.
Uses the corrected feature-view-list pattern (see feast-dev#6658 / feast-dev#6659):
FeatureView.from_proto() and StreamFeatureView.from_proto() applied to
their respective proto lists, not one applied to both.
Signed-off-by: Carlos Sánchez <[email protected]>
|
⚠️ Please install the to ensure uploads and comments are reliably processed by Codecov.
✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 45.97%. Comparing base (104ad10) to head (377eb99).
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files

@@ Coverage Diff @@
## master #6661 +/- ##
==========================================
+ Coverage 45.93% 45.97% +0.04%
==========================================
Files 414 414
Lines 50006 50035 +29
Branches 7147 7147
==========================================
+ Hits 22972 23006 +34
+ Misses 25423 25418 -5
Partials 1611 1611
... and 2 files with indirect coverage changes
Continue to review full report in Codecov by Harness.
Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 104ad10...377eb99. Read the comment docs.
🚀 New features to boost your workflow:
- ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
- 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
|