GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — docs: Correct what _validate_token claims to do by larrysingleton007 · Pull Request #6689 · feast-dev/feast

docs: Correct what _validate_token claims to do #6689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ntkathole merged 2 commits into feast-dev:master from larrysingleton007:docs/oidc-validate-token-honesty
Aug 14, 2026

Uh oh!

There was an error while loading. Please reload this page.
Merged

docs: Correct what _validate_token claims to do #6689

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c64bb4a
docs: Correct what _validate_token claims to do
larrysingleton007 Jul 31, 2026
5a80a2b
refactor: Rename _validate_token to _check_discovery_endpoints
larrysingleton007 Aug 5, 2026
File filter
Filter by extension
Clear filters
Conversations
Failed to load comments.
Loading

Uh oh!

There was an error while loading. Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading

Uh oh!

There was an error while loading. Please reload this page.
Diff view
Diff view

There are no files selected for viewing

19 changes: 14 additions & 5 deletions 19 sdk/python/feast/permissions/auth/oidc_token_parser.py
Show comments
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,9 +77,18 @@ def _get_jwks_client(self) -> PyJWKClient:
)
return self._jwks_client

async def _validate_token(self, access_token: str):
"""
Validate the token extracted from the header of the user request against the OAuth2 server.
async def _check_discovery_endpoints(self, access_token: str):
"""Check that the provider's discovery document exposes the OAuth2 endpoints.
Comment thread

@ntkathole ntkathole Aug 5, 2026

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isn't the function name misleading then ?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

This does **not** verify *access_token*, despite taking it: the bearer
scheme below only parses an ``Authorization`` header, and this method
supplies that header itself, so any token value passes. The token is
genuinely verified in ``_decode_token``, which checks the signature
against the provider's JWKS and validates the claims.

What can fail here is constructing the scheme, which reads the token
and authorization endpoints from the discovery document. A document
missing either one raises before any token is inspected.
"""
# FastAPI's OAuth2AuthorizationCodeBearer requires a Request type but actually uses only the headers field
# https://github.com/tiangolo/fastapi/blob/eca465f4c96acc5f6a22e92fd2211675ca8a20c8/fastapi/security/oauth2.py#L380
Expand Down Expand Up @@ -218,8 +227,8 @@ async def user_details_from_access_token(self, access_token: str) -> User:

# Standard OIDC / Keycloak flow
try:
await self._validate_token(access_token)
logger.debug("Token successfully validated.")
await self._check_discovery_endpoints(access_token)
logger.debug("OIDC discovery document exposes the expected endpoints.")
except Exception as e:
if self._is_ssl_error(e):
logger.error(
Expand Down
Loading
Oops, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.