GeezerVisonThe World Wide Web, restored to 800 pixels of glory. |
| Home|About|Gaming cabinet|Archives|How it works|Starter sites |
GeezerVison is showing github.com — feat: Add feature view versioning to Couchbase online store by koleharv · Pull Request #6754 · feast-dev/feast ConversationWhat this doesResolves the Couchbase scope and collection through a single Couchbase already namespaced by Two decisions worth calling outDocument ids are left unversioned. Couchbase is added to the versioned-read allowlist in Drive-by: a stale error message
TestsNew
Verified red-before/green-after: with the three source files reverted, the four Regression check across the 55 unit test files touching online stores or versioning: the 🤖 Written with Claude Code (Claude Opus 5), reviewed by @Arose26.
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactionsResolve the Couchbase scope and collection through a single helper built on
compute_table_id, so that with registry.enable_online_feature_view_versioning
enabled each feature view version gets its own scope and collection
(test_project_driver_stats_v2_scope) instead of all versions sharing one.
Couchbase already namespaced by {project}_{table.name}, so this follows the
same compute_table_id convention as the Milvus and FAISS stores and the name
is unchanged when versioning is disabled.
Document ids are deliberately left unversioned: a Couchbase collection is
already a namespace, so partitioning at the collection level is enough to keep
versions from colliding, and existing ids stay stable.
Couchbase's online_read honours the OnlineStore contract - one entry per
requested entity key, in order, holding ValueProto values, (None, None) on a
miss - so CouchbaseOnlineStore is added to the versioned-read allowlist.
Also adds Milvus to the VersionedOnlineReadNotSupported message, which has
listed it as unsupported since it was allowlisted.
Part of feast-dev#2728. Closes feast-dev#6171
Signed-off-by: arose26 <[email protected]>
koleharv
requested review from
ejscribner,
robhowley and
shuchu
and removed request for
a team
…ioned-collections This branch has not been deployedNo deployments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
ReviewersUh oh!
There was an error while loading. Please reload this page. AssigneesNo one assignedLabels
None yet
ProjectsMilestoneNo milestoneDevelopmentSuccessfully merging this pull request may close these issues. Add feature view versioning support to Couchbase online storeUh oh!
There was an error while loading. Please reload this page. Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later. |
| You are visitor 01402503 — GeezerVison does not store the pages you look up. Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required. |