GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — feat: Add versioning support to Milvus online store by makinzm · Pull Request #6330 · feast-dev/feast

Conversation

@makinzm

@makinzm makinzm commented Apr 25, 2026 •
edited by devin-ai-integration Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

What this PR does / why we need it:

Adds feature view versioning support to the Milvus online store. When enable_online_feature_view_versioning is enabled in the registry config, the Milvus collection name now includes a version suffix (e.g. project_driver_stats_v2), allowing version-qualified feature references (e.g. driver_stats@v2:trips_today) to resolve to the correct versioned data.

Changes:

  • Updated _table_id() in milvus.py to accept enable_versioning and delegate to the shared compute_table_id() helper (same pattern as SQLite, Redis, PostgreSQL, etc.)
  • Updated all 5 call sites of _table_id to pass config.registry.enable_online_feature_view_versioning
  • Added MilvusOnlineStore to the supported types list in _check_versioned_read_support() so versioned reads no longer raise VersionedOnlineReadNotSupported
  • Added unit tests covering versioned/non-versioned table name generation and versioned read support

Which issue(s) this PR fixes:

Fixes #6177

Checks

  • I've made sure the tests are passing.
  • My commits are signed off (git commit -s)
  • My PR title follows conventional commits format

Testing Strategy

  • Unit tests

Misc

Implementation follows the existing pattern from sqlite.py and dynamodb.py. The compute_table_id() helper in helpers.py handles the version suffix logic, so no additional logic was needed in the Milvus store itself.


Open in Devin Review

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@makinzm
makinzm requested review from a team as code owners April 25, 2026 03:39
@makinzm
makinzm requested review from haoxu0, nquinn408 and redhatHameed and removed request for a team April 25, 2026 03:39
devin-ai-integration[bot]
devin-ai-integration Bot reviewed Apr 25, 2026
View reviewed changes

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 3 additional findings.

Open in Devin Review

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@franciscojavierarceo franciscojavierarceo added the ok-to-test label Apr 25, 2026
@ntkathole ntkathole changed the title feat: add versioning support to Milvus online store feat: Add versioning support to Milvus online store Apr 25, 2026
@ntkathole

ntkathole commented Apr 25, 2026

Copy link
Copy Markdown
Member

@makinzm please fix the linting

makinzm reacted with laugh emoji
All reactions
  • 😄 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

ntkathole
ntkathole reviewed Apr 25, 2026
View reviewed changes
Comment thread sdk/python/feast/infra/online_stores/milvus_online_store/milvus.py Outdated
self.client = self._connect(config)
for table in tables:
collection_name = _table_id(config.project, table)
collection_name = _table_id(

@ntkathole ntkathole Apr 25, 2026

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No cleanup of old versioned collections, it needs to list all collections matching the base name pattern and drop them.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

makinzm reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

@makinzm makinzm Apr 25, 2026

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ntkathole

Thank you for reviewing. I fixed it 161aab7

Summary of the change:

  • Added a _drop_all_version_collections helper that drops the base collection plus every _v{N} sibling, mirroring the _drop_all_version_tables helpers used by the MySQL and PostgreSQL online stores.
  • update and teardown now call this helper unconditionally (i.e. regardless of the current enable_online_feature_view_versioning flag), so repos that toggle versioning on and off across applies don't leave orphan collections behind in Milvus.
  • Added unit tests covering both teardown and update, including an unrelated collection that must not be dropped.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

@makinzm makinzm Apr 28, 2026

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I forgot to check mypy so I will fix 🙇

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

@makinzm makinzm Apr 28, 2026

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've fixed 5fad6e8

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
makinzm added 4 commits April 28, 2026 16:56
@makinzm @ntkathole
feat: add versioning support to Milvus online store
f937c5d
Signed-off-by: makinzm <[email protected]>
@makinzm @ntkathole
lint: uv run ruff format sdk/python/feast/infra/online_stores/milvus_…
b9f1873
…online_store/milvus.py

Signed-off-by: makinzm <[email protected]>
@makinzm @ntkathole
feat: drop all versioned Milvus collections on teardown/update and lint
a957183
Signed-off-by: makinzm <[email protected]>
@makinzm @ntkathole
chore: fix type to check whether it is None
3f2989a
Signed-off-by: makinzm <[email protected]>
@ntkathole
ntkathole force-pushed the feast/milvus-online-store-versioning branch from 5fad6e8 to 3f2989a Compare April 28, 2026 11:26
ntkathole
ntkathole approved these changes Apr 28, 2026
View reviewed changes
@franciscojavierarceo
franciscojavierarceo merged commit 3268ced into feast-dev:master Apr 28, 2026
33 of 35 checks passed

Uh oh!

There was an error while loading. Please reload this page.

@makinzm
makinzm deleted the feast/milvus-online-store-versioning branch April 29, 2026 10:34
franciscojavierarceo pushed a commit that referenced this pull request May 4, 2026
@feast-ci-bot
chore(release): release 0.63.0
50ad181
# [0.63.0](v0.62.0...v0.63.0) (2026-05-04)

### Bug Fixes

* Add project filter to apply_data_source and delete_data_source (closes [#6206](#6206)) ([#6322](#6322)) ([96562c4](96562c4))
* Add project_id filter to SnowflakeRegistry UPDATE path ([#6243](#6243)) ([6658b71](6658b71)), closes [#6208](#6208) [#6208](#6208)
* Add subprocess timeouts to prevent test_e2e_local hanging on Dask atexit handler ([3de6556](3de6556))
* Ambiguous truth value of array during materialization ([#6259](#6259)) ([d0c8984](d0c8984))
* Auto-detect GCS/S3 registry store when registry is passed as string ([#6260](#6260)) ([7ebcf03](7ebcf03))
* **bigquery:** Prefer query over table in get_table_query_string ([#6360](#6360)) ([77ed779](77ed779)), closes [#6200](#6200)
* correct project_id scoping in get_user_metadata and delete_project ([0c469a7](0c469a7))
* disable Redis RDB persistence in test deployments ([44cd682](44cd682))
* Disable snowflake tests temporarily in CI ([#6356](#6356)) ([31d5a98](31d5a98))
* Filter empty SQL commands at execute_snowflake_statement call sites ([#6249](#6249)) ([92ffbb9](92ffbb9))
* Fix five bugs in milvus online store ([#6275](#6275)) ([212504b](212504b))
* Fix issue with apply feature view ([835cda8](835cda8))
* Fix streaming materialization for exotic sources with lazy UDF pipelines ([c07972d](c07972d))
* Handle missing features gracefully instead of panicking ([7d00b3a](7d00b3a))
* Harden informer cache with label selectors and memory optimizations ([#6242](#6242)) ([3f11356](3f11356))
* **helm:** Avoid nil pointer for metrics.enabled inside podAnnotations ([#6251](#6251)) ([c833f1a](c833f1a))
* Include git in feast server image ([fb03c46](fb03c46))
* Include StreamFeatureView in freshness metric ([#6269](#6269)) ([463f16c](463f16c))
* Pre-create S3A event log dir before SparkContext init ([#6317](#6317)) ([9feca77](9feca77))
* Remote Online Store Type Inference Error with All-NULL Columns ([#6063](#6063)) ([de67bdd](de67bdd))
* Remove selector with kustomize overlay using a JSON 6902 patch ([9107a43](9107a43))
* Resolve multiple bugs in SnowflakeRegistry and Snowflake connection handling ([#6315](#6315)) ([7e66a2e](7e66a2e))
* **spark:** BatchFeatureView with TransformationMode.PYTHON now reads all source columns ([a310eaf](a310eaf))
* **spark:** Use SELECT * when feature_name_columns is empty in pull_all_from_table_or_query ([e1b1d2d](e1b1d2d))
* Support pandas mode in feature builder and fix dask column extraction ([863315e](863315e))
* support SQL string as entity_df in RemoteOfflineStore.get_historical_features ([c559889](c559889))
* Wrap LocalOutputNode return value in ArrowTableValue for consist… ([#6286](#6286)) ([a16cd55](a16cd55))

### Features

* Add agent skills and Cursor/Claude rules for Feast development ([312eea3](312eea3))
* Add feature view versioning support to FAISS online store ([b36acb7](b36acb7))
* Add feature view versioning support to Redis and DynamoDB online stores ([#6257](#6257)) ([edf25af](edf25af)), closes [#6164](#6164) [#6163](#6163)
* Add optional 'org' in feature view ([#6288](#6288)) ([#6301](#6301)) ([608b105](608b105))
* Add RaySource, to_ray_dataset first-class method, docs, and tests ([1c98157](1c98157))
* Add TLS support for Go Feature Server ([#6229](#6229)) ([28a58d0](28a58d0))
* Add Vector Search support to MongoDBOnlineStore ([#6344](#6344)) ([c102738](c102738))
* Add versioning support to Milvus online store ([#6330](#6330)) ([3268ced](3268ced))
* Addresses performance issues in the Redis online store ([2e50da0](2e50da0))
* Allow to set gpu for ray ([5580ab4](5580ab4))
* Bump redis-py version cap from <5 to <8 ([#6339](#6339)) ([9538180](9538180))
* Expose feature_server, materialization, and openlineage configuration via FeatureStore CRD ([ec6ecfd](ec6ecfd))
* Make online_write_batch_size configurable in MaterializationConfig ([#6268](#6268)) ([d41becf](d41becf))
* Make udf optional if agg defined ([#5689](#5689)) ([#6328](#6328)) ([f630056](f630056))
* MongoDB offline store ([#6138](#6138)) ([8eebad7](8eebad7))
* Optional input_schema for ODFV ([#6308](#6308)) ([#6312](#6312)) ([f08b4e8](f08b4e8))
* Provision minimal TokenReview RBAC for OIDC auth and add SSL error logging in token parser ([#6240](#6240)) ([dca57e8](dca57e8))
* **spark:** Add compute-on-read support for BatchFeatureView in get_… ([#6357](#6357)) ([630d9f8](630d9f8))
This was referenced Aug 18, 2026
feat: Add feature view versioning to Couchbase online store #6754
Open
feat: Add feature view versioning to HBase online store #6755
Open
feat: Add feature view versioning to Hazelcast online store #6757
Open
@alekseevpavel04 alekseevpavel04 mentioned this pull request Aug 20, 2026
feat: Support feature view versioning in the Cassandra online store #6766
Open
4 of 7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@devin-ai-integration devin-ai-integration[bot] devin-ai-integration[bot] left review comments
@ntkathole ntkathole ntkathole approved these changes
@haoxu0 haoxu0 Awaiting requested review from haoxu0 haoxu0 is a code owner automatically assigned from feast-dev/maintainers
@redhatHameed redhatHameed Awaiting requested review from redhatHameed redhatHameed is a code owner automatically assigned from feast-dev/maintainers
@nquinn408 nquinn408 Awaiting requested review from nquinn408 nquinn408 is a code owner automatically assigned from feast-dev/maintainers

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

ok-to-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add feature view versioning support to Milvus online store

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@makinzm @ntkathole @franciscojavierarceo
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.