GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | ||||||||||||||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | ||||||||||||||||||||||
GeezerVison is showing github.com — feat: Add feature view versioning to Hazelcast online store by koleharv · Pull Request #6757 · feast-dev/feast ConversationWhat this doesThreads Hazelcast already namespaced as One small refactor, and why it is necessary
client.sql.execute(f"DELETE FROM {_map_name(config.project, table)}").result() With the extra argument that call no longer fits on one line, and line breaks inside an Versioned-read allowlist: added, after checking
Write and read also both serialize entity keys at version 3, so they agree on keys and the Drive-by: a stale error message
TestsNew
Verified red-before/green-after: with the three source files reverted, seven of these fail, Regression check across the 55 unit test files touching online stores or versioning: the set of 🤖 Written with Claude Code (Claude Opus 5), reviewed by @Arose26.
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactionsThread registry.enable_online_feature_view_versioning through _map_name, which
now delegates to compute_table_id, so that with versioning enabled each feature
view version gets its own Hazelcast map (test_project_driver_stats_v2) instead
of all versions sharing one.
Hazelcast already namespaced as {project}_{table.name}, so this is the same
compute_table_id convention the Milvus and FAISS stores use and the map name is
unchanged when versioning is disabled.
The update() and teardown() SQL statements bind the resolved name to a local
first rather than calling _map_name inside the f-string: line breaks inside an
f-string replacement field are a Python 3.12 feature and this package supports
3.10.
HazelcastOnlineStore is added to the versioned-read allowlist. Its online_read
iterates the requested entity keys and appends (None, None) for a miss, so it
returns one aligned entry per key as the OnlineStore contract requires; a test
pins that property directly.
Also adds Milvus to the VersionedOnlineReadNotSupported message, which has
listed it as unsupported since it was allowlisted.
Part of feast-dev#2728. Closes feast-dev#6174
Signed-off-by: arose26 <[email protected]>
koleharv
requested review from
nquinn408,
shuchu and
tokoko
and removed request for
a team
haoxu0
approved these changes
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. LGTM. thanks for the contribution
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
|
There was an error while loading. Please reload this page.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@ ## master #6757 +/- ## ========================================== + Coverage 47.09% 47.28% +0.19% ========================================== Files 419 419 Lines 51878 51882 +4 Branches 7525 7525 ========================================== + Hits 24430 24531 +101 + Misses 25700 25595 -105 - Partials 1748 1756 +8
Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
Add feature view versioning support to Hazelcast online store
There was an error while loading. Please reload this page.