GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — fix: Feature freshness logic updated by jyejare · Pull Request #6765 · feast-dev/feast

fix: Feature freshness logic updated #6765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

ntkathole merged 2 commits into feast-dev:master from jyejare:fix_freshness

Aug 21, 2026

Uh oh!

There was an error while loading. Please reload this page.

Merged

fix: Feature freshness logic updated #6765

Show file tree

Hide file tree

Changes from all commits

Commits

Show all changes

2 commits

Select commit Hold shift + click to select a range

af365b1

fix: feature freshness logic updated

jyejare Aug 20, 2026

68afd8e

fix: Avoid redundant _get_max_timestamp query in _compute_for_feature…

jyejare Aug 21, 2026

File filter

Filter by extension .md (1) .py (12) .ts (1) .tsx (1) All 4 file types selected

Viewed files

Clear filters

Conversations

Failed to load comments.

Uh oh!

There was an error while loading. Please reload this page.

Jump to

Jump to file

Failed to load files.

Uh oh!

There was an error while loading. Please reload this page.

Diff view

Unified

Split

Hide whitespace

Diff view

Unified

Split

Hide whitespace

There are no files selected for viewing

3 changes: 3 additions & 0 deletions 3 docs/how-to-guides/feature-monitoring.md

Show comments

View file

Open in desktop

Original file line number	Diff line number	Diff line change
Expand Up		@@ -219,6 +219,7 @@ GET /monitoring/metrics/features?project=my_project&feature_view_name=driver_sta
		"feature_name": "conv_rate",
		"feature_type": "numeric",
		"metric_date": "2025-03-26",
		"max_event_timestamp": "2025-03-27T14:30:00+00:00",
		"granularity": "daily",
		"data_source_type": "batch",
		"row_count": 15000,
Expand All		@@ -242,6 +243,8 @@ GET /monitoring/metrics/features?project=my_project&feature_view_name=driver_sta
		]
		```

		The UI Freshness column uses `max_event_timestamp` — `MAX(event_timestamp)` from the source — not `metric_date` (the DQM window start). Age is `now − max_event_timestamp`.

		### Per-feature-view aggregates

		```
Expand Down

10 changes: 9 additions & 1 deletion 10 sdk/python/feast/infra/offline_stores/bigquery.py

Show comments

View file

Open in desktop

Original file line number	Diff line number	Diff line change
Expand Up		@@ -693,7 +693,7 @@ def _bq_scalar_param_type(column: str) -> str:
		return "BOOL"
		if column == "metric_date":
		return "DATE"
		if column == "computed_at":
		if column in ("computed_at", "max_event_timestamp"):
		return "TIMESTAMP"
		if column in {
		"row_count",
Expand Down Expand Up		@@ -889,6 +889,7 @@ def _bq_ensure_monitoring_tables(config: RepoConfig) -> None:
		granularity STRING NOT NULL,
		data_source_type STRING NOT NULL,
		computed_at TIMESTAMP NOT NULL,
		max_event_timestamp TIMESTAMP,
		is_baseline BOOL NOT NULL,
		feature_type STRING NOT NULL,
		row_count INT64,
Expand All		@@ -915,6 +916,7 @@ def _bq_ensure_monitoring_tables(config: RepoConfig) -> None:
		granularity STRING NOT NULL,
		data_source_type STRING NOT NULL,
		computed_at TIMESTAMP NOT NULL,
		max_event_timestamp TIMESTAMP,
		is_baseline BOOL NOT NULL,
		total_row_count INT64,
		total_features INT64,
Expand All		@@ -932,6 +934,7 @@ def _bq_ensure_monitoring_tables(config: RepoConfig) -> None:
		granularity STRING NOT NULL,
		data_source_type STRING NOT NULL,
		computed_at TIMESTAMP NOT NULL,
		max_event_timestamp TIMESTAMP,
		is_baseline BOOL NOT NULL,
		total_feature_views INT64,
		total_features INT64,
Expand All		@@ -958,6 +961,11 @@ def _bq_ensure_monitoring_tables(config: RepoConfig) -> None:
		"""
		for ddl in (feature_ddl, view_ddl, service_ddl, job_ddl):
		client.query(ddl).result()
		for tbl in (MON_TABLE_FEATURE, MON_TABLE_FEATURE_VIEW, MON_TABLE_FEATURE_SERVICE):
		client.query(
		f"ALTER TABLE `{proj}.{ds}.{tbl}` "
		"ADD COLUMN IF NOT EXISTS max_event_timestamp TIMESTAMP"
		).result()


		def _bq_get_monitoring_max_timestamp(
Expand Down

16 changes: 16 additions & 0 deletions 16 sdk/python/feast/infra/offline_stores/contrib/oracle_offline_store/oracle.py

Show comments

View file

Open in desktop

Original file line number	Diff line number	Diff line change
Expand Up		@@ -715,6 +715,7 @@ def ensure_monitoring_tables(config: RepoConfig) -> None:
		granularity VARCHAR2(20) DEFAULT 'daily' NOT NULL,
		data_source_type VARCHAR2(50) DEFAULT 'batch' NOT NULL,
		computed_at TIMESTAMP WITH TIME ZONE DEFAULT SYSTIMESTAMP NOT NULL,
		max_event_timestamp TIMESTAMP WITH TIME ZONE,
		is_baseline NUMBER(1) DEFAULT 0 NOT NULL,
		feature_type VARCHAR2(50) NOT NULL,
		row_count NUMBER,
Expand Down Expand Up		@@ -746,6 +747,7 @@ def ensure_monitoring_tables(config: RepoConfig) -> None:
		granularity VARCHAR2(20) DEFAULT 'daily' NOT NULL,
		data_source_type VARCHAR2(50) DEFAULT 'batch' NOT NULL,
		computed_at TIMESTAMP WITH TIME ZONE DEFAULT SYSTIMESTAMP NOT NULL,
		max_event_timestamp TIMESTAMP WITH TIME ZONE,
		is_baseline NUMBER(1) DEFAULT 0 NOT NULL,
		total_row_count NUMBER,
		total_features NUMBER,
Expand All		@@ -768,6 +770,7 @@ def ensure_monitoring_tables(config: RepoConfig) -> None:
		granularity VARCHAR2(20) DEFAULT 'daily' NOT NULL,
		data_source_type VARCHAR2(50) DEFAULT 'batch' NOT NULL,
		computed_at TIMESTAMP WITH TIME ZONE DEFAULT SYSTIMESTAMP NOT NULL,
		max_event_timestamp TIMESTAMP WITH TIME ZONE,
		is_baseline NUMBER(1) DEFAULT 0 NOT NULL,
		total_feature_views NUMBER,
		total_features NUMBER,
Expand All		@@ -779,6 +782,19 @@ def ensure_monitoring_tables(config: RepoConfig) -> None:
		""",
		)

		_oracle_try_execute_ddl(
		con,
		f"ALTER TABLE {MON_TABLE_FEATURE} ADD (max_event_timestamp TIMESTAMP WITH TIME ZONE)",
		)
		_oracle_try_execute_ddl(
		con,
		f"ALTER TABLE {MON_TABLE_FEATURE_VIEW} ADD (max_event_timestamp TIMESTAMP WITH TIME ZONE)",
		)
		_oracle_try_execute_ddl(
		con,
		f"ALTER TABLE {MON_TABLE_FEATURE_SERVICE} ADD (max_event_timestamp TIMESTAMP WITH TIME ZONE)",
		)

		_oracle_try_execute_ddl(
		con,
		f"""
Expand Down

12 changes: 12 additions & 0 deletions 12 sdk/python/feast/infra/offline_stores/contrib/postgres_offline_store/postgres.py

Show comments

View file

Open in desktop

Original file line number	Diff line number	Diff line change
Expand Up		@@ -429,6 +429,7 @@ def ensure_monitoring_tables(config: RepoConfig) -> None:
		granularity VARCHAR(20) NOT NULL DEFAULT 'daily',
		data_source_type VARCHAR(50) NOT NULL DEFAULT 'batch',
		computed_at TIMESTAMPTZ NOT NULL DEFAULT NOW(),
		max_event_timestamp TIMESTAMPTZ,
		is_baseline BOOLEAN NOT NULL DEFAULT FALSE,
		feature_type VARCHAR(50) NOT NULL,
		row_count BIGINT,
Expand Down Expand Up		@@ -468,6 +469,7 @@ def ensure_monitoring_tables(config: RepoConfig) -> None:
		granularity VARCHAR(20) NOT NULL DEFAULT 'daily',
		data_source_type VARCHAR(50) NOT NULL DEFAULT 'batch',
		computed_at TIMESTAMPTZ NOT NULL DEFAULT NOW(),
		max_event_timestamp TIMESTAMPTZ,
		is_baseline BOOLEAN NOT NULL DEFAULT FALSE,
		total_row_count BIGINT,
		total_features INTEGER,
Expand All		@@ -487,6 +489,7 @@ def ensure_monitoring_tables(config: RepoConfig) -> None:
		granularity VARCHAR(20) NOT NULL DEFAULT 'daily',
		data_source_type VARCHAR(50) NOT NULL DEFAULT 'batch',
		computed_at TIMESTAMPTZ NOT NULL DEFAULT NOW(),
		max_event_timestamp TIMESTAMPTZ,
		is_baseline BOOLEAN NOT NULL DEFAULT FALSE,
		total_feature_views INTEGER,
		total_features INTEGER,
Expand All		@@ -497,6 +500,15 @@ def ensure_monitoring_tables(config: RepoConfig) -> None:
		);
		""")

		cur.execute(f"""
		ALTER TABLE {MON_TABLE_FEATURE}
		ADD COLUMN IF NOT EXISTS max_event_timestamp TIMESTAMPTZ;
		ALTER TABLE {MON_TABLE_FEATURE_VIEW}
		ADD COLUMN IF NOT EXISTS max_event_timestamp TIMESTAMPTZ;
		ALTER TABLE {MON_TABLE_FEATURE_SERVICE}
		ADD COLUMN IF NOT EXISTS max_event_timestamp TIMESTAMPTZ;
		""")

		cur.execute(f"""
		CREATE TABLE IF NOT EXISTS {MON_TABLE_JOB} (
		job_id VARCHAR(36) PRIMARY KEY,
Expand Down

15 changes: 15 additions & 0 deletions 15 sdk/python/feast/infra/offline_stores/contrib/spark_offline_store/spark.py

Show comments

View file

Open in desktop

Original file line number	Diff line number	Diff line change
Expand Up		@@ -574,6 +574,18 @@ def ensure_monitoring_tables(config: RepoConfig) -> None:
		)
		for stmt in _SPARK_MONITORING_DDL_STATEMENTS:
		spark_session.sql(stmt)
		from pyspark.sql.utils import AnalysisException

		for stmt in (
		f"ALTER TABLE {MON_TABLE_FEATURE} ADD COLUMNS (max_event_timestamp TIMESTAMP)",
		f"ALTER TABLE {MON_TABLE_FEATURE_VIEW} ADD COLUMNS (max_event_timestamp TIMESTAMP)",
		f"ALTER TABLE {MON_TABLE_FEATURE_SERVICE} ADD COLUMNS (max_event_timestamp TIMESTAMP)",
		):
		try:
		spark_session.sql(stmt)
		except AnalysisException:
		# Column already exists on newly created tables.
		pass

		@staticmethod
		def save_monitoring_metrics(
Expand Down Expand Up		@@ -678,6 +690,7 @@ def clear_monitoring_baseline(
		granularity STRING NOT NULL,
		data_source_type STRING NOT NULL,
		computed_at TIMESTAMP NOT NULL,
		max_event_timestamp TIMESTAMP,
		is_baseline BOOLEAN NOT NULL,
		feature_type STRING NOT NULL,
		row_count BIGINT,
Expand All		@@ -703,6 +716,7 @@ def clear_monitoring_baseline(
		granularity STRING NOT NULL,
		data_source_type STRING NOT NULL,
		computed_at TIMESTAMP NOT NULL,
		max_event_timestamp TIMESTAMP,
		is_baseline BOOLEAN NOT NULL,
		total_row_count BIGINT,
		total_features INT,
Expand All		@@ -719,6 +733,7 @@ def clear_monitoring_baseline(
		granularity STRING NOT NULL,
		data_source_type STRING NOT NULL,
		computed_at TIMESTAMP NOT NULL,
		max_event_timestamp TIMESTAMP,
		is_baseline BOOLEAN NOT NULL,
		total_feature_views INT,
		total_features INT,
Expand Down

3 changes: 2 additions & 1 deletion 3 sdk/python/feast/infra/offline_stores/dask.py

Show comments

View file

Open in desktop

Original file line number	Diff line number	Diff line change
Expand Up		@@ -40,6 +40,7 @@
		from feast.monitoring.monitoring_utils import (
		MONITORING_DIR,
		MONITORING_PARQUET_FILES,
		MONITORING_TIMESTAMP_FIELDS,
		monitoring_parquet_meta,
		normalize_monitoring_row,
		opt_float,
Expand Down Expand Up		@@ -968,7 +969,7 @@ def _dask_parquet_query(
		for _, row in df.iterrows():
		record = {c: row.get(c) for c in columns}
		normalize_monitoring_row(record)
		for key in ("metric_date", "computed_at"):
		for key in MONITORING_TIMESTAMP_FIELDS:
		val = record.get(key)
		if (
		val is not None
Expand Down

3 changes: 2 additions & 1 deletion 3 sdk/python/feast/infra/offline_stores/duckdb.py

Show comments

View file

Open in desktop

Original file line number	Diff line number	Diff line change
Expand Up		@@ -39,6 +39,7 @@
		from feast.monitoring.monitoring_utils import (
		MONITORING_DIR,
		MONITORING_PARQUET_FILES,
		MONITORING_TIMESTAMP_FIELDS,
		empty_categorical_metric,
		empty_numeric_metric,
		monitoring_parquet_meta,
Expand Down Expand Up		@@ -487,7 +488,7 @@ def _duckdb_parquet_query(
		for _, row in df.iterrows():
		record = {c: row.get(c) for c in columns}
		normalize_monitoring_row(record)
		for key in ("metric_date", "computed_at"):
		for key in MONITORING_TIMESTAMP_FIELDS:
		val = record.get(key)
		if (
		val is not None
Expand Down

6 changes: 6 additions & 0 deletions 6 sdk/python/feast/infra/offline_stores/redshift.py

Show comments

View file

Open in desktop

Original file line number	Diff line number	Diff line change
Expand Up		@@ -555,6 +555,7 @@ def clear_monitoring_baseline(
		granularity VARCHAR(20) NOT NULL DEFAULT 'daily',
		data_source_type VARCHAR(50) NOT NULL DEFAULT 'batch',
		computed_at TIMESTAMPTZ NOT NULL DEFAULT CURRENT_TIMESTAMP,
		max_event_timestamp TIMESTAMPTZ,
		is_baseline BOOLEAN NOT NULL DEFAULT FALSE,
		feature_type VARCHAR(50) NOT NULL,
		row_count BIGINT,
Expand Down Expand Up		@@ -582,6 +583,7 @@ def clear_monitoring_baseline(
		granularity VARCHAR(20) NOT NULL DEFAULT 'daily',
		data_source_type VARCHAR(50) NOT NULL DEFAULT 'batch',
		computed_at TIMESTAMPTZ NOT NULL DEFAULT CURRENT_TIMESTAMP,
		max_event_timestamp TIMESTAMPTZ,
		is_baseline BOOLEAN NOT NULL DEFAULT FALSE,
		total_row_count BIGINT,
		total_features INTEGER,
Expand All		@@ -600,6 +602,7 @@ def clear_monitoring_baseline(
		granularity VARCHAR(20) NOT NULL DEFAULT 'daily',
		data_source_type VARCHAR(50) NOT NULL DEFAULT 'batch',
		computed_at TIMESTAMPTZ NOT NULL DEFAULT CURRENT_TIMESTAMP,
		max_event_timestamp TIMESTAMPTZ,
		is_baseline BOOLEAN NOT NULL DEFAULT FALSE,
		total_feature_views INTEGER,
		total_features INTEGER,
Expand All		@@ -625,6 +628,9 @@ def clear_monitoring_baseline(
		PRIMARY KEY (job_id)
		);
		""",
		f"ALTER TABLE {MON_TABLE_FEATURE} ADD COLUMN IF NOT EXISTS max_event_timestamp TIMESTAMPTZ",
		f"ALTER TABLE {MON_TABLE_FEATURE_VIEW} ADD COLUMN IF NOT EXISTS max_event_timestamp TIMESTAMPTZ",
		f"ALTER TABLE {MON_TABLE_FEATURE_SERVICE} ADD COLUMN IF NOT EXISTS max_event_timestamp TIMESTAMPTZ",
		]


Expand Down

8 changes: 8 additions & 0 deletions 8 sdk/python/feast/infra/offline_stores/snowflake.py

Show comments

View file

Open in desktop

Original file line number	Diff line number	Diff line change
Expand Up		@@ -564,6 +564,7 @@ def ensure_monitoring_tables(config: RepoConfig) -> None:
		"granularity" VARCHAR(20) NOT NULL DEFAULT 'daily',
		"data_source_type" VARCHAR(50) NOT NULL DEFAULT 'batch',
		"computed_at" TIMESTAMP_TZ NOT NULL DEFAULT CURRENT_TIMESTAMP(),
		"max_event_timestamp" TIMESTAMP_TZ,
		"is_baseline" BOOLEAN NOT NULL DEFAULT FALSE,
		"feature_type" VARCHAR(50) NOT NULL,
		"row_count" BIGINT,
Expand Down Expand Up		@@ -591,6 +592,7 @@ def ensure_monitoring_tables(config: RepoConfig) -> None:
		"granularity" VARCHAR(20) NOT NULL DEFAULT 'daily',
		"data_source_type" VARCHAR(50) NOT NULL DEFAULT 'batch',
		"computed_at" TIMESTAMP_TZ NOT NULL DEFAULT CURRENT_TIMESTAMP(),
		"max_event_timestamp" TIMESTAMP_TZ,
		"is_baseline" BOOLEAN NOT NULL DEFAULT FALSE,
		"total_row_count" BIGINT,
		"total_features" INTEGER,
Expand All		@@ -609,6 +611,7 @@ def ensure_monitoring_tables(config: RepoConfig) -> None:
		"granularity" VARCHAR(20) NOT NULL DEFAULT 'daily',
		"data_source_type" VARCHAR(50) NOT NULL DEFAULT 'batch',
		"computed_at" TIMESTAMP_TZ NOT NULL DEFAULT CURRENT_TIMESTAMP(),
		"max_event_timestamp" TIMESTAMP_TZ,
		"is_baseline" BOOLEAN NOT NULL DEFAULT FALSE,
		"total_feature_views" INTEGER,
		"total_features" INTEGER,
Expand Down Expand Up		@@ -642,6 +645,11 @@ def ensure_monitoring_tables(config: RepoConfig) -> None:
		execute_snowflake_statement(conn, ddl_view)
		execute_snowflake_statement(conn, ddl_service)
		execute_snowflake_statement(conn, ddl_job)
		for fq in (fq_feature, fq_view, fq_service):
		execute_snowflake_statement(
		conn,
		f'ALTER TABLE {fq} ADD COLUMN IF NOT EXISTS "max_event_timestamp" TIMESTAMP_TZ',
		)

		@staticmethod
		def save_monitoring_metrics(
Expand Down

Oops, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Oops, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.