GeezerVisonThe World Wide Web, restored to 800 pixels of glory. |
| Home|About|Gaming cabinet|Archives|How it works|Starter sites |
GeezerVison is showing github.com — feat: Support feature view versioning in the Cassandra online store by alekseevpavel04 · Pull Request #6766 · feast-dev/feast ConversationWhat this PR does / why we need it:Feature view versioning landed in #6101, but the online-store half of it was Cassandra builds every table name in one place, Two details worth flagging for review:
Which issue(s) this PR fixes:Fixes #6170 Checks
Testing Strategy
New unit tests in The full unit suite passes locally: 2648 passed, 44 skipped, 0 failed, against MiscI have not exercised this against a live Cassandra cluster; the store's The second commit (
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactionsFeature view versioning was added in feast-dev#6101 and implemented for SQLite only. Every other online store raises VersionedOnlineReadNotSupported as soon as a version-qualified reference reaches it, so a Feast deployment on Cassandra could not use the feature at all. Cassandra builds every table name in one place, _fq_table_name(), which is used by the insert, select, create and drop paths alike. It now takes the versioning flag and defers to compute_versioned_name(), the same helper SQLite, MySQL and PostgreSQL reach through compute_table_id(), so each version of a feature view is stored in a table of its own and an unversioned deployment keeps exactly the names it has today. Deleting a versioned view drops every version of it rather than only the current one, following the MySQL and PostgreSQL implementations: the in-memory feature view carries a single version, so dropping just that one would leave the other tables orphaned in the keyspace. CassandraOnlineStore is added to the list of stores that support versioned reads. Signed-off-by: Pavel Alekseev <[email protected]> The versioning reference still said version-qualified reads were SQLite-only. Seven stores support them now, so the page understated the feature by six stores before this branch and by seven after it. The list is taken from OnlineStore._is_versioned_read_supported, which is what actually decides. Signed-off-by: Pavel Alekseev <[email protected]>
alekseevpavel04
requested review from
ejscribner,
robhowley and
tokoko
and removed request for
a team
This branch has not been deployedNo deployments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
ReviewersUh oh!
There was an error while loading. Please reload this page. AssigneesNo one assignedLabels
None yet
ProjectsMilestoneNo milestoneDevelopmentSuccessfully merging this pull request may close these issues. Add feature view versioning support to Cassandra online storeUh oh!
There was an error while loading. Please reload this page. Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later. |
| You are visitor 01402503 — GeezerVison does not store the pages you look up. Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required. |