GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | |||||||||||||||||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | |||||||||||||||||||||||||
GeezerVison is showing github.com — fix: Raise Trino monitoring query errors other than a missing table by ericdelorefice · Pull Request #6918 · feast-dev/feast Conversation
Contributor
What this PR does / why we need it:Problem
An empty list has real consequences in the callers:
ReproductionA mocked client raising Change
VerificationTwo new tests in Which issue(s) this PR fixes:None filed. The reproduction is above. This follows the Trino monitoring support added in #6779. Checks
Testing Strategy
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
|
There was an error while loading. Please reload this page.
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@ ## master #6918 +/- ## ========================================== - Coverage 48.50% 48.50% -0.01% ========================================== Files 427 427 Lines 53755 53758 +3 Branches 7827 7828 +1 ========================================== Hits 26076 26076 - Misses 25813 25816 +3 Partials 1866 1866
Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
Sorry, something went wrong.
There was an error while loading. Please reload this page.
query_monitoring_metrics returned [] for every TrinoQueryError. A missing table or schema still means no metrics yet; any other query error is now logged and re-raised, as ensure_monitoring_tables already does. An empty result made DQMJobManager.get_job report a job as missing, so update_status dropped status changes without an error. Signed-off-by: Eric Del Orefice <[email protected]>
cd3265e to
cb584b6
Compare
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.