GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | ||||||||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | ||||||||||||||||
GeezerVison is showing github.com — fix: Report Dask monitoring read errors instead of no data by ericdelorefice · Pull Request #6920 · feast-dev/feast Conversation
Contributor
What this PR does / why we need it:Problem
The callers act on that:
ReproductionA real parquet file in a temp repo, on ChangeOnly I checked that a missing local path raises VerificationNew
Which issue(s) this PR fixes:None filed. Same class of fix as #6918, which does this for Trino's Checks
Testing Strategy
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
|
There was an error while loading. Please reload this page.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@ ## master #6920 +/- ## ========================================== + Coverage 48.56% 48.58% +0.02% ========================================== Files 427 427 Lines 53787 53787 Branches 7834 7834 ========================================== + Hits 26119 26132 +13 + Misses 25803 25788 -15 - Partials 1865 1867 +2
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
Sorry, something went wrong.
There was an error while loading. Please reload this page.
get_monitoring_max_timestamp returned None for any exception from pq.read_table, so an unreadable source was reported as having no data and metrics were saved without max_event_timestamp. Only a missing file now means no data; other errors reach the caller. Signed-off-by: Eric Del Orefice <[email protected]>
3979347 to
134f2b5
Compare
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.