GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — feat: Warn when the dbt import timestamp field is not a timestamp type by luc-pimentel · Pull Request #7038 · feast-dev/feast

Conversation

@luc-pimentel

@luc-pimentel luc-pimentel commented Oct 19, 2026

Copy link
Copy Markdown

What this PR does / why we need it:

feast dbt import checked only that the timestamp column exists. A column declared STRING or INT64 imported silently, and the resulting FeatureView fails at the first get_historical_features call with AttributeError: 'str' object has no attribute 'tzinfo'.

The import now checks the column's dbt type through the existing dbt-to-Feast type mapping and prints one warning per model when it does not map to a timestamp type. The model is still imported. Columns with no data_type in schema.yml reach the CLI as STRING and get the same warning. Spellings the mapping does not know yet, such as Postgres timestamp with time zone or DATETIME2, also warn; extending the mapping is a separate change. The troubleshooting section of the dbt how-to documents the new message.

Which issue(s) this PR fixes:

Fixes #5871

Checks

  • I've made sure the tests are passing.
  • My commits are signed off (git commit -s)
  • My PR title follows conventional commits format

Testing Strategy

  • Unit tests
  • Integration tests
  • Manual tests
  • Testing is not required for this change

New CLI tests build a manifest and run feast dbt import --dry-run: the warning appears for STRING, INT64 and an undeclared type, and does not appear for TIMESTAMP or TIMESTAMP_NTZ(9); warned models still produce their DataSource and FeatureView. All 43 dbt unit tests pass. Scoped Ruff, formatting and mypy checks pass. The before/after reproduction on Feast 0.67.0 and master passes its controls.

Misc

AI-assisted implementation and tests.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@luc-pimentel
luc-pimentel requested a review from a team as a code owner October 19, 2026 01:42
@luc-pimentel luc-pimentel mentioned this pull request Oct 19, 2026
dbt integration: Add validation for timestamp field data type #5871
Open
@luc-pimentel

luc-pimentel commented Oct 27, 2026

Copy link
Copy Markdown
Author

Could someone please take a look at this PR when you have a chance? Thanks!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

luc-pimentel added 2 commits November 10, 2026 08:33
@luc-pimentel
test: Cover the dbt import timestamp field type warning
5b9737d
Signed-off-by: luc-pimentel <[email protected]>
@luc-pimentel
feat: Warn when the dbt import timestamp field is not a timestamp type
46b60e0
The import command only checked that the timestamp column exists, so a column declared STRING or INT64 produced a FeatureView whose timestamp_field cannot anchor point-in-time retrieval. Check the column's dbt type with the existing dbt-to-Feast mapping and print a warning when it does not map to a timestamp type. The model is still imported.

Signed-off-by: luc-pimentel <[email protected]>
@luc-pimentel
luc-pimentel force-pushed the fix/5871-dbt-timestamp-type-warning branch from 47b02a4 to 46b60e0 Compare November 10, 2026 13:22
@luc-pimentel

luc-pimentel commented Nov 10, 2026

Copy link
Copy Markdown
Author

Rebased onto master to resolve the conflict with #7067. The conflicts were in the import block and the troubleshooting section; the check itself is unchanged. All 56 dbt unit tests pass.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

dbt integration: Add validation for timestamp field data type

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@luc-pimentel
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.