GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — feat: Warn when the dbt import timestamp field is not a timestamp type by luc-pimentel · Pull Request #7038 · feast-dev/feast

feat: Warn when the dbt import timestamp field is not a timestamp type #7038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open

luc-pimentel wants to merge 2 commits into feast-dev:master

base: master

from luc-pimentel:fix/5871-dbt-timestamp-type-warning

Uh oh!

There was an error while loading. Please reload this page.

Open

feat: Warn when the dbt import timestamp field is not a timestamp type #7038

Show file tree

Hide file tree

Changes from 1 commit

Commits

Show all changes

2 commits

Select commit Hold shift + click to select a range

5b9737d

test: Cover the dbt import timestamp field type warning

luc-pimentel Oct 15, 2026

46b60e0

feat: Warn when the dbt import timestamp field is not a timestamp type

luc-pimentel Oct 15, 2026

File filter

Filter by extension .md (1) .py (1) All 2 file types selected

Viewed files

Clear filters

Conversations

Failed to load comments.

Uh oh!

There was an error while loading. Please reload this page.

Jump to

Jump to file

Failed to load files.

Uh oh!

There was an error while loading. Please reload this page.

Diff view

Unified

Split

Hide whitespace

Diff view

Unified

Split

Hide whitespace

Previous commit

feat: Warn when the dbt import timestamp field is not a timestamp type

The import command only checked that the timestamp column exists, so a column declared STRING or INT64 produced a FeatureView whose timestamp_field cannot anchor point-in-time retrieval. Check the column's dbt type with the existing dbt-to-Feast mapping and print a warning when it does not map to a timestamp type. The model is still imported.

Signed-off-by: luc-pimentel <[email protected]>

Loading branch information

Uh oh!

There was an error while loading. Please reload this page.

luc-pimentel committed Nov 10, 2026

commit 46b60e0dad31856ba821742aa491cc54663fd81e

There are no files selected for viewing

4 changes: 4 additions & 0 deletions 4 docs/how-to-guides/dbt-integration.md

Show comments

View file

Open in desktop

Original file line number	Diff line number	Diff line change
Expand Up		@@ -434,6 +434,10 @@ Ensure your dbt model includes the entity column specified with `--entity-column

		By default, Feast looks for `event_timestamp`. Use `--timestamp-field` to specify a different column name.

		### "Timestamp field ... does not map to a timestamp type"

		The timestamp column exists but its `data_type` in schema.yml is not a timestamp type (for example `STRING` or `INT64`). The model is still imported, but point-in-time retrieval needs a real timestamp column. Declare the column as `TIMESTAMP`, `DATETIME` or `DATE` in schema.yml. Columns with no `data_type` are treated as `STRING` and also trigger this warning.

		### "Entity column ... may not be suitable as an entity key"

		The entity column's `data_type` in schema.yml maps to a Feast type other than a string or integer type. Floating point values are unreliable join keys, and boolean, binary and timestamp columns rarely identify an entity. The model is still imported. Use a `STRING` or `INT64` column as the entity, or declare the column's type in schema.yml if it is wrong. `NUMBER` types with a precision above 18, such as Snowflake's `NUMBER(38,0)`, map to `Float64`; declare integer IDs as `INTEGER` or `NUMBER(18,0)` instead.
Expand Down

23 changes: 22 additions & 1 deletion 23 sdk/python/feast/cli/dbt_import.py

Show comments

View file

Open in desktop

Original file line number	Diff line number	Diff line change
Expand Up		@@ -123,7 +123,14 @@ def import_command(
		"""
		from feast.dbt.mapper import DbtToFeastMapper, map_dbt_type_to_feast_type
		from feast.dbt.parser import DbtManifestParser, DbtModel
		from feast.types import Array, Int32, Int64, String
		from feast.types import (
		Array,
		Int32,
		Int64,
		String,
		UnixTimestamp,
		ZonedTimestamp,
		)

		# Parse manifest
		click.echo(f"{Fore.CYAN}Parsing dbt manifest: {manifest_path}{Style.RESET_ALL}")
Expand Down Expand Up		@@ -211,6 +218,20 @@ def import_command(
		)
		continue

		# The parser reports STRING for columns with no declared data_type.
		timestamp_column = next(c for c in model.columns if c.name == timestamp_field)
		if map_dbt_type_to_feast_type(timestamp_column.data_type) not in (
		UnixTimestamp,
		ZonedTimestamp,
		):
		click.echo(
		f"{Fore.YELLOW}Warning: Model '{model.name}' timestamp field "
		f"'{timestamp_field}' has type '{timestamp_column.data_type}', "
		f"which does not map to a timestamp type. Importing anyway. "
		f"Declare it as a timestamp type in schema.yml if this is wrong."
		f"{Style.RESET_ALL}"
		)

		# Validate ALL entity columns exist
		missing_entities = [e for e in entity_cols if e not in column_names]
		if missing_entities:
Expand Down

Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.

You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.