GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — docs: Fix docstring argument names that do not match the signature by mmporong · Pull Request #7098 · feast-dev/feast

Conversation

mmporong commented Nov 4, 2026

Copy link

Copy Markdown

Contributor

What this PR does / why we need it:

Fixes docstring Args entries that name a parameter the function does not have. Docstrings only, no code changes.

BaseRegistry.delete_project: project -> name
init_security_manager (feast/permissions/server/utils.py): registry -> fs. The function takes the FeatureStore and reads fs.project and fs.registry.
DecisionEvaluator: removed decision_strategy. The constructor only takes num_of_voters and always uses AFFIRMATIVE, so the summary line now says that instead of "according to the selected strategy". The example in the same docstring called DecisionEvaluator(DecisionStrategy.UNANIMOUS, 3), which raises TypeError: DecisionEvaluator.__init__() takes 2 positional arguments but 3 were given, so it now reads DecisionEvaluator(3). Also fixed in the same file: the "receivem" typo in that example, and in the add_grant docstring vote -> grant and "True is" -> "True if".
Project.from_proto: entity_proto -> project_proto, and the Returns line now says it returns a Project (it said "An Entity object based on the entity protobuf"). "an project" -> "a project" in the same docstring.
Provider.retrieve_online_documents_v2: query -> embedding
configure_ca_trust_store_env_variables: removed :param ca_file_path:. The function takes no arguments and reads FEAST_CA_CERT_FILE_PATH from the environment.
_proto_value_to_value_type (feast/type_map.py): proto_str -> proto_value, and the summary line now says it takes a proto value.

These were found with a script that parses each function with ast and compares the names in its docstring parameter section with the signature. Before this change it reported 12 entries under sdk/python/feast, after it 5, none of which is a wrong name: created_timestamp and last_updated_timestamp in the DataSource class docstring are attributes listed under Args, Versions: in serialize_entity_key is a heading inside an argument description, and start_date / end_date in Provider.get_historical_features go through **kwargs.

Checks run locally (Python 3.12):

ruff check sdk/python/feast/ sdk/python/tests/ and ruff format --check on the changed files, ruff 0.16.10 as pinned in sdk/python/requirements/py3.12-ci-requirements.txt: pass
mypy 1.11.2 on the 7 changed files, run from sdk/python: no issues
pytest tests/unit/permissions tests/unit/test_project.py tests/unit/test_type_map.py -k "not TestSparkNativeTypeValidation": 657 passed, the same as on master. The 24 deselected tests need pyspark, which was not installed.
Ran both versions of the DecisionEvaluator example against feast/permissions/decision.py: the old one raises the TypeError above, the new one runs and returns a decision.

Which issue(s) this PR fixes:

None, there is no issue for this.

Checks

I've made sure the tests are passing.
My commits are signed off (git commit -s)
My PR title follows conventional commits format

Testing Strategy

Unit tests
Integration tests
Manual tests
Testing is not required for this change

Misc

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          docs: Fix docstring argument names that do not match the signature

0d7d551

Several Args entries named a parameter the function does not have.
Rename them to the actual parameter or drop them, and update the
DecisionEvaluator example, which passed a DecisionStrategy that the
constructor does not accept.

Signed-off-by: mmporong <[email protected]>

mmporong requested a review from a team as a code owner

November 4, 2026 03:10

shuchu added the ok-to-test label

Nov 4, 2026

codecov-commenter commented Nov 4, 2026 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

⚠️ Please install the to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 50.99%. Comparing base (72013d3) to head (0d7d551).
⚠️ Report is 3 commits behind head on master.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #7098   +/-   ##
=======================================
  Coverage   50.99%   50.99%           
=======================================
  Files         455      455           
  Lines       56994    56994           
  Branches     8321     8321           
=======================================
  Hits        29063    29063           
  Misses      25946    25946           
  Partials     1985     1985

Flag	Coverage Δ
go-feature-server	`30.58% <ø> (ø)`
python-unit	`52.45% <ø> (ø)`

Files with missing lines	Coverage Δ
sdk/python/feast/infra/provider.py	`92.30% <ø> (ø)`
sdk/python/feast/infra/registry/base_registry.py	`74.07% <ø> (ø)`
sdk/python/feast/permissions/decision.py	`91.89% <ø> (ø)`
sdk/python/feast/permissions/server/utils.py	`62.74% <ø> (ø)`
sdk/python/feast/project.py	`84.48% <ø> (ø)`
sdk/python/feast/ssl_ca_trust_store_setup.py	`55.55% <ø> (ø)`
sdk/python/feast/type_map.py	`64.59% <ø> (ø)`

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 72013d3...0d7d551. Read the comment docs.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

shuchu approved these changes

Nov 4, 2026

View reviewed changes

shuchu left a comment

Copy link

Copy Markdown

Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          Merge branch 'master' into docs-fix-docstring-arg-names

5def032

shuchu merged commit b576c45 into feast-dev:master

Nov 4, 2026

2 checks passed

Uh oh!

There was an error while loading. Please reload this page.

patelchaitany mentioned this pull request

Nov 4, 2026

chore: Sync upstream feast-dev/feast master opendatahub-io/feast#276

Merged

jyejare pushed a commit to opendatahub-io/feast that referenced this pull request

Nov 5, 2026


          chore: Sync upstream feast-dev/feast master (#276)

5dbf8b3

* feat: Add Pinecone online store integration (feast-dev#6585)

* feat: Add Pinecone online store integration
Signed-off-by: Siddhesh Khairnar <[email protected]>

* fix: Align Pinecone store with filters API and operator types

Signed-off-by: Siddhesh Khairnar <[email protected]>

* test: Expand Pinecone online store unit test coverage

Signed-off-by: Siddhesh Khairnar <[email protected]>

* fix: Address Pinecone online store review feedback

Signed-off-by: Siddhesh Khairnar <[email protected]>

* ci: Retrigger CI after flaky macOS dependency download

Signed-off-by: Siddhesh Khairnar <[email protected]>

* fix: Resolve rebase conflicts keeping chronon and pinecone

Signed-off-by: Siddhesh Khairnar <[email protected]>

* fix: Prevent protobuf downgrade breaking grpc health checks

Signed-off-by: Siddhesh Khairnar <[email protected]>

* fix: Revert protobuf pin that broke flink and pixi lock

Keep uv --no-sync for CI so hashed protobuf 7.x is preserved without
conflicting with feast[flink].

Signed-off-by: Siddhesh Khairnar <[email protected]>

---------

Signed-off-by: Siddhesh Khairnar <[email protected]>

* fix: Install patched libbrotli1 to address DSA-6582-1 (feast-dev#7096)

Signed-off-by: Joystyxx <[email protected]>
Co-authored-by: Shuchu Han <[email protected]>

* docs: Fix docstring argument names that do not match the signature (feast-dev#7098)

Several Args entries named a parameter the function does not have.
Rename them to the actual parameter or drop them, and update the
DecisionEvaluator example, which passed a DecisionStrategy that the
constructor does not accept.

Signed-off-by: mmporong <[email protected]>
Co-authored-by: Shuchu Han <[email protected]>

* chore(deps-dev): bump minimatch from 10.2.6 to 11.0.1 in /ui (feast-dev#7102)

Bumps [minimatch](https://github.com/isaacs/minimatch) from 10.2.6 to 11.0.1.
- [Changelog](https://github.com/isaacs/minimatch/blob/main/changelog.md)
- [Commits](isaacs/minimatch@v10.2.6...v11.0.1)

---
updated-dependencies:
- dependency-name: minimatch
  dependency-version: 11.0.1
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

---------

Signed-off-by: Siddhesh Khairnar <[email protected]>
Signed-off-by: Joystyxx <[email protected]>
Signed-off-by: mmporong <[email protected]>
Signed-off-by: dependabot[bot] <[email protected]>
Signed-off-by: Chaitany Patel <[email protected]>
Co-authored-by: Siddhesh Khairnar <[email protected]>
Co-authored-by: JoyStyx <[email protected]>
Co-authored-by: Shuchu Han <[email protected]>
Co-authored-by: Lim Jooyoung <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

jyejare pushed a commit to opendatahub-io/feast that referenced this pull request

Nov 5, 2026


          chore: Record upstream feast-dev/feast master as merged (no file chan…

92bfe58

…ges) (#281)

* feat: Add Pinecone online store integration (feast-dev#6585)

* feat: Add Pinecone online store integration
Signed-off-by: Siddhesh Khairnar <[email protected]>

* fix: Align Pinecone store with filters API and operator types

Signed-off-by: Siddhesh Khairnar <[email protected]>

* test: Expand Pinecone online store unit test coverage

Signed-off-by: Siddhesh Khairnar <[email protected]>

* fix: Address Pinecone online store review feedback

Signed-off-by: Siddhesh Khairnar <[email protected]>

* ci: Retrigger CI after flaky macOS dependency download

Signed-off-by: Siddhesh Khairnar <[email protected]>

* fix: Resolve rebase conflicts keeping chronon and pinecone

Signed-off-by: Siddhesh Khairnar <[email protected]>

* fix: Prevent protobuf downgrade breaking grpc health checks

Signed-off-by: Siddhesh Khairnar <[email protected]>

* fix: Revert protobuf pin that broke flink and pixi lock

Keep uv --no-sync for CI so hashed protobuf 7.x is preserved without
conflicting with feast[flink].

Signed-off-by: Siddhesh Khairnar <[email protected]>

---------

Signed-off-by: Siddhesh Khairnar <[email protected]>

* fix: Install patched libbrotli1 to address DSA-6582-1 (feast-dev#7096)

Signed-off-by: Joystyxx <[email protected]>
Co-authored-by: Shuchu Han <[email protected]>

* docs: Fix docstring argument names that do not match the signature (feast-dev#7098)

Several Args entries named a parameter the function does not have.
Rename them to the actual parameter or drop them, and update the
DecisionEvaluator example, which passed a DecisionStrategy that the
constructor does not accept.

Signed-off-by: mmporong <[email protected]>
Co-authored-by: Shuchu Han <[email protected]>

* chore(deps-dev): bump minimatch from 10.2.6 to 11.0.1 in /ui (feast-dev#7102)

Bumps [minimatch](https://github.com/isaacs/minimatch) from 10.2.6 to 11.0.1.
- [Changelog](https://github.com/isaacs/minimatch/blob/main/changelog.md)
- [Commits](isaacs/minimatch@v10.2.6...v11.0.1)

---
updated-dependencies:
- dependency-name: minimatch
  dependency-version: 11.0.1
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

---------

Signed-off-by: Siddhesh Khairnar <[email protected]>
Signed-off-by: Joystyxx <[email protected]>
Signed-off-by: mmporong <[email protected]>
Signed-off-by: dependabot[bot] <[email protected]>
Signed-off-by: Chaitany Patel <[email protected]>
Co-authored-by: Siddhesh Khairnar <[email protected]>
Co-authored-by: JoyStyx <[email protected]>
Co-authored-by: Shuchu Han <[email protected]>
Co-authored-by: Lim Jooyoung <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

jyejare added a commit to opendatahub-io/feast that referenced this pull request

Nov 5, 2026


          chore: Record upstream feast-dev/feast master as merged (merge commit…

482e60f

… only, do not squash) (#283)

* feat: Add Pinecone online store integration (feast-dev#6585)

* feat: Add Pinecone online store integration
Signed-off-by: Siddhesh Khairnar <[email protected]>

* fix: Align Pinecone store with filters API and operator types

Signed-off-by: Siddhesh Khairnar <[email protected]>

* test: Expand Pinecone online store unit test coverage

Signed-off-by: Siddhesh Khairnar <[email protected]>

* fix: Address Pinecone online store review feedback

Signed-off-by: Siddhesh Khairnar <[email protected]>

* ci: Retrigger CI after flaky macOS dependency download

Signed-off-by: Siddhesh Khairnar <[email protected]>

* fix: Resolve rebase conflicts keeping chronon and pinecone

Signed-off-by: Siddhesh Khairnar <[email protected]>

* fix: Prevent protobuf downgrade breaking grpc health checks

Signed-off-by: Siddhesh Khairnar <[email protected]>

* fix: Revert protobuf pin that broke flink and pixi lock

Keep uv --no-sync for CI so hashed protobuf 7.x is preserved without
conflicting with feast[flink].

Signed-off-by: Siddhesh Khairnar <[email protected]>

---------

Signed-off-by: Siddhesh Khairnar <[email protected]>

* fix: Install patched libbrotli1 to address DSA-6582-1 (feast-dev#7096)

Signed-off-by: Joystyxx <[email protected]>
Co-authored-by: Shuchu Han <[email protected]>

* docs: Fix docstring argument names that do not match the signature (feast-dev#7098)

Several Args entries named a parameter the function does not have.
Rename them to the actual parameter or drop them, and update the
DecisionEvaluator example, which passed a DecisionStrategy that the
constructor does not accept.

Signed-off-by: mmporong <[email protected]>
Co-authored-by: Shuchu Han <[email protected]>

* chore(deps-dev): bump minimatch from 10.2.6 to 11.0.1 in /ui (feast-dev#7102)

Bumps [minimatch](https://github.com/isaacs/minimatch) from 10.2.6 to 11.0.1.
- [Changelog](https://github.com/isaacs/minimatch/blob/main/changelog.md)
- [Commits](isaacs/minimatch@v10.2.6...v11.0.1)

---
updated-dependencies:
- dependency-name: minimatch
  dependency-version: 11.0.1
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

---------

Signed-off-by: Siddhesh Khairnar <[email protected]>
Signed-off-by: Joystyxx <[email protected]>
Signed-off-by: mmporong <[email protected]>
Signed-off-by: dependabot[bot] <[email protected]>
Signed-off-by: Chaitany Patel <[email protected]>
Co-authored-by: Siddhesh Khairnar <[email protected]>
Co-authored-by: JoyStyx <[email protected]>
Co-authored-by: Shuchu Han <[email protected]>
Co-authored-by: Lim Jooyoung <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

patelchaitany mentioned this pull request

Nov 11, 2026

chore: Sync upstream feast-dev/feast stable (0.68.0) opendatahub-io/feast#291

Merged

rhods-devops-app Bot mentioned this pull request

Nov 12, 2026

Automated Sync from main to stable red-hat-data-services/feast#630

Open

Reviewers

shuchu

shuchu approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

ok-to-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

mmporong commented Nov 4, 2026

What this PR does / why we need it:

Which issue(s) this PR fixes:

Checks

Testing Strategy

Misc

Uh oh!

codecov-commenter commented Nov 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

shuchu left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

codecov-commenter commented Nov 4, 2026 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.