GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Legion/Tonks rewrite by caelunshun · Pull Request #170 · feather-rs/feather

Conversation

@caelunshun

@caelunshun caelunshun commented Nov 13, 2019 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

This is a total rewrite of all systems in Feather, as described in #169.

After the three previous major refactors (#62, #19, and #7), I sure hope this is the last one. I feel confident that the new architecture will be able to scale in ways which Specs could not, and any missing parts can be implemented in tonks without significant refactors being required in Feather.

This PR is the culmination of several months' worth of brainstorming how to circumvent the problems with the parallel ECS architecture, and I firmly believe performing this refactor is the right way to go.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
panaman67, NilsIrl, erlend-sh, AhiVT, and mralve reacted with heart emoji panaman67, MarkMcCaskey, aramperes, erlend-sh, and mralve reacted with rocket emoji
All reactions
  • ❤️ 5 reactions
  • 🚀 5 reactions
caelunshun added 2 commits November 12, 2019 18:06
@caelunshun
Use stable Rust: async/await is now stabilized
6814d9d
@caelunshun
Ow.
53b389e
@caelunshun caelunshun added this to the 0.6 milestone Nov 13, 2019
caelunshun added 27 commits November 14, 2019 13:07
@caelunshun
Reimplement most of the network system
c1b9b78
@caelunshun
Add crate-level docs on ECS
9b21375
@caelunshun
New state type for combining lots of resources; use RwLock to store…
106ff04 
… chunks
@caelunshun
Translate entity physics system
9ff1e9e
@caelunshun
Begin translating chunk logic
0e509c4
@caelunshun
Reimplement the rest of chunk logic
ffcb46e
@caelunshun
Rename ChunkHolderComponent -> ChunkHolder
93880f3
@caelunshun
Convert time sending
fec8ea3
@caelunshun
Get feather-core to compile
7ba7f91
@caelunshun
Start work again.
0a3d4f0
@caelunshun
Update already converted systems to new tonks API
fb11d36
@caelunshun
Fix lib.rs
6600a35
@caelunshun
Fix more compile errors; move toward initial compileable program
dcd54e6
@caelunshun
Fix more compile errors; cause 50 more
f7576c3
@caelunshun
Fix 10 more errors; cause 15 more
8d0274d
@caelunshun
Reduce error count from 49 to 12!
f5048d1
@caelunshun
Fix unused imports; fix 6 more errors'
798f09b
@caelunshun
Reimplement player data loading
e3d405f
@caelunshun
Fix ALL errors and warnings. I'm scared to run this...
d751bc4
@caelunshun
Get server to start without panic
de0f3ff
@caelunshun
Work on getting chunk sending + view updates to work
74bb4f0
@caelunshun
Wrestle through a number of Legion bugs to get chunk sending to work …
8ab3ebe 
…properly
@caelunshun
Player can now join and see chunks.
edec45b
@caelunshun
Reimplement movement packets
8cada32
@caelunshun
Fix compilation
4254453
@caelunshun
Fix assorted Clippy errors
de214dd
@caelunshun
Implement ChunkEntities cache
96d6895
caelunshun added 8 commits December 22, 2019 13:48
@caelunshun
Implement State broadcast methods
b51e2d4
@caelunshun
Implement movement broadcaster
9562e4f
@caelunshun
Start on broadcasting entities
195544f
@caelunshun
Implement keepalives; fix movement + entity broadcasting
a78e283
@caelunshun
Broadcast entity deletion; fix a bunch of panics
f90ce55
@caelunshun
Implement player hand animations
ae94e6e
@caelunshun
Fix weird movement behavior by not using parallel iterators in moveme…
f14870e 
…nt broadcaster
@caelunshun
Add opt-level=1 to profile.dev
4d199a4
@caelunshun
caelunshun marked this pull request as ready for review January 11, 2020 19:23
@caelunshun

caelunshun commented Jan 11, 2020

Copy link
Copy Markdown
Member Author

Going to merge this and then reimplement old features on the master branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@caelunshun
caelunshun merged commit 4d199a4 into develop Jan 11, 2020
@NilsIrl

NilsIrl commented Feb 8, 2020

Copy link
Copy Markdown
Contributor

Since this has been merged. Shouldn't the README be updated?
StackDoubleFlow, Redlolz, holly-hacker, WolfDan, printfn, lun-4, dzikoysk, and cowang4 reacted with thumbs up emoji
All reactions
  • 👍 8 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@caelunshun
caelunshun deleted the legion branch March 21, 2020 02:03
@NilsIrl NilsIrl mentioned this pull request Mar 24, 2020
Remove warning as #170 has been merged #189
Merged
caelunshun added a commit that referenced this pull request Mar 24, 2020
@caelunshun
Merge pull request #189 from NilsIrl/patch-1
3a58ab1 
Remove warning as #170 has been merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.6

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@caelunshun @NilsIrl
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.