GeezerVison

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (3c64e93) to head (bbdaf24).
Report is 64 commits behind head on main.

@@            Coverage Diff            @@
##              main      #670   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            5         5           
  Lines           34        34           
  Branches         3         3           
=========================================
  Hits            34        34           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

You shoudl rename your PR to "feat: Add currency and banknote icons"

Banknote

To me, it doesn't really look like a banknote (sorry)

Icon

Bitcoin

In bitcoin logo the second curve should not be far, instead, it should be of the same size and tilted to 10 deg of the angle.

Icon	Original

Swiss Franc

In the first of the F, there is a lot of empty space in between

Icon	Example

Euros

Add the ends of euro looks too close

Icon	Example

GBP

In GBP icon, instead of keeping it flat straight, I think there should be a curve

Icon	Original

Rub

Maybe try decreasing the height of this area

Icon	Original

@locness3 @mittalyashu

Banknote

To me, it doesn't really look like a banknote (sorry)

Icon

I'm open for suggestions!

Bitcoin

In bitcoin logo the second curve should not be far, instead, it should be of the same size and tilted to 10 deg of the angle.

Icon Original

Like this?

Swiss Franc

In the first of the F, there is a lot of empty space in between

Icon Example

Have updated so that the second line of the F is exactly in the middle of the other two lines:

Euros

Add the ends of euro looks too close

Icon Example

Updated:

GBP

In GBP icon, instead of keeping it flat straight, I think there should be a curve

Icon Original

Updated:

Rub

Maybe try decreasing the height of this area

Icon Original

Updated:

Bitcoin

The tile of the bitcoin looks good, can you also try a newer version of bitcoin in which size of both the bumps is same.

GBP

We need to work on that bumpy curve 😅

Swiss Franc, Euros, Rub

Now, it looks good.

Bitcoin

The tile of the bitcoin looks good, can you also try a newer version of bitcoin in which size of both the bumps is same.

@mittalyashu How is this?

GBP

We need to work on that bumpy curve 😅

Maybe give me an example?

Swiss Franc, Euros, Rub

Now, it looks good.

Updated the PR

Bitcoin icon looks good now.

Let me find an example of the GBP icon.

Maybe adding a bitcoin tilted icon too ?

I think the BTC icon should be straight by default - is that possible?

No @MarcelloTheArcane it's not straight, you can check the official bitcoin website.

@locness3 @mittalyashu @MarcelloTheArcane Sorry ... didn't ever update the btc icon

It's now updated ... just need to work on the GBP

Excited about the GBP icon!

@colebemis We're still waiting for you...

This repository badly needs some extra moderators / pr-reviewers.

Could someone reach out to @colebemis on Twitter?