GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — feat: Add 'send-money' and 'receive-money' and 'dashboard' icons by dbedoyat · Pull Request #714 · feathericons/feather

Conversation

@dbedoyat

@dbedoyat dbedoyat commented Aug 8, 2019

Copy link
Copy Markdown

No description provided.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@dbedoyat
feat: Add 'send-money' and 'receive-money' icons
c3e54d9
@codecov

codecov Bot commented Aug 8, 2019 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Codecov Report

Merging #714 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #714   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           5      5           
  Lines          34     34           
  Branches        3      3           
=====================================
  Hits           34     34

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5047ddb...0884d0f. Read the comment docs.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
moeenio
moeenio suggested changes Aug 8, 2019
View reviewed changes

@moeenio moeenio left a comment

Copy link
Copy Markdown

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No fills are allowed.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@dbedoyat
feat: Add 'dashboard' icon
d129c18
@dbedoyat dbedoyat changed the title feat: Add 'send-money' and 'receive-money' icons feat: Add 'send-money' and 'receive-money' and 'dashboard' icons Aug 8, 2019
@moeenio

moeenio commented Aug 8, 2019

Copy link
Copy Markdown

Please read my review
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@dbedoyat
Remove fill from icon 'receive-money' and 'send-money'
0e5f422
@dbedoyat

dbedoyat commented Aug 8, 2019

Copy link
Copy Markdown
Author

Please read my review

Fixed! @locness3
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
moeenio
moeenio previously approved these changes Aug 10, 2019
View reviewed changes

@moeenio moeenio left a comment

Copy link
Copy Markdown

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe conforming with the banknote icon submitted here #670 ? Also you should remove the class names in dashboard ?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@moeenio

moeenio commented Aug 10, 2019

Copy link
Copy Markdown

Didn't want to approve
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@dbedoyat
Remove class from 'Dashboard' icon
0884d0f
@dbedoyat
dbedoyat dismissed moeenio’s stale review via 0884d0f August 10, 2019 23:21
@dbedoyat

dbedoyat commented Aug 10, 2019

Copy link
Copy Markdown
Author

Maybe conforming with the banknote icon submitted here #670 ? Also you should remove the class names in dashboard ?

Yep, i remove the class names in 'dashboard'.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
moeenio
moeenio reviewed Aug 11, 2019
View reviewed changes

@moeenio moeenio left a comment

Copy link
Copy Markdown

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe conforming with the banknote icon in #670 ?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@dbedoyat

dbedoyat commented Aug 11, 2019

Copy link
Copy Markdown
Author

Maybe conforming with the banknote icon in #670 ?

According to your feedback the icon 'Banknote' has a fill in the circles.

Will you need to do similar like #670 ?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@moeenio

moeenio commented Aug 12, 2019

Copy link
Copy Markdown

According to your feedback the icon 'Banknote' has a fill in the circles.

In #670 ? It doesn't
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@dbedoyat dbedoyat closed this Oct 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@moeenio moeenio moeenio left review comments
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@dbedoyat @moeenio
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.