Description

arkenstan

opened on Jun 28, 2020

Issue body actions

Steps to reproduce

On upgrading angular application to Angular 10.0.0 It gives warning for modules and packages that have dependency on commonjs or AMD for optimization bailouts

PSB Log for warnings

WARNING in src/app/core/services/feathers.service.ts depends on @feathersjs/socketio-client. CommonJS or AMD dependencies can cause optimization bailouts.
For more info see: https://angular.io/guide/build#configuring-commonjs-dependencies

WARNING in src/app/core/services/feathers.service.ts depends on @feathersjs/feathers. CommonJS or AMD dependencies can cause optimization bailouts.
For more info see: https://angular.io/guide/build#configuring-commonjs-dependencies

WARNING in src/app/core/services/feathers.service.ts depends on @feathersjs/authentication-client. CommonJS or AMD dependencies can cause optimization bailouts.
For more info see: https://angular.io/guide/build#configuring-commonjs-dependencies

WARNING in src/app/core/services/feathers.service.ts depends on socket.io-client. CommonJS or AMD dependencies can cause optimization bailouts.
For more info see: https://angular.io/guide/build#configuring-commonjs-dependencies

WARNING in src/app/core/services/feathers.service.ts depends on feathers-reactive. CommonJS or AMD dependencies can cause optimization bailouts.
For more info see: https://angular.io/guide/build#configuring-commonjs-dependencies

System configuration

Module versions
@feathersjs/authentication-client: "^4.5.4"
@feathersjs/feathers: "^4.5.3"
@feathersjs/socketio-client: "^4.5.4"
socket.io-client: "^2.3.0"

NodeJS version:
Node 12

Operating System:
Linux mint 19.3

Activity

1. alejandroTapiaQ commented on Aug 7, 2020

   

   alejandroTapiaQ

   on Aug 7, 2020

   More actions

   HI arkenstan well I resolve that warning adding this in angular.json file

   `
   "architect": {
   "build": {
   "builder": "@angular-devkit/build-angular:browser",
   "options": {
   "allowedCommonJsDependencies": [
   "socket.io-client",
   "socket.io-parser",
   "debug"
   ],

   `
   Also you can see #18025

   Reacted by Anshul Wagadre, Vinicius, Carlos Álvarez, Wahib Kerkeni and Andongwisye Mwamengo
2. bertho-zero commented on Aug 8, 2020

   

   bertho-zero

   on Aug 8, 2020

   Contributor

   More actions

   ESM builds should be added to correctly fix these warnings.

   Reacted by Stefan Sechelmann, Anshul Wagadre and Martin Stolz
3. daffl

   added

   Client

   Feature

   on Sep 29, 2020
4. axmad22 commented on Oct 16, 2020

   

   axmad22

   on Oct 16, 2020

   More actions

   Had the same problem Warning: Entry point simplebar-angular contains deep imports
   try adding in the angular.json in the "build"=> "options":

   "allowedCommonJsDependencies": ["core-js"],

   Also I kind of remember adding something in the tsconfig.json
   that helped here is mine case check with default settings

   {
     "compileOnSave": false,
     "compilerOptions": {
       "baseUrl": "./",
       "outDir": "./public/out-tsc",
       "sourceMap": true,
       "declaration": false,
       "downlevelIteration": true,
       "experimentalDecorators": true,
       "module": "esnext",
       "moduleResolution": "node",
       "importHelpers": true,
       "target": "es2015",
       "allowSyntheticDefaultImports": true,
       "typeRoots": [
         "node_modules/@types"
       ],
       "lib": [
         "es2018",
         "dom"
       ]
     }
   }

   Reacted by Anshul Wagadre and Francisco Morello
5. daffl

   added this to the v6 milestone on Aug 19, 2025

Issue actions