GeezerVison is showing github.com — feat: ES module builds (ESM Support) by fratzinger · Pull Request #2665 · feathersjs/feathers
Conversation
fratzinger
commented
Jun 12, 2022
•
edited by daffl
Loading
Uh oh!
There was an error while loading. Please reload this page.
This pull request adds ES module builds to all package distributables. It is backwards compatible by still providing the CommonJS version as well but will use ES modules in applications with "type": "module" (like the generated app) and with client side bundlers so it can use features like tree shaking.
Closes #2748
Closes #2001
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
[pull] dove from feathersjs:dove
- add module.exports for default export
daffl
commented
Jun 13, 2022
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
|
This looks like a good step, thank you. I am seeing the same error locally you can see in CI:
Error [ERR_PACKAGE_PATH_NOT_EXPORTED]: Package subpath './lib' is not defined by "exports" in /home/runner/work/feathers/feathers/packages/transport-commons/node_modules/@feathersjs/errors/package.json
I'm not sure what that means since all those packages have an identical configuration.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
netlify
Bot
commented
Oct 29, 2022
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
✅ Deploy Preview for feathers-dove canceled.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
@daffl, @FossPrime
I don't know what the error in the generator is about:

Builds are passing. I think we could try it out.
I don't know what the best strategy is though. Install from github is not possible because of lerna workspace packages, right? Maybe we need pre-versions.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
Making a note here that the thing that may be missing is that the ESM and CJS folders each need a package.json that declares the module type like
{ "type": "module|commonjs" }
Now that TypeScript seems to support it properly it might also make sense to use full imports with .js extensions.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
This branch has not been deployed
No deployments
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
|