GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — feat: ES module builds (ESM Support) by fratzinger · Pull Request #2665 · feathersjs/feathers

Conversation

@fratzinger

@fratzinger fratzinger commented Jun 12, 2022 •
edited by daffl
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

This pull request adds ES module builds to all package distributables. It is backwards compatible by still providing the CommonJS version as well but will use ES modules in applications with "type": "module" (like the generated app) and with client side bundlers so it can use features like tree shaking.

Closes #2748
Closes #2001

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
fratzinger and others added 21 commits October 15, 2021 22:14
@fratzinger
Merge pull request #19 from feathersjs/dove
8127d82
[pull] dove from feathersjs:dove
@candicetate
Updated Slack link to Discord link
22b7457
@candicetate
Updated Slack links to Discord links
f85aac8
@daffl
fix(express): Fix application typings to work with typed configuration (
4aabf87
feathersjs#2539)
@daffl
fix(schema): Properly handle resolver errors (feathersjs#2540)
58f03ef
@marshallswain
fix(queryProperty): allow compound oneOf (feathersjs#2545)
7cfea62
@daffl
chore: Update year and remove david-dm badges (feathersjs#2548)
ec529cd
@daffl
chore(dependencies): Update all dependencies and CI Node versions (fe…
4a02435
…athersjs#2549)
@fratzinger
Merge branch 'dove' of https://github.com/fratzinger/feathers into dove
fdfbb8c
@fratzinger
chore(transport-commons): export Channel, RealTimeConnection & Combin…
77c7741
…edChannel
@fratzinger
Merge branch 'dove' of https://github.com/feathersjs/feathers into fe…
2ee4f06
…athersjs-dove
@fratzinger
Merge pull request #41 from fratzinger/feathersjs-dove
eacadd9
Feathersjs dove
@daffl
feat: Publish native ES module builds
e4981d9
@fratzinger
chore(esm): moduleResolution: "node"
3c2bcb3
@fratzinger
fix(esm): export default and default module.exports
036bd6a
@fratzinger
Merge branch 'dove' into esm-build-fratzinger
88760f7
@fratzinger
Merge remote-tracking branch 'upstream/dove' into esm-build-fratzinger
57ba14b
@fratzinger
chore: revert global moduleResolution
7807fab
@fratzinger
fix(esm): don't use export = but export default
f7ac14b
- add module.exports for default export
@fratzinger
fix(esm): compile with --moduleResolution node
cbb636b
@fratzinger
lint: ignorePattern "**/esm/"
357f364
@daffl

daffl commented Jun 13, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

This looks like a good step, thank you. I am seeing the same error locally you can see in CI:

Error [ERR_PACKAGE_PATH_NOT_EXPORTED]: Package subpath './lib' is not defined by "exports" in /home/runner/work/feathers/feathers/packages/transport-commons/node_modules/@feathersjs/errors/package.json

I'm not sure what that means since all those packages have an identical configuration.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@fratzinger
fix(transport-commons): fix import from @feathersjs/errors
113ec58
@daffl daffl mentioned this pull request Aug 5, 2022
ESM Support #2423
Open
@daffl daffl mentioned this pull request Sep 14, 2022
[Dove] Drop reliance on legacy runtime compatibility settings #2748
Closed
@fratzinger
Merge branch 'dove' into esm-build-fratzinger
d2cc9f6
@netlify

netlify Bot commented Oct 29, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

✅ Deploy Preview for feathers-dove canceled.

Name Link
🔨 Latest commit 820743d
🔍 Latest deploy log https://app.netlify.com/sites/feathers-dove/deploys/63a1fa7fabc93400090a0d76
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@fratzinger fratzinger changed the title fix: esm build esm build Oct 29, 2022
@fratzinger
fratzinger changed the base branch from esm-build to dove October 29, 2022 17:57
@fratzinger
fix typo in compile script
8c4f594
fratzinger and others added 7 commits October 29, 2022 20:34
@fratzinger
fix(socketio-client): import from transport-commons
707f782
@fratzinger
chore: update package-lock
eef613a
@fratzinger
fix: text/fixture ref in express from authentication-local
5969be2
@fratzinger
chore: add todo comments for separate packages
b888cd0
@fratzinger
test: fix import from '[...]/lib'
b7eafb7
@fratzinger
chore: add esm to @feathersjs/cli
0af31a6
@daffl
Merge with latest dove
f839bcb
@daffl daffl changed the title esm build feat: ES module builds Dec 20, 2022
daffl added 3 commits December 20, 2022 09:51
@daffl
Update ESM build
e6f7a3d
@daffl
Update all dependencies
4095a58
@daffl
Update all package file lists
820743d
@daffl daffl mentioned this pull request Jan 30, 2023
bug(typebox): Typebox package should export the Value APIs #2927
Open
@FossPrime FossPrime changed the title feat: ES module builds feat: ES module builds (ESM Support) Jun 5, 2023
@fratzinger
Merge branch 'dove' into esm-build-fratzinger
43f2b08
@fratzinger
fratzinger marked this pull request as draft June 7, 2023 20:50
fratzinger added 2 commits June 9, 2023 19:41
@fratzinger
refactor: tsconfig.esm.json extends default
926ffd6
@fratzinger
fix: trailing comma json
0502063
@fratzinger

fratzinger commented Jun 9, 2023

Copy link
Copy Markdown
Member Author

@daffl, @FossPrime

I don't know what the error in the generator is about:
image

Builds are passing. I think we could try it out.

I don't know what the best strategy is though. Install from github is not possible because of lerna workspace packages, right? Maybe we need pre-versions.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@daffl

daffl commented Dec 20, 2023

Copy link
Copy Markdown
Member

Making a note here that the thing that may be missing is that the ESM and CJS folders each need a package.json that declares the module type like

{ "type": "module|commonjs" }

Now that TypeScript seems to support it properly it might also make sense to use full imports with .js extensions.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@daffl daffl mentioned this pull request Dec 22, 2023
feat: ES module build #3375
Closed
@daffl daffl added this to the v6 milestone Aug 19, 2025
@daffl daffl removed this from the v6 milestone Sep 5, 2025

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Optimization warnings in Angular 10 [Dove] Drop reliance on legacy runtime compatibility settings

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@fratzinger @daffl @candicetate @marshallswain
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.