GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — fix(express): Fix application typings to work with typed configuration by daffl · Pull Request #2539 · feathersjs/feathers

Conversation

@daffl

@daffl daffl commented Jan 25, 2022

Copy link
Copy Markdown
Member

The Express types overwrote the ability to type your Feathers configuration .set and .get which should be fixed by this pull request.

Closes #2533

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
daffl added 2 commits January 24, 2022 16:45
@daffl
fix(express): Fix application typings to work with typed configuration
865085e
@daffl
Update test and fix linter
eeec891
@daffl
daffl merged commit 4aabf87 into dove Jan 25, 2022
@daffl
daffl deleted the express-config-typing-2533 branch January 25, 2022 18:22
daffl added a commit that referenced this pull request Feb 15, 2022
@daffl
fix(express): Fix application typings to work with typed configuration (
b9dfaee 
#2539)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Different types of Application from @feathersjs/feathers and @feathersjs/express (dove)

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@daffl
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.