GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — fix(schema): Properly handle resolver errors by daffl · Pull Request #2540 · feathersjs/feathers

Conversation

@daffl

@daffl daffl commented Jan 25, 2022

Copy link
Copy Markdown
Member

This pull request fixes the resolver error handler (which was itself erroring).

Closes #2534

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@daffl
fix(schema): Properly handle resolver errors
891fcd2
@daffl
daffl merged commit 58f03ef into dove Jan 25, 2022
@daffl
daffl deleted the resolver-errors-2534 branch January 25, 2022 18:22
daffl added a commit that referenced this pull request Feb 15, 2022
@daffl
fix(schema): Properly handle resolver errors (#2540)
31fbdff
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Schema resolvers not gracefully handling errors thrown inside resolve function

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@daffl
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.