GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — fix(schema): Allow compound oneOf for queryProperty by marshallswain · Pull Request #2545 · feathersjs/feathers

Conversation

@marshallswain

@marshallswain marshallswain commented Jan 27, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Currently we use oneOf to create the queryProperty validations. This works fine until you nest it inside of another oneOf. In this case it fails every time. I've switched it to anyOf and have also added two tests to make sure it's both passing and failing correctly.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@marshallswain
fix(queryProperty): allow compound oneOf
a3fc93a 
Currently we use `anyOf` to create the `queryProperty` validations.  This works fine until you nest it inside of another `oneOf`.  In this case it fails every time.  I've switched it to `anyOf` and have also added two tests to make sure it's working according to spec.
@marshallswain

marshallswain commented Jan 27, 2022

Copy link
Copy Markdown
Member Author

Also, I should note that if we don't change to anyOf, the first test I added would fail.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@marshallswain
marshallswain requested a review from daffl January 27, 2022 21:39
@daffl daffl changed the title fix(queryProperty): allow compound oneOf fix(schema): Allow compound oneOf for queryProperty Jan 27, 2022
@daffl
daffl merged commit 7cfea62 into dove Jan 28, 2022
@daffl
daffl deleted the dove-compound-query-prop branch January 28, 2022 16:02
daffl pushed a commit that referenced this pull request Feb 15, 2022
@marshallswain @daffl
fix(queryProperty): allow compound oneOf (#2545)
3077d2d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@daffl daffl Awaiting requested review from daffl

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@marshallswain @daffl
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.