GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — chore: vitest by fratzinger · Pull Request #3344 · feathersjs/feathers

Conversation

@fratzinger

@fratzinger fratzinger commented Nov 21, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

migrate tests to vitest

  • add vitest to all packages
  • rm mocha & ts-node from all packages
  • change scripts accordingly
  • rename before/after mocha-hooks to beforeAll & afterAll
  • migrate from callbacks (deprecated in vitest) to Promises
  • do not use static ports, use pkg 'get-port' instead

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
fratzinger added 2 commits November 22, 2023 00:12
@fratzinger
chore: WIP - init vitest, rm mocha & ts-node
87f52b8 
- chore: migrate from callbacks to Promises
- chore: do not use static ports, use pkg 'get-port' instead
@fratzinger
test: add @feathersjs/adapter-tests-vitest & @feathersjs/tests-vitest
c8c0b97 
- test: rename (done) to (resolve, reject)
noor-tg
noor-tg reviewed Nov 23, 2023
View reviewed changes

@noor-tg noor-tg left a comment •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will you also change the building & dev tools to vite ?

For reference, I am using vite & vitest now with feathers .

So if you need any help . I am here

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@daffl

daffl commented Dec 1, 2023

Copy link
Copy Markdown
Member

I'd be open to this if the tests all pass, it run faster and supports a watch mode where it runs a package test suite on code changes.

Personally I was debating of moving everything to the new built-in Node test runner to reduce dependencies and - now that it is stable - also have to worry less about version upgrades (which was finicky sometimes even with Mocha which hasn't really changed much). But it's still clunky to use in some cases. For example, it doesn't support running TypeScript tests recursively (except with a programmatic hack).
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@daffl

daffl commented Jan 25, 2024

Copy link
Copy Markdown
Member

I started using Vitest in another project and it is indeed working quite nicely and was the only test runner that worked with ES modules out of the box so this might also help us with the pains from #3375
marshallswain reacted with heart emoji
All reactions
  • ❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
fratzinger added 3 commits March 22, 2024 20:08
@fratzinger
chore: update vitest dependency
e9ad2f3
@fratzinger
chore: update dependencies
aaff3f4
@fratzinger
Merge branch 'dove' into chore/vitest
0d7a222
@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Mar 22, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Deploying feathers-dove with  Cloudflare Pages  Cloudflare Pages

Latest commit: ca2608f
Status: ✅  Deploy successful!
Preview URL: https://b9fc15e1.feathers.pages.dev
Branch Preview URL: https://chore-vitest.feathers.pages.dev

View logs
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@fratzinger
chore: rm unused packages
f863d7e
@fratzinger
fratzinger marked this pull request as ready for review March 22, 2024 20:04
@fratzinger

fratzinger commented Mar 22, 2024

Copy link
Copy Markdown
Member Author

CI is broken for some reason. Only package that fails is '@feathersjs/knex' I think. But I don't know why. Please @daffl have a look.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@daffl
Fix Knex tests
57c5dc7
@fratzinger fratzinger changed the title WIP: chore: vitest chore: vitest Mar 25, 2024
fratzinger added 8 commits March 26, 2024 10:13
@fratzinger
chore: update license year
50df402
@fratzinger
test: fix tests for koa & express
aff8a4a
@fratzinger
test(socketio): fix socket.io tests
3e8156e
@fratzinger
test(rest-client): fix tests for rest-client
88b0b39
@fratzinger
chore: rm linting error unused var
718f224
@fratzinger
test: fix unhandled rejections
6daf303
@fratzinger
test(mongodb): add await
d62d305
@fratzinger
test(authentication-client): fix await
ca2608f
@daffl
daffl changed the base branch from dove to v6 September 25, 2024 20:34
@daffl
daffl deleted the branch v6 February 4, 2025 00:43
@daffl daffl closed this Feb 4, 2025
@daffl
daffl deleted the chore/vitest branch May 27, 2026 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@noor-tg noor-tg noor-tg left review comments
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@fratzinger @daffl @noor-tg
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.