GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — feat: ES module build by daffl · Pull Request #3375 · feathersjs/feathers

Conversation

@daffl

@daffl daffl commented Dec 22, 2023

Copy link
Copy Markdown
Member

This pull request adds ES module builds for all packages.

  • Closes feat: ES module builds (ESM Support) #2665
  • Closes [Dove] Drop reliance on legacy runtime compatibility settings #2748
  • Closes Optimization warnings in Angular 10 #2001
  • Closes authenticationClient - Not callable compilation error when using TS module Nodenext  #3343

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
daffl added 6 commits December 22, 2023 13:52
@daffl
feat: ES Module build
92e9211
@daffl
Update src/ paths
e5fc686
@daffl
Migrate commons and errors
2822ef5
@daffl
adapter-commons ES module
b5e4173
@daffl
adapter-tests ES module
eab04b9
@daffl
authentication ES modules
4ca1ab6
@daffl
daffl marked this pull request as draft December 22, 2023 21:56
daffl added 2 commits December 22, 2023 13:57
@daffl
configuration and express ES module
03ed621
@daffl
database adapter es modules
347be8b
@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Dec 22, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 1af1513
Status: ✅  Deploy successful!
Preview URL: https://d5f1801c.feathers.pages.dev
Branch Preview URL: https://es-modules.feathers.pages.dev

View logs
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
daffl added 4 commits December 22, 2023 15:10
@daffl
schema and typebox es module
3d8c813
@daffl
koa and socketio es module
414f3d8
@daffl
rest and socketio client es modules
a7c88b9
@daffl
Finalise ES module migration
5af879a
@daffl
daffl marked this pull request as ready for review December 23, 2023 00:02
@daffl
Add missing dependency and update package-lock.json
1af1513
@daffl

daffl commented Jan 24, 2024

Copy link
Copy Markdown
Member Author

Well this doesn't seem to be working at all. Even just migrating the CLI to ES modules (starting with #3386) caused a whole rats tail of weird and unexpected issues.
jamesvillarrubia reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@daffl daffl mentioned this pull request Jan 25, 2024
chore: vitest #3344
Closed
@daffl

daffl commented Aug 19, 2025

Copy link
Copy Markdown
Member Author

Full ES module support is now working in https://github.com/feathersjs/feathers/tree/v6
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@daffl daffl closed this Aug 19, 2025
@daffl
daffl deleted the es-modules branch August 19, 2025 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

authenticationClient - Not callable compilation error when using TS module Nodenext Optimization warnings in Angular 10 [Dove] Drop reliance on legacy runtime compatibility settings

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@daffl
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.