GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | ||||||||||||||||||||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | ||||||||||||||||||||||||||||
GeezerVison is showing github.com — Show all pipeline source files in the profiler by Karakatiza666 · Pull Request #7484 · feldera/feldera Conversation
|
|
LGTM.
The tests cover the new behaviour well: parsing (non-string, empty and missing fields), tab order, fallback to the first file, returning to |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
4631776 to
652a1cc
Compare
bc20408 to
9eedc98
Compare
9eedc98 to
c14b34c
Compare
d04e134 to
3d64987
Compare
|
What I ran
QA: the PR's tests already cover the edge cases I came up with: no missing (medium): docs gate. Apart from the docs, the code looks good to me. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
I approved, but please take a look at the comments.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
e7a2389 to
68af1c1
Compare
53b9d4d to
6e4ed3b
Compare
cfeab5d to
9131afa
Compare
18eeaf0 to
3c327ac
Compare
3c327ac to
80d8c81
Compare
80d8c81 to
4dafbe5
Compare
4dafbe5 to
fb19205
Compare
fb19205 to
1a74822
Compare
1a74822 to
20bda15
Compare
20bda15 to
64a22ea
Compare
The code panel of the profiler gets a tab for each pipeline source file in the bundle: `program.sql`, `udf.rs` and `udf.toml`, with the same names as in the web-console editor. The panel does not show the generated `stubs.rs`. - `processProfileFiles` reads the files from `pipeline_config.json` and returns them as `sourceFiles`, with `program.sql` first. It leaves out empty UDF files and a missing `program_code`, so a bundle without source code still loads. `sourceFiles` replaces `sources`. - `SupportBundleViewerLayout` takes `sourceFiles` and no longer takes `programCode` or the unused `sqlPanel` snippet. It gives the diagram the lines of `program.sql`. - A click on a node with SQL opens the `program.sql` tab. A new bundle without the open file opens the first file. A bundle without source files shows "Source code is not in the bundle". - `SqlCodeView` and `SqlTab` become `SourceCodeView` and `SourceTab`. Each file has its own Monaco model. - profiler-app bundles the Monaco `rust` and `graphql` languages. TOML uses `graphql`, the same as the web-console editor. - The test stub `ComponentStub` becomes `LayoutPanelStub`.
The comments said the diagram and the code panel are "hoisted". They now say what this means: each one is rendered once, at the root of the layout, in an overlay that follows a placeholder in the active layout branch. The diagram comment also named a PersistentPlaceholder component that does not exist. The placeholder is a div with the placeholder action.
64a22ea to
6d94975
Compare
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
[profile] The profiler should show udf.rs and udf.toml
There was an error while loading. Please reload this page.