GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Show all pipeline source files in the profiler by Karakatiza666 · Pull Request #7484 · feldera/feldera

Conversation

@Karakatiza666

@Karakatiza666 Karakatiza666 commented Oct 14, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

The code panel of the profiler gets a tab for each pipeline source file in the bundle: program.sql, stubs.rs, udf.rs and udf.toml, with the same names and order as in the web-console editor.

  • processProfileFiles reads the files from pipeline_config.json and returns them as sourceFiles. It leaves out empty UDF files and a missing program_code, so a bundle without source code still loads.
image

Fix #7084

Testing

New tests for parsing the source files, the code panel tabs and SourceCodeView.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@Karakatiza666
Karakatiza666 added this pull request to stack #7313 October 14, 2026 14:34
@Karakatiza666
Karakatiza666 force-pushed the profiler-source-files branch from 7b9e8c6 to ae1aa4e Compare October 14, 2026 14:41
@mythical-fred-oss

mythical-fred-oss Bot commented Oct 14, 2026

Copy link
Copy Markdown
Contributor

LGTM.

Ran Result
vitest --run in profiler-layout (browser + component + unit) 193/193 passed
Code panel and SourceCodeView specs, repeated 5× to look for flakiness 30/30 every run
web-console profile-viewer specs 24/24 passed
svelte-check for profiler-layout, profiler-app and web-console 0 errors
profiler-app vite build (single file with rust + graphql) builds
pre-commit run --files <changed> passed

The tests cover the new behaviour well: parsing (non-string, empty and missing fields), tab order, fallback to the first file, returning to program.sql on a node click, and reloading a bundle with or without the open file. I found no failing feldera-pr-checks gate.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@Karakatiza666
Karakatiza666 force-pushed the profiler-source-files branch 3 times, most recently from 4631776 to 652a1cc Compare October 15, 2026 17:34
@Karakatiza666
Karakatiza666 force-pushed the profiler-source-files branch 2 times, most recently from bc20408 to 9eedc98 Compare October 16, 2026 13:15
@Karakatiza666
Karakatiza666 force-pushed the profiler-source-files branch from 9eedc98 to c14b34c Compare October 16, 2026 13:26
@Karakatiza666
Karakatiza666 force-pushed the profiler-source-files branch 2 times, most recently from d04e134 to 3d64987 Compare October 16, 2026 15:46
@Karakatiza666
Karakatiza666 marked this pull request as ready for review October 16, 2026 19:46
@Karakatiza666
Karakatiza666 requested a review from mihaibudiu October 16, 2026 19:49
@mythical-fred-oss

mythical-fred-oss Bot commented Oct 16, 2026

Copy link
Copy Markdown
Contributor

What I ran

Check Result
pre-commit run --files <changed files> ✅ passed
svelte-check (profiler-layout) ✅ 0 errors
vitest --run profiler-layout, all projects (browser, component, unit) ✅ 209/209
New layout + SourceCodeView specs, run 3× ✅ 27/27 each run, no flakes
web-console profileViewerPage spec ✅ 13/13

QA: the PR's tests already cover the edge cases I came up with: no pipeline_config.json, program_code missing or not a string, empty or non-string UDF fields, a bundle with only UDF files, a node click from the udf.rs tab (with and without SQL ranges), and a new bundle that keeps or drops the open file. I found no missing test cases worth asking for.

missing (medium): docs gate. docs.feldera.com/docs/operations/visualizing-profiles.md still describes a single "SQL panel" showing "The SQL program of the pipeline", in the layout table, in the expand-button paragraph and in "Nodes and SQL". This PR renames it to the code panel, adds udf.rs and udf.toml tabs, and makes a node click switch back to program.sql. Please update that page: the panel name, the file tabs, and the empty state when the bundle has no source code.

Apart from the docs, the code looks good to me.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

mihaibudiu
mihaibudiu approved these changes Oct 17, 2026
View reviewed changes

@mihaibudiu mihaibudiu left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approved, but please take a look at the comments.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Karakatiza666 reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
Comment thread js-packages/profiler-app/vite.config.ts Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread js-packages/profiler-layout/src/lib/components/SupportBundleViewerLayout.svelte Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread js-packages/profiler-layout/src/lib/components/SupportBundleViewerLayout.svelte Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread js-packages/profiler-layout/src/lib/functions/processZipBundle.ts Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread js-packages/profiler-layout/src/lib/functions/processZipBundle.ts Resolved

Uh oh!

There was an error while loading. Please reload this page.

@Karakatiza666
Karakatiza666 force-pushed the profiler-source-files branch from e7a2389 to 68af1c1 Compare October 26, 2026 11:51
@Karakatiza666
Karakatiza666 force-pushed the profiler-source-files branch 2 times, most recently from 53b9d4d to 6e4ed3b Compare October 26, 2026 12:18
@Karakatiza666
Karakatiza666 force-pushed the profiler-source-files branch 2 times, most recently from cfeab5d to 9131afa Compare October 26, 2026 13:06
@Karakatiza666
Karakatiza666 force-pushed the profiler-source-files branch 2 times, most recently from 18eeaf0 to 3c327ac Compare October 26, 2026 14:27
@Karakatiza666
Karakatiza666 force-pushed the profiler-source-files branch from 3c327ac to 80d8c81 Compare October 26, 2026 15:47
@Karakatiza666
Karakatiza666 enabled stacked auto-merge October 26, 2026 15:51
@Karakatiza666
Karakatiza666 added this pull request to the merge queue Oct 26, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue because a pull request earlier in the stack was removed Oct 26, 2026
@Karakatiza666
Karakatiza666 force-pushed the profiler-source-files branch from 80d8c81 to 4dafbe5 Compare October 26, 2026 17:17
@Karakatiza666
Karakatiza666 added this pull request to the merge queue Oct 27, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue because a pull request earlier in the stack was removed Oct 27, 2026
@Karakatiza666
Karakatiza666 added this pull request to the merge queue Oct 28, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue because a pull request earlier in the stack was removed Oct 28, 2026
@Karakatiza666
Karakatiza666 force-pushed the profiler-source-files branch from 4dafbe5 to fb19205 Compare October 28, 2026 15:49
@Karakatiza666
Karakatiza666 added this pull request to the merge queue Oct 28, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue because a pull request earlier in the stack was removed Oct 28, 2026
@Karakatiza666
Karakatiza666 force-pushed the profiler-source-files branch from fb19205 to 1a74822 Compare October 28, 2026 17:39
@Karakatiza666
Karakatiza666 added this pull request to the merge queue Oct 28, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue because a pull request earlier in the stack was removed Oct 29, 2026
@Karakatiza666
Karakatiza666 force-pushed the profiler-source-files branch from 1a74822 to 20bda15 Compare October 29, 2026 05:09
@Karakatiza666
Karakatiza666 force-pushed the profiler-source-files branch from 20bda15 to 64a22ea Compare October 30, 2026 13:28
Base automatically changed from profiler-pipeline-events to main October 30, 2026 15:58
Karakatiza666 added 2 commits October 30, 2026 19:58
@Karakatiza666
Show the UDF files in the profiler
f404645
The code panel of the profiler gets a tab for each pipeline source file in
the bundle: `program.sql`, `udf.rs` and `udf.toml`, with the same names as in
the web-console editor. The panel does not show the generated `stubs.rs`.

- `processProfileFiles` reads the files from `pipeline_config.json` and
  returns them as `sourceFiles`, with `program.sql` first. It leaves out empty
  UDF files and a missing `program_code`, so a bundle without source code
  still loads. `sourceFiles` replaces `sources`.
- `SupportBundleViewerLayout` takes `sourceFiles` and no longer takes
  `programCode` or the unused `sqlPanel` snippet. It gives the diagram the
  lines of `program.sql`.
- A click on a node with SQL opens the `program.sql` tab. A new bundle
  without the open file opens the first file. A bundle without source files
  shows "Source code is not in the bundle".
- `SqlCodeView` and `SqlTab` become `SourceCodeView` and `SourceTab`. Each
  file has its own Monaco model.
- profiler-app bundles the Monaco `rust` and `graphql` languages. TOML uses
  `graphql`, the same as the web-console editor.
- The test stub `ComponentStub` becomes `LayoutPanelStub`.
@Karakatiza666
Explain the persistent overlays in the profiler layout
6d94975
The comments said the diagram and the code panel are "hoisted". They now
say what this means: each one is rendered once, at the root of the layout,
in an overlay that follows a placeholder in the active layout branch.
The diagram comment also named a PersistentPlaceholder component that does
not exist. The placeholder is a div with the placeholder action.
@Karakatiza666
Karakatiza666 force-pushed the profiler-source-files branch from 64a22ea to 6d94975 Compare October 30, 2026 15:58
@Karakatiza666
Karakatiza666 enabled stacked auto-merge October 30, 2026 15:59
@Karakatiza666
Karakatiza666 added this pull request to the merge queue Oct 30, 2026
Merged via the queue into main with commit 36479ff Oct 30, 2026
1 check passed

Uh oh!

There was an error while loading. Please reload this page.

@Karakatiza666
Karakatiza666 deleted the profiler-source-files branch October 30, 2026 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mihaibudiu mihaibudiu mihaibudiu approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[profile] The profiler should show udf.rs and udf.toml

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@Karakatiza666 @mihaibudiu
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.