GeezerVisonThe World Wide Web, restored to 800 pixels of glory. |
| Home|About|Gaming cabinet|Archives|How it works|Starter sites |
GeezerVison is showing github.com — [web-console] Tighten and group the runtime connector tables by AnnaZhand · Pull Request #7766 · feldera/feldera Conversation
Contributor
Linked IssueDesign polish of the Runtime tab's connector tables; no issue. Describe Manual Test PlanCompared the Tables (inputs) and Views (outputs) connector tables before and after this change, in light and dark mode, with three datasets: a six-table pipeline with transactions, a multi-connector pipeline with an unhealthy connector, and an edge-case set covering every connector state (running, ingesting, paused, end of input, parse/transport/encode errors, fatal error, checkpoint barrier, unhealthy with and without a description, no latency yet, 999,999,999-sized values, long connector names, mixed multi-connector rows). Checked that:
Screenshots: before/after posted as a comment below. Checklist
Breaking Changes?Mark if you think the answer is yes for any of these components:
Describe Incompatible ChangesNone. 🤖 Generated with Claude Code
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
Restyle the Tables and Views connector tables on the Runtime tab:
- Two-line headers for every metric column ("Ingested / records",
"Latency / p99 ?"), in one colour, with a left-aligned latency
tooltip.
- Group columns by metric family: columns of one family sit close
together and each new family (Connectors, Transaction, Buffered,
Latency, Parse errors, Encode errors) starts after a wider gap.
Number columns reserve room for their widest value, so they keep
their width as live values change.
- Show an unhealthy connector as a warning icon in the slow-latency
red, hanging before the status icons so those stay in one column.
Its popover keeps the description and copy button, leads with a red
"Unhealthy" and uses the table's 12px type.
- Point the expand chevron right when collapsed and down when
expanded, and give expandable rows a hover shade distinct from the
page background in both themes.
- Use a softer red (error-300) for slow latency in dark mode.
Tests read header text from textContent, since headers now break
across lines.
Signed-off-by: AnnaZhand <[email protected]>
Co-Authored-By: Claude Opus 5.5 <[email protected]>
Raise the Tables and Views connector tables, and the unhealthy popover, from 12px type on 18px lines to 14px on 20px lines, and size the header row for two 20px lines. Number columns are sized in character units, so they scale with the type and keep their alignment and group spacing. Signed-off-by: AnnaZhand <[email protected]> Co-Authored-By: Claude Opus 5.5 <[email protected]>
Karakatiza666
force-pushed
the
web-console-connector-tables-spacing
branch
from
03a79a1 to
f7dedfd
Compare
Karakatiza666
enabled auto-merge
Karakatiza666
self-requested a review
Signed-off-by: Karakatiza666 <[email protected]>
Karakatiza666
force-pushed
the
web-console-connector-tables-spacing
branch
from
f7dedfd to
2baf7e7
Compare
Karakatiza666
approved these changes
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. LGTM
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
Karakatiza666
disabled auto-merge
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Uh oh!
There was an error while loading. Please reload this page. Uh oh!
There was an error while loading. Please reload this page.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
ReviewersUh oh!
There was an error while loading. Please reload this page. AssigneesNo one assignedLabels
None yet
ProjectsMilestoneNo milestoneDevelopmentSuccessfully merging this pull request may close these issues. Uh oh!
There was an error while loading. Please reload this page. Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later. |
| You are visitor 01402503 — GeezerVison does not store the pages you look up. Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required. |