GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — fix(appcheck): Use v1beta endpoint for verifyAppCheckToken by lahirumaramba · Pull Request #987 · firebase/firebase-admin-python

Conversation

lahirumaramba commented Sep 22, 2026

Copy link

Copy Markdown

Member

Regression from #976

Updated _AppCheckService._VERIFY_URL_FORMAT in firebase_admin/app_check.py to use the v1beta endpoint (https://firebaseappcheck.googleapis.com/v1beta/projects/{project_id}:verifyAppCheckToken) when verifying token replay protection (consume=True), as verifyAppCheckToken is publicly exposed under v1beta.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

gemini-code-assist[bot] reacted with eyes emoji

All reactions

👀 1 reaction


          fix(fac): Use v1beta endpoint for verifyAppCheckToken

f28e37f

Updated _AppCheckService._VERIFY_URL_FORMAT to point to the v1beta endpoint (https://firebaseappcheck.googleapis.com/v1beta/projects/{project_id}:verifyAppCheckToken) for replay protection verification.

lahirumaramba requested a review from yvonnep165

September 22, 2026 22:16

lahirumaramba assigned yvonnep165

Sep 22, 2026

lahirumaramba requested a review from a team

September 22, 2026 22:16

lahirumaramba added the release-note label

Sep 22, 2026

gemini-code-assist Bot reviewed

Sep 22, 2026

View reviewed changes

gemini-code-assist Bot left a comment

Copy link

Copy Markdown

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the App Check verification URL format from 'v1' to 'v1beta' in firebase_admin/app_check.py and updates the corresponding unit tests in tests/test_app_check.py to reflect this change. There are no review comments, and the changes appear to be correct and complete.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          chore(fac): Fix line length lint in test_app_check.py

b2733ee

yvonnep165 approved these changes

Sep 23, 2026

View reviewed changes

yvonnep165 left a comment

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

yvonnep165 commented Sep 23, 2026

Copy link

Copy Markdown

Contributor

Also I want to confirm that the PR title should be feat(appcheck) or feat(fac) for the appcheck team related matters? Cause I saw a mix use of both

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

lahirumaramba commented Sep 23, 2026

Copy link

Copy Markdown

Member Author

Also I want to confirm that the PR title should be feat(appcheck) or feat(fac) for the appcheck team related matters? Cause I saw a mix use of both

These were used by a previous release note generation tool that we no longer use, so it doesn't matter much. Either prefix is fine, but let's stick with "appcheck" moving forward for consistency :)

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.


          Merge branch 'main' into gemini-fix-appcheck-verify-url

8e5d373

lahirumaramba changed the title ~~fix(fac): Use v1beta endpoint for verifyAppCheckToken~~ fix(appcheck): Use v1beta endpoint for verifyAppCheckToken

Sep 23, 2026

lahirumaramba merged commit 6d5d8b6 into main

Sep 23, 2026

24 checks passed

Uh oh!

There was an error while loading. Please reload this page.

lahirumaramba deleted the gemini-fix-appcheck-verify-url branch

September 23, 2026 16:01

lahirumaramba mentioned this pull request

Sep 23, 2026

[chore] Release 7.7.0 #988

Merged

morganchen12 pushed a commit that referenced this pull request

Oct 30, 2026


          fix(appcheck): Use v1beta endpoint for verifyAppCheckToken (#987)

add80a5

* fix(fac): Use v1beta endpoint for verifyAppCheckToken

Updated _AppCheckService._VERIFY_URL_FORMAT to point to the v1beta endpoint (https://firebaseappcheck.googleapis.com/v1beta/projects/{project_id}:verifyAppCheckToken) for replay protection verification.

* chore(fac): Fix line length lint in test_app_check.py

Reviewers

yvonnep165

yvonnep165 approved these changes

+1 more reviewer

gemini-code-assist[bot]

gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

yvonnep165

Labels

release-note

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.