Description

nzayatz14

opened on May 19, 2020

Issue body actions

You have several examples using the zoom prop to set the zoom level of the map, but this prop is not listed in the IMapProps definition in the index.ts file, making it unusable for typescript projects.

Current value:

export interface IMapProps extends google.maps.MapOptions {
  google: GoogleAPI
  loaded?: boolean

  style?: Style
  containerStyle?: Style

  bounds?: google.maps.LatLngBounds | google.maps.LatLngBoundsLiteral
  centerAroundCurrentLocation?: boolean
  initialCenter?: google.maps.LatLngLiteral
  center?: google.maps.LatLngLiteral

  visible?: boolean

  onReady?: mapEventHandler
  onClick?: mapEventHandler
  onDragend?: mapEventHandler
  onRecenter?: mapEventHandler
  onBoundsChanged?: mapEventHandler
  onCenterChanged?: mapEventHandler
  onDblclick?: mapEventHandler
  onDragstart?: mapEventHandler
  onHeadingChange?: mapEventHandler
  onIdle?: mapEventHandler
  onMaptypeidChanged?: mapEventHandler
  onMousemove?: mapEventHandler
  onMouseover?: mapEventHandler
  onMouseout?: mapEventHandler
  onProjectionChanged?: mapEventHandler
  onResize?: mapEventHandler
  onRightclick?: mapEventHandler
  onTilesloaded?: mapEventHandler
  onTiltChanged?: mapEventHandler
  onZoomChanged?: mapEventHandler
}

Reacted by Marin Andros, Diogo Poeira, Giorgi, Aaron B and Nicolas Justiniano

Activity

1. mandros1 commented on May 20, 2020

   

   mandros1

   on May 20, 2020

   More actions

   +1 I also noticed this, which is weird since it is so boldly simple in the readme, but I did read somewhere in their readme that the bounds property should set the zoom as well (which makes sense) but I still haven't been able to get it to do anything, the original code of it is below

   var points = [
     { lat: 42.02, lng: -77.01 },
     { lat: 42.03, lng: -77.02 },
     { lat: 41.03, lng: -77.04 },
     { lat: 42.05, lng: -77.02 }
   ]
   const bounds = new this.props.google.maps.LatLngBounds()
   
   for (var i = 0; i < points.length; i++) {
     bounds.extend(points[i]);
   }
   
   return (
     <Map 
       google={this.props.google}
       style={containerStyle}
       initialCenter={{
           lat: 42.39,
           lng: -72.52
       }}
       bounds={bounds}
     >)
   
2. luiscassih commented on May 25, 2020

   

   luiscassih

   on May 25, 2020

   More actions

   Adding the @types/googlemaps package solved the zoom issue with typescript but now I've facing another ts compiler error with TS7006: Parameter 'event' implicitly has an 'any' type. on ./node_modules/google-maps-react/index.d.ts:27:70
   Makes this package unusable for me on typescript

   Reacted by Aaron B

Issue actions