GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Add zoom property to IMapProps by MaciekBaron · Pull Request #445 · fullstackreact/google-maps-react

Conversation

@MaciekBaron

@MaciekBaron MaciekBaron commented May 27, 2020

Copy link
Copy Markdown

Resolves #443

zoom is missing from the props, causing a type error to appear.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
leocavalcante reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@MaciekBaron
Add zoom property to IMapProps
8f083ed
@sridaradappt

sridaradappt commented May 29, 2020

Copy link
Copy Markdown

Any idea when this change will be released ?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Gamezordd

Gamezordd commented Jun 6, 2020

Copy link
Copy Markdown

Important change!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@MaciekBaron

MaciekBaron commented Jun 8, 2020

Copy link
Copy Markdown
Author

Any idea when this change will be released ?

Unfortunately the last time the maintainer of this project was active was 2 months ago, so no idea.

However if you desperately want to avoid type errors, a workaround is to set zoom on load:

onReady={(mapProps, map) => map.setOptions({zoom: 5})}
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@MaciekBaron

MaciekBaron commented Jun 26, 2020

Copy link
Copy Markdown
Author

Hi @auser sorry to ping but it's been a month and it's a tiny change that (as you can see) is requested by a few people. Could you have a look? Thanks!
ajkovar, msmid, hirokikondo86, and leocavalcante reacted with thumbs up emoji
All reactions
  • 👍 4 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

'zoom' not listed as a valid propType in the index.ts file

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@MaciekBaron @sridaradappt @Gamezordd
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.