Description

Ehesp

opened on Nov 15, 2016

Issue body actions

Hello,

Bear in mind, I'm not to clued up to Android yet...

I keep running into the same issue whereby my build fails due to "Multiple dex files". The cause of this is conflicting play-services versions across multiple libs. This library hard sets the dep to 9.8.0.

Other libs seem to only set it to "whatever is latest", e.g: https://github.com/zo0r/react-native-push-notification/blob/master/android/build.gradle#L44 & https://github.com/idehub/react-native-google-analytics-bridge/blob/master/android/build.gradle#L21

The only way I can fix these errors is by either:

1. Adding this to my own build.gradle:

dependencies {
    compile ('com.google.android.gms:play-services-gcm:9.8.0') {
      force = true;
    }
    ...

2. Going into node_modules, and changing the line to compile 'com.google.android.gms:play-services-base:+'.

Didn't want to make a PR since I'm not sure if this will have any repercussions?

Reacted by Patrick

Activity

1. auser commented on Nov 15, 2016

   

   auser

   on Nov 15, 2016

   Contributor

   More actions

   That should be fine. Make a PR when you get a chance. I think that sounds like a great idea.

   @Ehesp ^^
2. auser commented on Nov 16, 2016

   

   auser

   on Nov 16, 2016

   Contributor

   More actions

   Actually, what do you think about doing this for all Firestack dependencies?
3. Ehesp commented on Nov 16, 2016

   

   Ehesp

   on Nov 16, 2016

   ContributorAuthor

   More actions

   I supposed the only issue is if the lib isn't kept up to date with say the latest firebase SDK, then users are going to have weird issues.
4. auser commented on Nov 17, 2016

   

   auser

   on Nov 17, 2016

   Contributor

   More actions

   Good point. I agree.
5. Ehesp

   added a commit that references this issue on Nov 18, 2016

   Don't hard set Android play services version fullstackreact#134

   7cb0a08
6. Salakar commented on Nov 19, 2016

   

   Salakar

   on Nov 19, 2016

   Collaborator

   More actions

   Closing as fixed on v3 branch.
7. Salakar

   closed this as completedon Nov 19, 2016
8. auser

   added a commit that references this issue on Dec 8, 2016

   Merge pull request #146 from Ehesp/patch-2

   919066c

Issue actions