GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — ref(transport): Simplify redundant DSN check in Transport.__init__ · Issue #6089 · getsentry/sentry-python

ref(transport): Simplify redundant DSN check in Transport.__init__ #6089

New issue
Copy link
New issue
Copy link
Closed
#6104
Closed
ref(transport): Simplify redundant DSN check in Transport.__init__#6089
#6104
Copy link
Labels
PythonSDKSDKTask

Description

@psh9508
psh9508
opened on Apr 17, 2026
Issue body actions

In Transport.init (transport.py#L109), the DSN check contains a redundant is not None guard:                                     
   
if options and options["dsn"] is not None and options["dsn"]:                                                                        
                                                                                         
The is not None check is unnecessary — the subsequent truthiness check already evaluates None as falsy, making it redundant.         
                                                                                         
This is also inconsistent with the existing pattern later in the same file:                                                          
                                                                                         
transport.py L1165                                                                                                                 
if options["dsn"]:

Suggested Change

  • if options and options["dsn"] is not None and options["dsn"]:
  • if options and options["dsn"]:

Activity

  1. getsantry
    added
    Waiting for: Product Owner
    on Apr 17, 2026
  2. getsantry
    added this to GitHub Issues with 👀 3on Apr 17, 2026
  3. linear-code commented on Apr 17, 2026

    @linear-code
    linear-codeBot
    on Apr 17, 2026 – with Linear Code
    More actions

    PY-2379

  4. getsantry
    moved this to Waiting for: Product Owner in GitHub Issues with 👀 3on Apr 17, 2026
  5. linear-code
    added
    Task
    PythonSDKSDK
    on Apr 17, 2026
  6. ericapisani commented on Apr 20, 2026

    @ericapisani
    ericapisani
    on Apr 20, 2026
    Member
    More actions

    Hi @psh9508 ,

    Thanks for opening an issue! If you're keen, you're more than welcome to open a PR for this, but otherwise someone from our team can take a look at this.

  7. getsantry
    removed
    Waiting for: Product Owner
    on Apr 20, 2026
  8. getsantry
    moved this from Waiting for: Product Owner to No status in GitHub Issues with 👀 3on Apr 20, 2026
  9. sentrivana
    closed this as completedin #6104on Apr 24, 2026
  10. pull
    added a commit that references this issue on Apr 24, 2026

    ref(transport): Remove redundant checks for dsn (getsentry#6104)

    This issue will close once commit 1b72b88 is merged into the 'master' branch.
    1b72b88
  11. mgaligniana
    added a commit that references this issue on Aug 9, 2026

    ref(transport): Remove redundant checks for dsn (getsentry#6104)

    This issue will close once commit 6629104 is merged into the 'master' branch.
    6629104
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    PythonSDKSDKTask

    Projects

    • GitHub Issues with 👀 3
      Status
      No status
      Show more project fields

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

    You are visitor 01402503 — GeezerVison does not store the pages you look up.
    Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.