GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — ref(tracing): Remove unused base64_stripped regex by sentry-junior[bot] · Pull Request #8148 · getsentry/sentry-python

Conversation

@sentry-junior

@sentry-junior sentry-junior Bot commented Oct 29, 2026

Copy link
Copy Markdown
Contributor

Description

Removes the module-level base64_stripped regex string from sentry_sdk/tracing_utils.py. Nothing has used it since 2023.

#1179 (Sep 2021) added it to validate the base64-encoded Sentry entry in the tracestate header. #1907 (Feb 2023, "Remove deprecated tracestate") deleted its only use, re.search("^{b64}$".format(b64=base64_stripped), sentry_value), but left the definition and its comment behind.

Evidence

  • git grep -n base64_stripped across the whole repo matches only the definition.
  • git log -S base64_stripped shows exactly two commits: the one that added it (feat(tracing): Add tracestate header handling #1179) and the one that removed its only caller (Remove deprecated tracestate #1907).
  • No open PR or issue in this repo mentions base64_stripped.

Why it's safe

  • It's a plain string constant in an internal module. It's not re-exported from sentry_sdk and doesn't appear in docs/, CHANGELOG.md or MIGRATION_GUIDE.md.
  • It was never compiled or read at runtime, so behavior doesn't change.
  • re is still used by SENTRY_TRACE_REGEX and other code in the module.

Checks

  • uv run ruff check and ruff format --check on the file pass.
  • uv run --group typing mypy sentry_sdk passes with no issues.
  • TESTPATH=tests/tracing uv run tox -e py3.14-common: 426 passed.

Issues

None. Found by a dead-code sweep.

via automation sched_65eed06cc199036c2b13411096f412d4 · Run ID sched_65eed06cc199036c2b13411096f412d4:1793269189822.

--

View Junior Session [Sentry]

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@sentry-junior
ref(tracing): Remove unused base64_stripped regex
5417911
@sentry-junior
sentry-junior Bot requested a review from a team as a code owner October 29, 2026 10:25
sentrivana
sentrivana approved these changes Oct 29, 2026
View reviewed changes
@sentrivana
sentrivana enabled auto-merge (squash) October 29, 2026 10:26
@sentrivana
sentrivana merged commit 825ff97 into master Oct 29, 2026
170 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@sentrivana
sentrivana deleted the ref/remove-unused-base64-stripped-regex branch October 29, 2026 10:37
@github-actions

github-actions Bot commented Oct 29, 2026

Copy link
Copy Markdown
Contributor

Coverage Results 📊

✅ 136856 passed | ⏭️ 7456 skipped | Total: 144312 | Pass Rate: 94.83% | Execution Time: 464m 37s

📊 Comparison with Base Branch

Metric Change
Total Tests —
Passed Tests —
Failed Tests —
Skipped Tests —

✨ Test counts unchanged from base.

All tests are passing successfully.

✅ Patch coverage is 100.00% (no changed executable lines found; target 80%).
Project statement coverage is 90.32% (up 0.02 percentage points from base (876a82f) to head (5417911)).

Files with missing lines (1)
File Coverage % Lines
sentry_sdk/tracing_utils.py 93.29% ⚠️ 56 Missing and 45 partials
Coverage diff 
@@            Coverage Diff             @@
##        master     #8148       +/-##
==========================================
+ Coverage    90.30%    90.32%    +0.02%
==========================================
  Files          203       203         —
  Tracked lines     26874     26873        -1
  Branches     10044     10044         —
==========================================
+ Hits         24268     24273        +5
+ Misses        2606      2600        -6
- Partials      1519      1520        +1

Generated by Coverage Action
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
This was referenced Nov 4, 2026
publish: getsentry/[email protected] getsentry/publish#10182
Closed
publish: getsentry/[email protected] getsentry/publish#10240
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sentrivana sentrivana sentrivana approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@sentrivana
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.