GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Remove deprecated `tracestate` by antonpirker · Pull Request #1907 · getsentry/sentry-python

Conversation

@antonpirker

@antonpirker antonpirker commented Feb 16, 2023

Copy link
Copy Markdown
Contributor

Sentry is using baggage for trace propagation to the implementation of tracestate was deprecated for a while now and will not be removed.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
sl0thentr0py and others added 4 commits February 6, 2023 17:15
@sl0thentr0py
WIP
2a4b8d5
@antonpirker
Merge branch 'master' into neel/kill-tracestate
a3bb2bd
@antonpirker
Cleaned up tests
4399d93
@antonpirker
Merge branch 'master' into neel/kill-tracestate
ba15991
@antonpirker
antonpirker requested a review from sl0thentr0py February 17, 2023 08:33
@antonpirker antonpirker self-assigned this Feb 17, 2023
sl0thentr0py
sl0thentr0py approved these changes Feb 17, 2023
View reviewed changes
@antonpirker
antonpirker merged commit f21fc0f into master Feb 17, 2023
@antonpirker
antonpirker deleted the neel/kill-tracestate branch February 17, 2023 10:06
@sentry-junior sentry-junior Bot mentioned this pull request Oct 29, 2026
ref(tracing): Remove unused base64_stripped regex #8148
Merged
sentrivana pushed a commit that referenced this pull request Oct 29, 2026
@sentry-junior
ref(tracing): Remove unused base64_stripped regex (#8148)
825ff97
### Description

Removes the module-level `base64_stripped` regex string from
`sentry_sdk/tracing_utils.py`. Nothing has used it since 2023.

#1179 (Sep 2021) added it to validate the base64-encoded Sentry entry in
the `tracestate` header. #1907 (Feb 2023, "Remove deprecated
`tracestate`") deleted its only use,
`re.search("^{b64}$".format(b64=base64_stripped), sentry_value)`, but
left the definition and its comment behind.

**Evidence**
- `git grep -n base64_stripped` across the whole repo matches only the
definition.
- `git log -S base64_stripped` shows exactly two commits: the one that
added it (#1179) and the one that removed its only caller (#1907).
- No open PR or issue in this repo mentions `base64_stripped`.

**Why it's safe**
- It's a plain string constant in an internal module. It's not
re-exported from `sentry_sdk` and doesn't appear in `docs/`,
`CHANGELOG.md` or `MIGRATION_GUIDE.md`.
- It was never compiled or read at runtime, so behavior doesn't change.
- `re` is still used by `SENTRY_TRACE_REGEX` and other code in the
module.

**Checks**
- `uv run ruff check` and `ruff format --check` on the file pass.
- `uv run --group typing mypy sentry_sdk` passes with no issues.
- `TESTPATH=tests/tracing uv run tox -e py3.14-common`: 426 passed.

#### Issues
None. Found by a dead-code sweep.

<!-- junior-request-attribution:start -->
via [automation
`sched_65eed06cc199036c2b13411096f412d4`](https://junior-prod.sentry.dev/automations/sched_65eed06cc199036c2b13411096f412d4)
· Run ID `sched_65eed06cc199036c2b13411096f412d4:1793269189822`.
<!-- junior-request-attribution:end -->

<!-- junior-session-footer:start -->
<!--
junior-conversation-id:agent-dispatch%3Adispatch_6c2737e59e7d308c80f5327fc5b5e320
-->

--

[View Junior
Session](https://junior-prod.sentry.dev/conversations/agent-dispatch%3Adispatch_6c2737e59e7d308c80f5327fc5b5e320)
[[Sentry]](https://sentry.sentry.io/explore/conversations/agent-dispatch%3Adispatch_6c2737e59e7d308c80f5327fc5b5e320/?project=4510944073809921)

<!-- junior-session-footer:end -->

Co-authored-by: sentry-junior[bot] <264270552+sentry-junior[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sl0thentr0py sl0thentr0py sl0thentr0py approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@antonpirker antonpirker

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@antonpirker @sl0thentr0py
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.