GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — fix(oci): cache tag lists and normalize manifest variants by abhinavgautam01 · Pull Request #280 · git-pkgs/proxy

Conversation

abhinavgautam01 commented Aug 22, 2026

Copy link

Copy Markdown

Contributor

Fixes #249

Summary

Cache OCI /v2/<name>/tags/list responses automatically, including when general metadata caching is disabled.
Serve stale cached tag lists when the upstream registry or token service is temporarily unavailable.
Normalize manifest Accept headers before deriving cache keys, so equivalent media-type lists reuse the same cached variant.
Verify a cached manifest's content type is acceptable for the requesting client before serving it.
Document OCI manifest and tag-list offline caching behavior.

Validation

gofmt
go tool golangci-lint run ./...
go vet ./...
go test -race ./...
git diff --check

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          fix(oci): cache tag lists and normalize manifest variants

52f1e05

andrew requested a lite review from Copilot

August 22, 2026 08:58

Copilot started reviewing on behalf of andrew

August 22, 2026 08:59

View session

Copilot AI reviewed

Aug 22, 2026

View reviewed changes

Copilot AI left a comment

Copy link

Copy Markdown

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR improves OCI offline behavior by caching tag-list responses and making manifest caching more robust across equivalent Accept header variants, so previously warmed caches can be reused when upstream registry/token services are unavailable.

Changes:

Add automatic caching (with stale fallback) for OCI /v2/<name>/tags/list responses, independent of general metadata caching.
Normalize manifest Accept headers for cache-key derivation and validate cached manifest content types against the caller’s Accept.
Add tests and documentation for OCI tag-list + manifest offline caching behavior.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
internal/handler/container.go	Routes tag-list requests through the new cached implementation.
internal/handler/container_tags.go	Implements tag-list caching, ETag revalidation, and stale fallback behavior.
internal/handler/container_manifest.go	Normalizes `Accept` for cache keys and validates cached manifest content type against request.
internal/handler/container_test.go	Adds coverage for stale tag-list fallback and manifest variant normalization/content-type gating.
docs/configuration.md	Documents always-cached OCI manifests and tag lists + stale behavior.
docs/architecture.md	Updates architecture notes to include tag lists as always-cached metadata.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

internal/handler/container_manifest.go Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

internal/handler/container_manifest.go Resolved

Uh oh!

There was an error while loading. Please reload this page.


          fix(oci): refine manifest cache variants

1bae32c

andrew requested changes

Aug 24, 2026

View reviewed changes

andrew left a comment

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address these cache compatibility issues:

Preserve reads of existing manifest cache keys. Previous releases hashed the raw Accept value, so the normalized key misses warmed entries after an upgrade. On a normalized-key miss, try the legacy key and rewrite the entry under the normalized key. Add an upgrade test using previous-format data.
Apply quality to the most specific matching Accept media range. Accept: application/vnd.oci.image.index.v1+json;q=0, */*;q=1 currently accepts the explicitly excluded index through the wildcard. Add a regression test.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          fix(oci): preserve manifest cache compatibility

299658a

abhinavgautam01 commented Aug 24, 2026

Copy link

Copy Markdown

Contributor Author

Thanks, implemented the legacy raw-Accept cache-key fallback with migration and upgrade coverage. Also fixed specificity-aware Accept matching so an explicit q=0 exclusion overrides a wildcard, with regression coverage.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

andrew requested changes

Aug 25, 2026

View reviewed changes

andrew left a comment

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please preserve mixed-version and rollback cache access. Fresh manifests are now stored only under the normalized Accept key. Older replicas and rollback releases still hash the raw Accept value, so they cannot read entries first cached by the new release. Dual-write the raw key when it differs, including the digest alias. Add a handler-level test that warms through the public route and verifies the previous-format key is written.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          fix(oci): dual-write manifest cache variants

7d06120

abhinavgautam01 commented Aug 25, 2026

Copy link

Copy Markdown

Contributor Author

Implemented dual-write support for normalized and legacy raw-Accept keys, including digest aliases. Added a handler-level warm-route test that verifies both previous-format keys are written.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

andrew requested changes

Aug 27, 2026

View reviewed changes

andrew left a comment

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address the two cache correctness issues in the inline comments.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

internal/handler/container_manifest.go Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

internal/handler/container_tags.go Resolved

Uh oh!

There was an error while loading. Please reload this page.


          fix(oci): preserve cached pagination links

abhinavgautam01 commented Aug 27, 2026

Copy link

Copy Markdown

Contributor Author

Addressed both cache-correctness issues and added handler-level regression coverage.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

andrew requested changes

Aug 28, 2026

View reviewed changes

andrew left a comment

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rewrite relative tag-list pagination Link targets for named registries. rewriteContainerTagsLink currently returns non-absolute targets unchanged, so a link such as </v2/owner/repo/tags/list?...> drops the upstream/<registry>/ selector and routes the next page to the default registry. Add a named-registry route test that follows the returned link.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          fix(oci): rewrite named registry pagination links

d4a3978

abhinavgautam01 commented Aug 28, 2026

Copy link

Copy Markdown

Contributor Author

Thanks, Fixed. Relative tag-list pagination links now retain the named-registry selector when rewritten through the proxy, with a route-level test that follows the returned link.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

andrew approved these changes

Sep 2, 2026

View reviewed changes

andrew left a comment

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for sticking with this — the relative-Link rewrite now keeps the named-registry selector and the follow-the-link test proves it end to end.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

andrew merged commit 1e3369c into git-pkgs:main

Sep 2, 2026

5 checks passed

Uh oh!

There was an error while loading. Please reload this page.

andrew mentioned this pull request

Sep 2, 2026

Use header constants across the handler package #301

Merged

andrew added a commit that referenced this pull request

Sep 2, 2026


          Use header constants across the handler package (#301)

c5e1483

goconst tripped on main after #259 landed on top of #280: five
composite-literal occurrences each of "Content-Length" and
"Content-Type" across container.go, container_manifest.go,
container_tags.go, handler.go, and swift.go crossed the
min-occurrences: 5 threshold. Neither PR hit it alone.

Add headerContentType and headerContentLength beside
headerAcceptEncoding and use them throughout the package rather than
only at the flagged sites, so the next handler that adds one does not
re-trip the check.

andrew added a commit that referenced this pull request

Sep 2, 2026


          Reconcile with #280 and #301 after rebase

5daabf3

Compute real manifest digests in #280's fixture upstreams so the new
verification accepts them, and add headerETag / headerLastModified to
#301's constant set so goconst passes with the new occurrences.

andrew added a commit that referenced this pull request

Sep 3, 2026


          Reconcile with #280 and #301 after rebase

cd1fe84

Compute real manifest digests in #280's fixture upstreams so the new
verification accepts them, and add headerETag / headerLastModified to

andrew added a commit that referenced this pull request

Sep 3, 2026


          Add Homebrew JSON API and bottle proxy support (#254)

b67cfb1

* Add Homebrew JSON API and bottle proxy support

* Fix Homebrew HEAD offline fallback and non-sha256 OCI manifest handling

Route Homebrew API HEAD requests through ProxyCached so a warm cache
answers without an upstream call and stale entries are served when the
upstream is unreachable. HEAD still reaches upstream as HEAD when
metadata caching is disabled.

Limit OCI manifest digest verification to sha256 references and
Docker-Content-Digest headers so other digest algorithms are proxied
instead of rejected, and log the failing expected value.

* Reconcile with #280 and #301 after rebase

Compute real manifest digests in #280's fixture upstreams so the new
verification accepts them, and add headerETag / headerLastModified to

* Send fixed Accept for Homebrew API and match If-None-Match properly

The Homebrew API cache key does not include Accept, so replaying the
client header could serve one representation under another; the API
does not negotiate anyway. Compare If-None-Match with weak comparison,
list splitting and "*" per RFC 7232 instead of string equality, and
apply the same helper to the metadata and swift responders.

* Reconcile with #298 and #304 after rebase

Move the configureScanning doc comment back to its function after the
auto-merge stacked it on mountProtocolHandlers, and drop the second
ETag/Last-Modified set in writeMetadataCachedResponse now that the
pre-304 set covers both response paths.

Reviewers

Copilot code review Copilot

Copilot review effort

Applies to this pull request for everyone.Learn more about Copilot code review.

Copilot left review comments

andrew

andrew approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Improve OCI offline caching for tag lists and manifest variants

Uh oh!

There was an error while loading. Please reload this page.

3 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.