GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — Modernizing and Implementing Autocompletebox by StanleyGoldman · Pull Request #2158 · github/VisualStudio

This repository was archived by the owner on Jun 21, 2023. It is now read-only.

Conversation

StanleyGoldman commented Jan 4, 2019 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Contributor

This pull request is the set of changes made to make AutoCompleteBox functional in our codebase

Using modern structures like Guard instead of Ensure
Removing the legacy cache system
Using GraphQL for querying data

Depends On

Implementing Autocompletebox #2159 being merged to this pull request

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

StanleyGoldman added 7 commits

January 4, 2019 10:46


          Changing services to use GraphQL library

c3fa22d


          Starting to implement autocomplete functionality

9e4d7f9


          Merge branch 'autocompletebox' into autocompletebox-fix

edca5b7


          Merge branch 'autocompletebox' into autocompletebox-fix

f5809f2


          Merge branch 'autocompletebox' into autocompletebox-fix

2911b35


          Merge branch 'autocompletebox-fix' into autocompletebox-implementation

ac4aab9


          Revert "Undoing changes to PullRequestCreationViewModel"

8906c54

This reverts commit 653cc79.

StanleyGoldman mentioned this pull request

Jan 4, 2019

Autocomplete for users and issues with '@' and '#' #2156

Merged

1 task done

StanleyGoldman added 3 commits

January 4, 2019 11:09


          Undoing some changes

bfa18c6


          Trying to display the control correctly

2c94748


          Exposing Advisor as a dependency property

027b322

meaghanlewis mentioned this pull request

Jan 15, 2019

Development sprint: February 25th release #2178

Closed

7 of 15 tasks

StanleyGoldman added 6 commits

January 24, 2019 09:52


          Merge branch 'autocompletebox' into autocompletebox-fix

1d133f9


          Merge branch 'autocompletebox-fix' into autocompletebox-implementation

3dba1d9


          Merge branch 'autocompletebox' into autocompletebox-fix

7aadd19


          Merge branch 'autocompletebox-fix' into autocompletebox-implementation

3ff1300


          Including missing themes

9d2ee84


          Commenting out event subscriptions

161b85e

meaghanlewis mentioned this pull request

Feb 25, 2019

Development Sprint: April 8 release #2240

Closed

StanleyGoldman added 11 commits

February 26, 2019 08:27


          Merge branch 'autocompletebox' into autocompletebox-fix

995321b


          Merge branch 'autocompletebox-fix' into autocompletebox-implementation

# Conflicts:
#	src/GitHub.VisualStudio.UI/Styles/ThemeBlue.xaml
#	src/GitHub.VisualStudio.UI/Styles/ThemeDark.xaml
#	src/GitHub.VisualStudio.UI/Styles/ThemeLight.xaml


          Including missing themes

01a5a5b


          Commenting out event subscriptions

8e5cb66


          Trying to simplify the observable

e1d75b7


          Use FromEventPattern instead of FromEvent

9fd2cac


          Tweaking ImportMany command

a9cf0c2


          Fixing view

62b71c2


          Importing ITeamExplorerContext

92fb304


          Merge branch 'autocompletebox-fix' into autocompletebox-implementation

b355b6c


          Removing extra control

0dbabcd

StanleyGoldman added 16 commits

March 28, 2019 11:10


          Merge branch 'feature/graphql-caching' into autocompletebox-fix

4e9a6dd


          Merge branch 'autocompletebox-fix' into autocompletebox-implementation

c40b757


          Merge branch 'autocompletebox-implementation' into jcansdale/autocomp…

d0a7965

…letebox-theme


          Merge branch 'autocompletebox' into autocompletebox-fix

4c97d48


          Merge branch 'autocompletebox-fix' into autocompletebox-implementation

3d539c8


          Merge branch 'autocompletebox-implementation' into jcansdale/autocomp…

28fc2f1

…letebox-theme


          Merge pull request #2292 from github/jcansdale/autocompletebox-theme

84c4dd1

Theme the auto complete box


          Merge branch 'autocompletebox' into autocompletebox-fix

280ec5f


          Merge branch 'autocompletebox-fix' into autocompletebox-implementation

0bd1903


          Undoing change

2027b5c


          Some code cleanup

7ab429a


          Merge branch 'autocompletebox' into autocompletebox-fix

70e33d4


          Merge branch 'autocompletebox-fix' into autocompletebox-implementation

40a452a


          Fixing xml comments all around


          Merge branch 'autocompletebox-fix' into autocompletebox-implementation

aa65fcc


          Merge pull request #2159 from github/autocompletebox-implementation

be1ab80

Implementing Autocompletebox

StanleyGoldman changed the title ~~[WIP] Modernizing Autocompletebox~~ Modernizing and Implementing Autocompletebox

Apr 8, 2019

StanleyGoldman added 2 commits

April 8, 2019 17:28


          Adding autocomplete functionality to inline comment view, pull reques…

25fbc2f

…t review and conversation view comments


          Merge branch 'autocompletebox' into autocompletebox-fix

122f767

meaghanlewis commented Apr 8, 2019

Copy link

Copy Markdown

Contributor

@StanleyGoldman would it be possible to also show pull requests in the autocomplete list in addition to issues?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

StanleyGoldman added 3 commits

April 8, 2019 20:38


          Fixing tests

72a82e5


          Using the GraphQL Search for Issues and Pull Requests

8a6737c


          Reverting submodule update

3995d0d

meaghanlewis commented Apr 10, 2019

Copy link

Copy Markdown

Contributor

@StanleyGoldman this is working well! One thing that differs from dotcom is that you only seem to filter on open issues/PRs (filter = $"repo:{owner}/{name} is:open";) where dotcom shows all.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.


          Allowing all issues closed or open

f1b538a

meaghanlewis approved these changes

Apr 10, 2019

View reviewed changes


          Merge branch 'autocompletebox' into autocompletebox-fix

76ebd75

meaghanlewis approved these changes

Apr 10, 2019

View reviewed changes

meaghanlewis left a comment

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This functionality works well for me. 👍

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

StanleyGoldman merged commit 0b5badb into autocompletebox

Apr 10, 2019

StanleyGoldman deleted the autocompletebox-fix branch

April 10, 2019 21:16

Reviewers

1 more reviewer

meaghanlewis

meaghanlewis approved these changes

Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

2.9.0

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

StanleyGoldman commented Jan 4, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Depends On

Uh oh!

meaghanlewis commented Apr 8, 2019

Uh oh!

meaghanlewis commented Apr 10, 2019

Uh oh!

meaghanlewis left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

StanleyGoldman commented Jan 4, 2019 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.