GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Implementing Autocompletebox by StanleyGoldman · Pull Request #2159 · github/VisualStudio

This repository was archived by the owner on Jun 21, 2023. It is now read-only.

Conversation

@StanleyGoldman

@StanleyGoldman StanleyGoldman commented Jan 4, 2019 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

This pull request is the set of changes made to implement AutoCompleteBox

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
StanleyGoldman added 3 commits January 4, 2019 10:47
@StanleyGoldman
Starting to implement autocomplete functionality
9e4d7f9
@StanleyGoldman
Merge branch 'autocompletebox-fix' into autocompletebox-implementation
ac4aab9
@StanleyGoldman
Revert "Undoing changes to PullRequestCreationViewModel"
8906c54 
This reverts commit 653cc79.
@StanleyGoldman StanleyGoldman mentioned this pull request Jan 4, 2019
Modernizing and Implementing Autocompletebox #2158
Merged
1 task done
StanleyGoldman added 2 commits January 4, 2019 11:09
@StanleyGoldman
Undoing some changes
bfa18c6
@StanleyGoldman
Trying to display the control correctly
2c94748
@meaghanlewis meaghanlewis mentioned this pull request Jan 15, 2019
Development sprint: February 25th release #2178
Closed
7 of 15 tasks
StanleyGoldman added 4 commits January 24, 2019 09:52
@StanleyGoldman
Merge branch 'autocompletebox-fix' into autocompletebox-implementation
3dba1d9
@StanleyGoldman
Merge branch 'autocompletebox-fix' into autocompletebox-implementation
3ff1300
@StanleyGoldman
Including missing themes
9d2ee84
@StanleyGoldman
Commenting out event subscriptions
161b85e
@meaghanlewis meaghanlewis mentioned this pull request Feb 25, 2019
Development Sprint: April 8 release #2240
Closed
StanleyGoldman added 3 commits February 26, 2019 08:29
@StanleyGoldman
Merge branch 'autocompletebox-fix' into autocompletebox-implementation
0649605 
# Conflicts:
#	src/GitHub.VisualStudio.UI/Styles/ThemeBlue.xaml
#	src/GitHub.VisualStudio.UI/Styles/ThemeDark.xaml
#	src/GitHub.VisualStudio.UI/Styles/ThemeLight.xaml
@StanleyGoldman
Merge branch 'autocompletebox-fix' into autocompletebox-implementation
b355b6c
@StanleyGoldman
Removing extra control
0dbabcd
@StanleyGoldman
StanleyGoldman force-pushed the autocompletebox-implementation branch from b311389 to 0dbabcd Compare February 26, 2019 17:37
@meaghanlewis meaghanlewis added this to the 2.9.0 milestone Feb 26, 2019
@StanleyGoldman
Merge branch 'autocompletebox-fix' into autocompletebox-implementation
4a2657e
@StanleyGoldman
StanleyGoldman force-pushed the autocompletebox-implementation branch from c6ddb31 to 4a2657e Compare March 11, 2019 16:13
StanleyGoldman added 5 commits March 11, 2019 14:19
@StanleyGoldman
Merge branch 'autocompletebox-fix' into autocompletebox-implementation
dd5ee9c
@StanleyGoldman
Merge branch 'autocompletebox-fix' into autocompletebox-implementation
c1855d9
@StanleyGoldman
Merge branch 'autocompletebox-fix' into autocompletebox-implementation
bf381a8
@StanleyGoldman
Merge branch 'autocompletebox-fix' into autocompletebox-implementation
df979af
@StanleyGoldman
Merge branch 'autocompletebox-fix' into autocompletebox-implementation
ea8f2db
@jcansdale

jcansdale commented Mar 25, 2019 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator

I just got the following exception/crash after @-ing myself and clicking on the avatar.

Application: devenv.exe
Framework Version: v4.0.30319
Description: The process was terminated due to an unhandled exception.
Exception Info: System.InvalidOperationException
   at GitHub.UI.Controls.AutoCompleteBox.AutoCompleteTextInputExtensions.GetExpandedText(GitHub.UI.IAutoCompleteTextInput, System.String, Int32)
   at GitHub.UI.AutoCompleteBox.ExpandSuggestion(System.String)
   at GitHub.UI.AutoCompleteBox.OnAdapterSelectionComplete(System.Object, System.Windows.RoutedEventArgs)
   at GitHub.UI.SelectorSelectionAdapter.OnCommit(System.Object, System.Windows.RoutedEventArgs)
   at GitHub.UI.SelectorSelectionAdapter.OnCommit()
   at GitHub.UI.SelectorSelectionAdapter.OnSelectorMouseLeftButtonUp(System.Object, System.Windows.Input.MouseButtonEventArgs)
   at System.Windows.Input.MouseButtonEventArgs.InvokeEventHandler(System.Delegate, System.Object)
   at System.Windows.RoutedEventArgs.InvokeHandler(System.Delegate, System.Object)
   at System.Windows.RoutedEventHandlerInfo.InvokeHandler(System.Object, System.Windows.RoutedEventArgs)
   at System.Windows.EventRoute.InvokeHandlersImpl(System.Object, System.Windows.RoutedEventArgs, Boolean)
   at System.Windows.UIElement.ReRaiseEventAs(System.Windows.DependencyObject, System.Windows.RoutedEventArgs, System.Windows.RoutedEvent)
   at System.Windows.UIElement.OnMouseUpThunk(System.Object, System.Windows.Input.MouseButtonEventArgs)
   at System.Windows.Input.MouseButtonEventArgs.InvokeEventHandler(System.Delegate, System.Object)
   at System.Windows.RoutedEventArgs.InvokeHandler(System.Delegate, System.Object)
   at System.Windows.RoutedEventHandlerInfo.InvokeHandler(System.Object, System.Windows.RoutedEventArgs)
   at System.Windows.EventRoute.InvokeHandlersImpl(System.Object, System.Windows.RoutedEventArgs, Boolean)
   at System.Windows.UIElement.RaiseEventImpl(System.Windows.DependencyObject, System.Windows.RoutedEventArgs)
   at System.Windows.ContentElement.RaiseTrustedEvent(System.Windows.RoutedEventArgs)
   at System.Windows.Input.InputManager.ProcessStagingArea()
   at System.Windows.Input.InputManager.ProcessInput(System.Windows.Input.InputEventArgs)
   at System.Windows.Input.InputProviderSite.ReportInput(System.Windows.Input.InputReport)
   at System.Windows.Interop.HwndMouseInputProvider.ReportInput(IntPtr, System.Windows.Input.InputMode, Int32, System.Windows.Input.RawMouseActions, Int32, Int32, Int32)
   at System.Windows.Interop.HwndMouseInputProvider.FilterMessage(IntPtr, MS.Internal.Interop.WindowMessage, IntPtr, IntPtr, Boolean ByRef)
   at System.Windows.Interop.HwndSource.InputFilterMessage(IntPtr, Int32, IntPtr, IntPtr, Boolean ByRef)
   at MS.Win32.HwndWrapper.WndProc(IntPtr, Int32, IntPtr, IntPtr, Boolean ByRef)
   at MS.Win32.HwndSubclass.DispatcherCallbackOperation(System.Object)
   at System.Windows.Threading.ExceptionWrapper.InternalRealCall(System.Delegate, System.Object, Int32)
   at System.Windows.Threading.ExceptionWrapper.TryCatchWhen(System.Object, System.Delegate, System.Object, Int32, System.Delegate)
   at System.Windows.Threading.Dispatcher.LegacyInvokeImpl(System.Windows.Threading.DispatcherPriority, System.TimeSpan, System.Delegate, System.Object, Int32)
   at MS.Win32.HwndSubclass.SubclassWndProc(IntPtr, Int32, IntPtr, IntPtr)

image

image
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
jcansdale and others added 5 commits March 25, 2019 17:23
@jcansdale
Merge branch 'fixes/dialog-style-guide' into autocompletebox-implemen…
df16579 
…tation
@jcansdale
Use VS theme colors for AutoCompleteBox
3a84e78
@StanleyGoldman
Merge branch 'autocompletebox-fix' into autocompletebox-implementation
dff9d67
@StanleyGoldman
Merge branch 'autocompletebox-fix' into autocompletebox-implementation
b228f02
@jcansdale
Merge remote-tracking branch 'origin/autocompletebox-implementation' …
ff19239 
…into jcansdale/autocompletebox-theme
@StanleyGoldman
Merge branch 'autocompletebox-fix' into autocompletebox-implementation
c40b757
@StanleyGoldman
StanleyGoldman force-pushed the autocompletebox-implementation branch from dcddf52 to c40b757 Compare March 28, 2019 15:11
StanleyGoldman added 8 commits March 28, 2019 11:11
@StanleyGoldman
Merge branch 'autocompletebox-implementation' into jcansdale/autocomp…
d0a7965 
…letebox-theme
@StanleyGoldman
Merge branch 'autocompletebox-fix' into autocompletebox-implementation
3d539c8
@StanleyGoldman
Merge branch 'autocompletebox-implementation' into jcansdale/autocomp…
28fc2f1 
…letebox-theme
@StanleyGoldman
Merge pull request #2292 from github/jcansdale/autocompletebox-theme
84c4dd1 
Theme the auto complete box
@StanleyGoldman
Merge branch 'autocompletebox-fix' into autocompletebox-implementation
0bd1903
@StanleyGoldman
Undoing change
2027b5c
@StanleyGoldman
Merge branch 'autocompletebox-fix' into autocompletebox-implementation
40a452a
@StanleyGoldman
Merge branch 'autocompletebox-fix' into autocompletebox-implementation
aa65fcc
@StanleyGoldman StanleyGoldman changed the title [WIP] Implementing Autocompletebox Implementing Autocompletebox Apr 8, 2019
@StanleyGoldman
StanleyGoldman merged commit be1ab80 into autocompletebox-fix Apr 8, 2019
@StanleyGoldman
StanleyGoldman deleted the autocompletebox-implementation branch April 8, 2019 14:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

2.9.0

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@StanleyGoldman @jcansdale @meaghanlewis
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.