GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fix OIDC credential property names by mbg · Pull Request #3807 · github/codeql-action

Conversation

@mbg

@mbg mbg commented Apr 9, 2026

Copy link
Copy Markdown
Member

Fixes an oversight in #3563. The JSON property names use - instead of _.

Risk assessment

For internal use only. Please select the risk level of this change:

  • Low risk: Changes are fully under feature flags, or have been fully tested and validated in pre-production environments and are highly observable, or are documentation or test only.

Which use cases does this change impact?

Workflow types:

  • Managed - Impacts users with dynamic workflows (Default Setup, Code Quality, ...).

Products:

  • Code Scanning - The changes impact analyses when analysis-kinds: code-scanning.
  • Code Quality - The changes impact analyses when analysis-kinds: code-quality.
  • Other first-party - The changes impact other first-party analyses.

Environments:

  • Dotcom - Impacts CodeQL workflows on github.com and/or GitHub Enterprise Cloud with Data Residency.
  • GHES - Impacts CodeQL workflows on GitHub Enterprise Server.

How did/will you validate this change?

  • Test repository - This change will be tested on a test repository before merging.
  • Unit tests - I am depending on unit test coverage (i.e. tests in .test.ts files).
  • End-to-end tests - I am depending on PR checks (i.e. tests in pr-checks).

If something goes wrong after this change is released, what are the mitigation and rollback strategies?

  • Rollback - Change can only be disabled by rolling back the release or releasing a new version with a fix.

How will you know if something goes wrong after this change is released?

  • Telemetry - I rely on existing telemetry or have made changes to the telemetry.
    • Dashboards - I will watch relevant dashboards for issues after the release. Consider whether this requires this change to be released at a particular time rather than as part of a regular release.
    • Alerts - New or existing monitors will trip if something goes wrong with this change.

Are there any special considerations for merging or releasing this change?

  • No special considerations - This change can be merged at any time.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Consider adding a changelog entry for this change.
  • Confirm the readme and docs have been updated if necessary.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@mbg
Fix OIDC credential property names
d277a56
@mbg mbg self-assigned this Apr 9, 2026
Copilot AI review requested due to automatic review settings April 9, 2026 16:50
@mbg
mbg requested a review from a team as a code owner April 9, 2026 16:50
@github-actions github-actions Bot added the size/M Should be of average difficulty to review label Apr 9, 2026
Copilot started reviewing on behalf of mbg April 9, 2026 16:51
View session
Copilot AI reviewed Apr 9, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR corrects the JSON property names used for OIDC credential configurations in the start-proxy action, switching from underscore-separated keys to hyphen-separated keys to match the expected schema.

Changes:

  • Update OIDC config types and validators (Azure/AWS/JFrog) to use hyphenated JSON keys.
  • Update getAuthConfig and credential pretty-printing to read/write the new keys.
  • Update unit tests to use the new key names (and regenerate lib/ output).
Show a summary per file
File Description
src/start-proxy/types.ts Switches OIDC config typing/validation and pretty-printing to hyphenated JSON property names.
src/start-proxy/types.test.ts Updates fixtures/expectations for OIDC credential string formatting with new keys.
src/start-proxy.ts Updates getAuthConfig normalization/output for OIDC configs to use hyphenated keys.
src/start-proxy.test.ts Updates OIDC test fixtures to use the new hyphenated keys.
lib/start-proxy-action.js Generated build output reflecting the TypeScript changes.

Copilot's findings

  • Files reviewed: 4/5 changed files
  • Comments generated: 3

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
mbg reacted with thumbs down emoji
All reactions
  • 👎 1 reaction
Comment thread src/start-proxy.ts Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread src/start-proxy/types.ts Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread src/start-proxy.test.ts Resolved

Uh oh!

There was an error while loading. Please reload this page.
henrymercer
henrymercer previously approved these changes Apr 9, 2026
View reviewed changes

@henrymercer henrymercer left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changelog note?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@mbg
Add changelog entry
7197c2b
@mbg
mbg dismissed henrymercer’s stale review via 7197c2b April 9, 2026 18:02
@mbg
mbg requested a review from henrymercer April 9, 2026 18:02
henrymercer
henrymercer approved these changes Apr 10, 2026
View reviewed changes
@mbg
mbg enabled auto-merge April 10, 2026 09:10
@mbg
mbg added this pull request to the merge queue Apr 10, 2026
Merged via the queue into main with commit a26cb68 Apr 10, 2026
227 of 228 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@mbg
mbg deleted the mbg/start-proxy/fix-field-names branch April 10, 2026 09:38
sam-robson pushed a commit that referenced this pull request Apr 10, 2026
@mbg @sam-robson
Merge pull request #3807 from github/mbg/start-proxy/fix-field-names
13a18e6 
Fix OIDC credential property names
This was referenced Apr 15, 2026
Merge main into releases/v4 #3824
Merged
Merge releases/v4 into releases/v3 #3826
Merged
@github-actions github-actions Bot mentioned this pull request May 18, 2026
chore(ci)(deps): bump github/codeql-action from 3.35.4 to 4.35.5 ag-ui-protocol/ag-ui#1711
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@henrymercer henrymercer henrymercer approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@mbg mbg

Labels

size/M Should be of average difficulty to review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@mbg @henrymercer
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.