GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Always enable `git_source` registries by mbg · Pull Request #4000 · github/codeql-action

Conversation

@mbg

@mbg mbg commented Jul 8, 2026

Copy link
Copy Markdown
Member

This PR changes the language-based registry configuration filtering logic in the start-proxy action to always enable git_source registries since git_source registries are useful outside of language-specific contexts.

Risk assessment

For internal use only. Please select the risk level of this change:

  • High risk: Changes are not fully under feature flags, have limited visibility and/or cannot be tested outside of production.

Which use cases does this change impact?

Workflow types:

  • Managed - Impacts users with dynamic workflows (Default Setup, Code Quality, ...).

Products:

  • Code Scanning - The changes impact analyses when analysis-kinds: code-scanning.
  • Code Quality - The changes impact analyses when analysis-kinds: code-quality.
  • Other first-party - The changes impact other first-party analyses.

Environments:

  • Dotcom - Impacts CodeQL workflows on github.com and/or GitHub Enterprise Cloud with Data Residency.

How did/will you validate this change?

  • Unit tests - I am depending on unit test coverage (i.e. tests in .test.ts files).
  • End-to-end tests - I am depending on PR checks (i.e. tests in pr-checks).

If something goes wrong after this change is released, what are the mitigation and rollback strategies?

  • Rollback - Change can only be disabled by rolling back the release or releasing a new version with a fix.

How will you know if something goes wrong after this change is released?

  • Telemetry - I rely on existing telemetry or have made changes to the telemetry.
    • Dashboards - I will watch relevant dashboards for issues after the release. Consider whether this requires this change to be released at a particular time rather than as part of a regular release.
    • Alerts - New or existing monitors will trip if something goes wrong with this change.

Are there any special considerations for merging or releasing this change?

  • No special considerations - This change can be merged at any time.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Consider adding a changelog entry for this change.
  • Confirm the readme and docs have been updated if necessary.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@mbg
Always enable git_source registries
ef79560
@mbg mbg self-assigned this Jul 8, 2026
Copilot AI review requested due to automatic review settings July 8, 2026 16:15
@mbg
mbg requested a review from a team as a code owner July 8, 2026 16:15
@mbg
mbg requested a review from mario-campos July 8, 2026 16:15
@github-actions github-actions Bot added the size/S Should be easy to review label Jul 8, 2026
Copilot started reviewing on behalf of mbg July 8, 2026 16:15
View session
Copilot AI reviewed Jul 8, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Warning

  • Copilot's review of this pull request may be incomplete because some of the changed files are excluded by your Copilot content exclusion settings. See Excluding content from Copilot for details.

Pull request overview

This PR updates start-proxy’s registry-credential filtering so that git_source registries are always enabled, even when credentials are otherwise filtered by language. This aligns with the stated goal that git_source registries can be used by generic workflow components (not only language-specific ones).

Changes:

  • Introduce an “always enabled” registry-type allowlist (currently git_source) and apply it during language-based filtering.
  • Adjust registry-credential tests to cover the new always-enabled behavior.
Show a summary per file
File Description
src/start-proxy.ts Adds an always-enabled registry-type list and updates credential filtering logic accordingly.
src/start-proxy.test.ts Updates/extends tests to validate git_source credentials are always returned across languages.
lib/entry-points.js Generated/excluded by policy (not reviewed).

Review details

Files excluded by content exclusion policy (1)
  • lib/entry-points.js
  • Files reviewed: 2/3 changed files
  • Comments generated: 4
  • Review effort level: Low

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Comment thread src/start-proxy.ts Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread src/start-proxy.ts Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread src/start-proxy.ts Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread src/start-proxy.test.ts Resolved

Uh oh!

There was an error while loading. Please reload this page.

mbg added 3 commits July 9, 2026 12:03
@mbg
Fix previously wrong comment
2831d9a
@mbg
Make ALWAYS_ENABLED_REGISTRY_TYPE read-only
c7d9083
@mbg
Merge branch 'main' into mbg/start-proxy/make-git-repos-always-available
ff973a1
mario-campos
mario-campos approved these changes Jul 10, 2026
View reviewed changes

@mario-campos mario-campos left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@mbg
mbg added this pull request to the merge queue Jul 10, 2026
Merged via the queue into main with commit 85830a2 Jul 10, 2026
225 checks passed

Uh oh!

There was an error while loading. Please reload this page.

@mbg
mbg deleted the mbg/start-proxy/make-git-repos-always-available branch July 10, 2026 13:57
@mbg mbg mentioned this pull request Jul 14, 2026
Use private registry proxy for API requests when available #4007
Merged
This was referenced Jul 16, 2026
Merge main into releases/v4 #4020
Merged
Merge releases/v4 into releases/v3 #4022
Merged
@mbg mbg mentioned this pull request Jul 20, 2026
Always make docker_registry registries available #4024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@mario-campos mario-campos mario-campos approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@mbg mbg

Labels

size/S Should be easy to review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@mbg @mario-campos
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.