GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Always make `docker_registry` registries available by mbg · Pull Request #4024 · github/codeql-action

Conversation

@mbg

@mbg mbg commented Jul 20, 2026

Copy link
Copy Markdown
Member

A similar change as in #4000, which makes docker_registry registries always available to the workflow. The CLI can use Docker-style registries for custom query packs.

Risk assessment

For internal use only. Please select the risk level of this change:

  • Low risk: Changes are fully under feature flags, or have been fully tested and validated in pre-production environments and are highly observable, or are documentation or test only.

Which use cases does this change impact?

Workflow types:

  • Managed - Impacts users with dynamic workflows (Default Setup, Code Quality, ...).

Products:

  • Code Scanning - The changes impact analyses when analysis-kinds: code-scanning.
  • Code Quality - The changes impact analyses when analysis-kinds: code-quality.
  • Other first-party - The changes impact other first-party analyses.

Environments:

  • Dotcom - Impacts CodeQL workflows on github.com and/or GitHub Enterprise Cloud with Data Residency.
  • GHES - Impacts CodeQL workflows on GitHub Enterprise Server.

How did/will you validate this change?

  • Unit tests - I am depending on unit test coverage (i.e. tests in .test.ts files).

If something goes wrong after this change is released, what are the mitigation and rollback strategies?

  • Rollback - Change can only be disabled by rolling back the release or releasing a new version with a fix.

How will you know if something goes wrong after this change is released?

  • Telemetry - I rely on existing telemetry or have made changes to the telemetry.
    • Dashboards - I will watch relevant dashboards for issues after the release. Consider whether this requires this change to be released at a particular time rather than as part of a regular release.
    • Alerts - New or existing monitors will trip if something goes wrong with this change.

Are there any special considerations for merging or releasing this change?

  • No special considerations - This change can be merged at any time.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Consider adding a changelog entry for this change.
  • Confirm the readme and docs have been updated if necessary.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@mbg
Always make docker_registry registries available
b855687
@mbg
mbg requested a review from mario-campos July 20, 2026 18:58
@mbg mbg self-assigned this Jul 20, 2026
@mbg
mbg requested a review from a team as a code owner July 20, 2026 18:58
Copilot AI review requested due to automatic review settings July 20, 2026 18:58
@github-actions github-actions Bot added the size/XS Should be very easy to review label Jul 20, 2026
Copilot started reviewing on behalf of mbg July 20, 2026 18:59
View session
Copilot AI reviewed Jul 20, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Warning

  • Copilot's review of this pull request may be incomplete because some of the changed files are excluded by your Copilot content exclusion settings. See Excluding content from Copilot for details.

Pull request overview

Makes Docker registry credentials available across all language workflows so the CodeQL CLI can access custom query packs.

Changes:

  • Adds docker_registry to always-enabled registry types.
  • Extends tests across Actions and all built-in languages.
Show a summary per file
File Description
src/start-proxy.ts Always enables Docker registry credentials.
src/start-proxy.test.ts Tests Docker credentials as always enabled.
lib/entry-points.js Generated output; excluded by policy.

Review details

Files excluded by content exclusion policy (1)
  • lib/entry-points.js
  • Files reviewed: 2/3 changed files
  • Comments generated: 0
  • Review effort level: Medium

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
mario-campos
mario-campos approved these changes Jul 21, 2026
View reviewed changes

@mario-campos mario-campos left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
ellisonantoniafelicia-star
ellisonantoniafelicia-star approved these changes Jul 21, 2026
View reviewed changes
@ellisonantoniafelicia-star

This comment has been minimized.

Sign in to view
@mbg
mbg added this pull request to the merge queue Jul 21, 2026
Merged via the queue into main with commit 69fd9e9 Jul 21, 2026
226 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@mbg
mbg deleted the mbg/private-registry/make-docker-available branch July 21, 2026 11:14
This was referenced Jul 21, 2026
Merge main into releases/v4 #4027
Merged
Merge releases/v4 into releases/v3 #4029
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@mario-campos mario-campos mario-campos approved these changes
+1 more reviewer
@ellisonantoniafelicia-star ellisonantoniafelicia-star ellisonantoniafelicia-star approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@mbg mbg

Labels

size/XS Should be very easy to review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@mbg @ellisonantoniafelicia-star @mario-campos
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.